From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11441 invoked by alias); 24 Jul 2017 07:03:22 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 11418 invoked by uid 89); 24 Jul 2017 07:03:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-23.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_ASCII_DIVIDERS,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: gate.crashing.org Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 24 Jul 2017 07:03:17 +0000 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.13.8) with ESMTP id v6O73E73009096 for ; Mon, 24 Jul 2017 02:03:14 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id v6O73EM7009095 for gcc-patches@gcc.gnu.org; Mon, 24 Jul 2017 02:03:14 -0500 Date: Mon, 24 Jul 2017 07:03:00 -0000 From: Segher Boessenkool To: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Do not silently continue if config.{build,host,gcc} fails Message-ID: <20170724070313.GQ13471@gate.crashing.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-IsSubscribed: yes X-SW-Source: 2017-07/txt/msg01390.txt.bz2 Ping? Segher On Mon, May 15, 2017 at 04:29:24PM +0000, Segher Boessenkool wrote: > If config.{build,host,gcc} fails, configure currently silently > continues. This then makes it much harder than necessary to notice > you made a stupid pasto in config.gcc (and where exactly). > > This patch fixes it, by terminating if one of the config.* fails. > > Testing in progress (on powerpc64-linux); is this okay for trunk if > it passes? > > > Segher > > > 2017-05-15 Segher Boessenkool > > * configure.ac: If any of the config.* scripts fail, exit 1. > * configure: Regenerate. > > --- > gcc/configure | 6 +++--- > gcc/configure.ac | 6 +++--- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/gcc/configure b/gcc/configure > index c823ffe..f3c7465 100755 > --- a/gcc/configure > +++ b/gcc/configure > @@ -11489,15 +11489,15 @@ fi > # -------------------------------------------------------- > > # Collect build-machine-specific information. > -. ${srcdir}/config.build > +. ${srcdir}/config.build || exit 1 > > # Collect host-machine-specific information. > -. ${srcdir}/config.host > +. ${srcdir}/config.host || exit 1 > > target_gtfiles= > > # Collect target-machine-specific information. > -. ${srcdir}/config.gcc > +. ${srcdir}/config.gcc || exit 1 > > extra_objs="${host_extra_objs} ${extra_objs}" > extra_gcc_objs="${host_extra_gcc_objs} ${extra_gcc_objs}" > diff --git a/gcc/configure.ac b/gcc/configure.ac > index acfe979..c24e83f 100644 > --- a/gcc/configure.ac > +++ b/gcc/configure.ac > @@ -1442,15 +1442,15 @@ fi > # -------------------------------------------------------- > > # Collect build-machine-specific information. > -. ${srcdir}/config.build > +. ${srcdir}/config.build || exit 1 > > # Collect host-machine-specific information. > -. ${srcdir}/config.host > +. ${srcdir}/config.host || exit 1 > > target_gtfiles= > > # Collect target-machine-specific information. > -. ${srcdir}/config.gcc > +. ${srcdir}/config.gcc || exit 1 > > extra_objs="${host_extra_objs} ${extra_objs}" > extra_gcc_objs="${host_extra_gcc_objs} ${extra_gcc_objs}" > -- > 1.9.3