From: James Greenhalgh <james.greenhalgh@arm.com>
To: "Hurugalawadi, Naveen" <Naveen.Hurugalawadi@cavium.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Richard Earnshaw <Richard.Earnshaw@arm.com>,
Marcus Shawcroft <marcus.shawcroft@arm.com>,
"nd@arm.com" <nd@arm.com>,
"Pinski, Andrew" <Andrew.Pinski@cavium.com>
Subject: Re: [PATCH][AArch64] vec_pack_trunc_<mode> should split after register allocator
Date: Tue, 25 Jul 2017 08:57:00 -0000 [thread overview]
Message-ID: <20170725085728.GA26092@arm.com> (raw)
In-Reply-To: <CO2PR07MB269349D65A1FA849EAEC224C83B80@CO2PR07MB2693.namprd07.prod.outlook.com>
On Tue, Jul 25, 2017 at 07:30:49AM +0000, Hurugalawadi, Naveen wrote:
> Hi,
>
> >> I think we can split this whenever we like, and
> >> that there isn't any benefit in keeping the pair together?
>
> Thanks for the review and your views.
Thanks for the updated patch, and sorry that I haven't been clear in what
I was asking for.
I was wondering why we could not use an insn_and_split without the
reload_completed guard - there is probably still value in allowing other
optimisation passes to see that we can support:
[(set (match_operand:<VNARROWQ2> 0 "register_operand" "")
(vec_concat:<VNARROWQ2>
(truncate:<VNARROWQ> (match_operand:VQN 1 "register_operand" "w"))
(truncate:<VNARROWQ> (match_operand:VQN 2 "register_operand" "w"))))]
but an expand pattern is not going to permit that.
Could you switch this back to an insn_and_split as it was in the previous
patch, and just drop the && reload_completed ?
Thanks,
James
>
> The patch is modified as per your suggestion.
>
> Please review the patch and let me know if its okay?
>
> Bootstrapped and Regression done on AArch64-Thunder-Linux.
>
> Thanks,
> Naveen
> diff --git a/gcc/config/aarch64/aarch64-simd.md b/gcc/config/aarch64/aarch64-simd.md
> index 1cb6eeb..a41edad 100644
> --- a/gcc/config/aarch64/aarch64-simd.md
> +++ b/gcc/config/aarch64/aarch64-simd.md
> @@ -1291,6 +1291,18 @@
> [(set_attr "type" "neon_shift_imm_narrow_q")]
> )
>
> +(define_insn "aarch64_simd_vec_pack_trunc_hi_<mode>"
> + [(set (match_operand:<VNARROWQ2> 0 "register_operand" "=w")
> + (vec_concat:<VNARROWQ2>
> + (truncate:<VNARROWQ> (match_operand:VQN 1 "register_operand" "w"))
> + (vec_select:<VNARROWQ>
> + (match_operand:<VNARROWQ2> 3 "register_operand" "0")
> + (match_operand:<VNARROWQ2> 2 "vect_par_cnst_hi_half" ""))))]
> + "TARGET_SIMD"
> + "xtn2\\t%0.<V2ntype>, %1.<Vtype>"
> + [(set_attr "type" "neon_shift_imm_narrow_q")]
> +)
> +
> (define_expand "vec_pack_trunc_<mode>"
> [(match_operand:<VNARROWD> 0 "register_operand" "")
> (match_operand:VDN 1 "register_operand" "")
> @@ -1309,20 +1321,39 @@
>
> ;; For quads.
>
> -(define_insn "vec_pack_trunc_<mode>"
> - [(set (match_operand:<VNARROWQ2> 0 "register_operand" "=&w")
> +(define_expand "vec_pack_trunc_<mode>"
> + [(set (match_operand:<VNARROWQ2> 0 "register_operand" "")
> (vec_concat:<VNARROWQ2>
> - (truncate:<VNARROWQ> (match_operand:VQN 1 "register_operand" "w"))
> - (truncate:<VNARROWQ> (match_operand:VQN 2 "register_operand" "w"))))]
> + (truncate:<VNARROWQ> (match_operand:VQN 1 "register_operand" ""))
> + (truncate:<VNARROWQ> (match_operand:VQN 2 "register_operand" ""))))]
> "TARGET_SIMD"
> {
> if (BYTES_BIG_ENDIAN)
> - return "xtn\\t%0.<Vntype>, %2.<Vtype>\;xtn2\\t%0.<V2ntype>, %1.<Vtype>";
> + {
> + rtx low_part = gen_lowpart (<VNARROWQ>mode, operands[0]);
> + emit_insn (gen_aarch64_simd_vec_pack_trunc_<mode> (low_part,
> + operands[2]));
> + rtx high_part = aarch64_simd_vect_par_cnst_half (<VNARROWQ2>mode,
> + true);
> + emit_insn (gen_aarch64_simd_vec_pack_trunc_hi_<mode> (operands[0],
> + operands[1],
> + high_part,
> + operands[0]));
> + }
> else
> - return "xtn\\t%0.<Vntype>, %1.<Vtype>\;xtn2\\t%0.<V2ntype>, %2.<Vtype>";
> + {
> + rtx low_part = gen_lowpart (<VNARROWQ>mode, operands[0]);
> + emit_insn (gen_aarch64_simd_vec_pack_trunc_<mode> (low_part,
> + operands[1]));
> + rtx high_part = aarch64_simd_vect_par_cnst_half (<VNARROWQ2>mode,
> + true);
> + emit_insn (gen_aarch64_simd_vec_pack_trunc_hi_<mode> (operands[0],
> + operands[2],
> + high_part,
> + operands[0]));
> + }
> + DONE;
> }
> - [(set_attr "type" "multiple")
> - (set_attr "length" "8")]
> )
>
> ;; Widening operations.
next prev parent reply other threads:[~2017-07-25 8:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 7:37 Hurugalawadi, Naveen
2017-05-11 5:43 ` [PING] [PATCH] [AArch64] " Hurugalawadi, Naveen
2017-05-26 6:27 ` [PING 2] " Hurugalawadi, Naveen
2017-06-15 3:49 ` [PING 3] " Hurugalawadi, Naveen
2017-06-30 6:29 ` [PING 4] " Hurugalawadi, Naveen
2017-07-19 2:57 ` [PING 5] " Hurugalawadi, Naveen
2017-07-21 16:42 ` [PATCH][AArch64] " James Greenhalgh
2017-07-25 7:30 ` Hurugalawadi, Naveen
2017-07-25 8:57 ` James Greenhalgh [this message]
2017-07-25 11:40 ` Hurugalawadi, Naveen
[not found] ` <CO2PR07MB26932740F6783B49FB886B7983890@CO2PR07MB2693.namprd07.prod.outlook.com>
2017-08-11 6:09 ` [PING] [PATCH] [AArch64] " Hurugalawadi, Naveen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170725085728.GA26092@arm.com \
--to=james.greenhalgh@arm.com \
--cc=Andrew.Pinski@cavium.com \
--cc=Naveen.Hurugalawadi@cavium.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=marcus.shawcroft@arm.com \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).