From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111769 invoked by alias); 25 Jul 2017 12:49:43 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 111657 invoked by uid 89); 25 Jul 2017 12:49:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=H*Ad:U*matz X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 25 Jul 2017 12:49:36 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 29A25356F4; Tue, 25 Jul 2017 12:49:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 29A25356F4 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jakub@redhat.com Received: from tucnak.zalov.cz (ovpn-116-143.ams2.redhat.com [10.36.116.143]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B18988F349; Tue, 25 Jul 2017 12:49:34 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id v6PCnV2e023936; Tue, 25 Jul 2017 14:49:31 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id v6PCnSZ1023935; Tue, 25 Jul 2017 14:49:28 +0200 Date: Tue, 25 Jul 2017 12:49:00 -0000 From: Jakub Jelinek To: Martin =?utf-8?B?TGnFoWth?= Cc: Michael Matz , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Move static chain and non-local goto init after NOTE_INSN_FUNCTION_BEG (PR sanitize/81186). Message-ID: <20170725124928.GT2123@tucnak> Reply-To: Jakub Jelinek References: <25c189f3-82db-eaa2-8803-2d7ab0727055@suse.cz> <4846559c-7951-6d3e-e4ac-85ec7b8c3c19@suse.cz> <12b96c93-4ec2-5b67-7ae8-5551b5aadeb5@suse.cz> <99d1bcb3-5213-d21d-d1ee-205c1420146f@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <99d1bcb3-5213-d21d-d1ee-205c1420146f@suse.cz> User-Agent: Mutt/1.7.1 (2016-10-04) X-IsSubscribed: yes X-SW-Source: 2017-07/txt/msg01545.txt.bz2 On Tue, Jul 18, 2017 at 10:38:50AM +0200, Martin Liška wrote: > 2017-06-27 Martin Liska > > PR sanitize/81186 8 spaces instead of tab? > * function.c (expand_function_start): Set parm_birth_insn after > static chain is initialized. I don't like this description, after all, parm_birth_insn was set after static chain initialization before too (just not right after it in some cases). The important change is that you've moved parm_birth_insn before the nonlocal_goto_save_area setup code, so IMHO the ChangeLog entry should say that. As for the patch itself, there are many spots which insert some code before or after parm_birth_insn or spots tied to the NOTE_INSN_FUNCTION_BEG note, but I'd hope nothing inserted there can actually call functions that perform non-local gotos, so I think the patch is fine. And for debug info experience which is also related to NOTE_INSN_FUNCTION_BEG, I think the nl goto save area is nothing that can be seen in the debugger unless you know where it is, so the only change might be if you put a breakpoint on the end of prologue (i.e. NOTE_INSN_FUNCTION_BEG) and call from inferios some function that performs a non-local goto. I think there are no barriers on that initialization anyway, so scheduler can move it around. Thus, ok for trunk/7.2 with the above suggested ChangeLog change. Jakub