From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-459022-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 13730 invoked by alias); 26 Jul 2017 14:26:36 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 13700 invoked by uid 89); 26 Jul 2017 14:26:35 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: mx1.suse.de
Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 26 Jul 2017 14:26:34 +0000
Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254])	by mx1.suse.de (Postfix) with ESMTP id 5EF3CAC2F;	Wed, 26 Jul 2017 14:26:31 +0000 (UTC)
Date: Wed, 26 Jul 2017 14:26:00 -0000
From: Torsten Duwe <duwe@suse.de>
To: Andreas Schwab <schwab@suse.de>
Cc: "Richard Earnshaw (lists)" <Richard.Earnshaw@arm.com>,	Sandra Loosemore <sandra@codesourcery.com>,	Maxim Kuvyrkov <maxim.kuvyrkov@gmail.com>,	Marek Polacek <polacek@redhat.com>,	Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org>,	GCC Patches <gcc-patches@gcc.gnu.org>,	Szabolcs Nagy <szabolcs.nagy@arm.com>, nd@arm.com,	Li Bin <huawei.libin@huawei.com>, Jiri Kosina <jkosina@suse.cz>,	Marcus Shawcroft <Marcus.Shawcroft@arm.com>,	Takahiro Akashi <takahiro.akashi@linaro.org>,	Andrew Wafaa <Andrew.Wafaa@arm.com>
Subject: Re: [PATCH v12] add -fpatchable-function-entry=N,M option
Message-ID: <20170726142629.GG22969@suse.de>
References: <20170706140311.GA20710@suse.de> <d3e6d7a1-1f1c-c0b5-133a-0ab29eb5034d@arm.com> <20170707193028.GA17752@suse.de> <mvmbmo7uvuu.fsf@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <mvmbmo7uvuu.fsf@suse.de>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-SW-Source: 2017-07/txt/msg01671.txt.bz2

On Wed, Jul 26, 2017 at 04:16:25PM +0200, Andreas Schwab wrote:
> On Jul 07 2017, Torsten Duwe <duwe@suse.de> wrote:
> 
> > diff --git a/gcc/testsuite/c-c++-common/patchable_function_entry-decl.c b/gcc/testsuite/c-c++-common/patchable_function_entry-decl.c
> > new file mode 100644
> > index 00000000000..8514b10e820
> > --- /dev/null
> > +++ b/gcc/testsuite/c-c++-common/patchable_function_entry-decl.c
> > @@ -0,0 +1,16 @@
> > +/* { dg-do compile } */
> > +/* { dg-options "-O2 -fpatchable-function-entry=3,1" } */
> > +/* { dg-final { scan-assembler-times "nop" 2 } } */
> 
> This fails on ia64.

The solution is fairly obvious: on architectures where the nop is not called
"nop" provide a custom, cpu-specific test, or document the failure.

	Torsten