From: James Greenhalgh <james.greenhalgh@arm.com>
To: Kyrill Tkachov <kyrylo.tkachov@foss.arm.com>
Cc: <gcc-patches@gcc.gnu.org>, <nd@arm.com>,
<richard.earnshaw@arm.com>, <marcus.shawcroft@arm.com>
Subject: Re: [Mechanical Patch ARM/AArch64 1/2] Rename load/store scheduling types to encode data size
Date: Thu, 27 Jul 2017 18:09:00 -0000 [thread overview]
Message-ID: <20170727180915.GA8643@arm.com> (raw)
In-Reply-To: <20170621104947.GB35273@arm.com>
On Wed, Jun 21, 2017 at 11:49:47AM +0100, James Greenhalgh wrote:
> On Mon, Jun 12, 2017 at 03:28:52PM +0100, Kyrill Tkachov wrote:
*ping ^2*
Thanks,
James
> >
> > On 12/06/17 14:53, James Greenhalgh wrote:
> > >Hi,
> > >
> > >In the AArch64 backend and scheduling models there is some confusion as to
> > >what the load1/load2 etc. scheduling types refer to. This leads to us using
> > >load1/load2 in two contexts - for a variety of 32-bit, 64-bit and 128-bit
> > >loads in AArch32 and 128-bit loads in AArch64. That leads to an undesirable
> > >confusion in scheduling.
> > >
> > >Fixing it is easy, but mechanical and boring. Essentially,
> > >
> > > s/load1/load_4/
> > > s/load2/load_8/
> > > s/load3/load_12/
> > > s/load4/load_16/
> > > s/store1/store_4/
> > > s/store2/store_8/
> > > s/store3/store_12/
> > > s/store4/store_16/
> >
> > So the number now is the number of bytes being loaded?
> >
> > >Across all sorts of pipeline models, and the two backends.
> > >
> > >I have intentionally not modified any of the patterns which now look obviously
> > >incorrect. I'll be doing a second pass over the AArch64 back-end in patch
> > >2/2 which will fix these bugs. The AArch32 back-end looked to me to get this
> > >correct.
> > >
> > >Bootstrapped on AArch64 and ARM without issue - there's no functional
> > >change here.
> > >
> > >OK?
> >
> > Ok from an arm perspective.
>
> *Ping* for the AArch64 maintainers.
next prev parent reply other threads:[~2017-07-27 18:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-12 13:54 James Greenhalgh
2017-06-12 13:54 ` [Patch AArch64 2/2] Fix memory sizes to load/store patterns James Greenhalgh
2017-06-21 10:50 ` James Greenhalgh
2017-07-03 10:47 ` James Greenhalgh
2017-07-27 18:10 ` James Greenhalgh
2017-09-12 15:00 ` James Greenhalgh
2017-07-03 10:47 ` James Greenhalgh
2017-06-12 14:28 ` [Mechanical Patch ARM/AArch64 1/2] Rename load/store scheduling types to encode data size Kyrill Tkachov
2017-06-21 10:50 ` James Greenhalgh
2017-07-27 18:09 ` James Greenhalgh [this message]
2017-09-12 14:54 James Greenhalgh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170727180915.GA8643@arm.com \
--to=james.greenhalgh@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kyrylo.tkachov@foss.arm.com \
--cc=marcus.shawcroft@arm.com \
--cc=nd@arm.com \
--cc=richard.earnshaw@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).