From: Trevor Saunders <tbsaunde@tbsaunde.org>
To: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
Cc: gcc-patches@gcc.gnu.org,
Richard Biener <richard.guenther@gmail.com>,
tbsaunde+gcc@tbsaunde.org
Subject: Re: [PATCH 00/19] cleanup of memory stats prototypes
Date: Sat, 29 Jul 2017 01:08:00 -0000 [thread overview]
Message-ID: <20170729010814.ymvtirrqqhrbpnn2@ball> (raw)
In-Reply-To: <BED7C8C5-2344-4343-A4DB-6DAE6DA4A1BD@gmail.com>
On Fri, Jul 28, 2017 at 06:31:05PM +0200, Bernhard Reutner-Fischer wrote:
> On 27 July 2017 10:43:09 CEST, Richard Biener <richard.guenther@gmail.com> wrote:
> >On Thu, Jul 27, 2017 at 10:30 AM, <tbsaunde+gcc@tbsaunde.org> wrote:
> >> From: Trevor Saunders <tbsaunde+gcc@tbsaunde.org>
> >>
> >> The preC++ way of passing information about the call site of a
> >function was to
> >> use a macro that passed __file__, __LINE__, and __FUNCTION__ to a
> >function with
> >> the same name with _stat appended to it. The way this is now done
> >with C++ is
> >> to have arguments where the default value is __LINE__, __FILE__, and
> >> __FUNCTION__ in the caller. This has the significant advantage that
> >if you
> >> look for "^function (" you find the correct function, where in the C
> >way of
> >> doing things you need to realize its a macro and check the definition
> >of the
> >> macro to see what to look for next. So this removes a layer of
> >indirection,
> >> and makes things somewhat more consistant in using the C++ way of
> >doing things.
> >>
> >> patches independently bootstrapped and regtested on
> >ppc64le-linux-gnu. I
> >> successfully ran make all-gcc with
> >--enable-gather-detailed-mem-stats, but
> >> couldn't complete a bootstrap before the series was applied, because
> >the
> >> ddrs_table in tree-loop-distribution.c causes memory statistics
> >gathering to crash before the series as well as after it. ok?
> >
> >Thanks! This was on my list of things todo...
> >
> >The series is ok.
>
> Maybe s/enum tree_code/tree_code/ in the lines you touch?
I'd rather leave that to a separate patch and just do it for all of gcc/
at once.
Trev
next prev parent reply other threads:[~2017-07-29 1:08 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-27 8:30 tbsaunde+gcc
2017-07-27 8:30 ` [PATCH 10/19] use c++ for tree_cons_stat tbsaunde+gcc
2017-07-27 8:30 ` [PATCH 07/19] replace gimple_alloc_stat with c++ tbsaunde+gcc
2017-07-27 8:30 ` [PATCH 04/19] use c++ for make_int_cst_stat tbsaunde+gcc
2017-07-27 8:30 ` [PATCH 03/19] use cxx instead of make_tree_binfo_stat tbsaunde+gcc
2017-07-27 8:30 ` [PATCH 08/19] use c++ instead of build_decl_stat tbsaunde+gcc
2017-07-27 8:30 ` [PATCH 14/19] replace rtx_alloc_stat with c++ tbsaunde+gcc
2017-07-27 8:30 ` [PATCH 06/19] use c++ instead of {make,grow}_tree_vec_stat tbsaunde+gcc
2017-07-27 8:31 ` [PATCH 01/19] use c++ instead of make_node_stat tbsaunde+gcc
2017-07-27 8:31 ` [PATCH 12/19] use C++ for {make,build}_vector_stat tbsaunde+gcc
2017-07-27 8:31 ` [PATCH 17/19] use c++ for bitmap_initialize tbsaunde+gcc
2017-07-27 8:31 ` [PATCH 18/19] use c++ for gimple_build_debug_bind{,_source} tbsaunde+gcc
2017-07-27 8:31 ` [PATCH 19/19] use c++ for fold_buildN_loc tbsaunde+gcc
2017-07-27 8:31 ` [PATCH 09/19] use c++ instead of build_vl_exp_stat tbsaunde+gcc
2017-07-27 8:31 ` [PATCH 11/19] remove unused build_var_debug_value prototype tbsaunde+gcc
2017-07-27 8:31 ` [PATCH 05/19] use c++ instead of buildN_stat{,_loc} tbsaunde+gcc
2017-07-27 8:31 ` [PATCH 13/19] use c++ for build_tree_list{,_vec}_stat tbsaunde+gcc
2017-07-27 8:31 ` [PATCH 15/19] replace shallow_copy_rtx_stat with c++ tbsaunde+gcc
2017-07-27 8:31 ` [PATCH 02/19] use c++ instead of _stat for copy_node_stat tbsaunde+gcc
2017-07-27 8:31 ` [PATCH 16/19] simplify the bitmap alloc_stat functions with c++ tbsaunde+gcc
2017-07-27 8:43 ` [PATCH 00/19] cleanup of memory stats prototypes Richard Biener
2017-07-28 16:32 ` Bernhard Reutner-Fischer
2017-07-29 1:08 ` Trevor Saunders [this message]
2017-07-29 1:10 ` Trevor Saunders
2017-07-31 18:33 ` Jeff Law
2017-07-31 20:56 ` Martin Sebor
2017-07-31 21:34 ` Trevor Saunders
2017-07-31 22:58 ` Martin Sebor
2017-07-31 23:11 ` Trevor Saunders
2017-08-01 0:11 ` Martin Sebor
2017-08-01 9:05 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170729010814.ymvtirrqqhrbpnn2@ball \
--to=tbsaunde@tbsaunde.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=rep.dot.nop@gmail.com \
--cc=richard.guenther@gmail.com \
--cc=tbsaunde+gcc@tbsaunde.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).