* PATCH for base_pool_allocator (PR other/81667)
@ 2017-08-02 12:45 Marek Polacek
2017-08-02 12:53 ` Richard Biener
0 siblings, 1 reply; 2+ messages in thread
From: Marek Polacek @ 2017-08-02 12:45 UTC (permalink / raw)
To: GCC Patches
This PR points out that m_elt_size was left uninitialized in the member
initializer list for base_pool_allocator. I think it makes sense to initialize
it like this.
Bootstrapped/regtested on x86_64-linux, ok for trunk?
2017-08-02 Marek Polacek <polacek@redhat.com>
PR other/81667
* alloc-pool.h (base_pool_allocator): Initialize m_elt_size.
diff --git gcc/alloc-pool.h gcc/alloc-pool.h
index a5236db3dae..1d04e5d2cfe 100644
--- gcc/alloc-pool.h
+++ gcc/alloc-pool.h
@@ -240,8 +240,9 @@ base_pool_allocator <TBlockAllocator>::base_pool_allocator (
const char *name, size_t size MEM_STAT_DECL):
m_name (name), m_id (0), m_elts_per_block (0), m_returned_free_list (NULL),
m_virgin_free_list (NULL), m_virgin_elts_remaining (0), m_elts_allocated (0),
- m_elts_free (0), m_blocks_allocated (0), m_block_list (NULL), m_size (size),
- m_initialized (false), m_location (ALLOC_POOL_ORIGIN, false PASS_MEM_STAT) {}
+ m_elts_free (0), m_blocks_allocated (0), m_block_list (NULL), m_elt_size (0),
+ m_size (size), m_initialized (false),
+ m_location (ALLOC_POOL_ORIGIN, false PASS_MEM_STAT) {}
/* Initialize a pool allocator. */
Marek
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: PATCH for base_pool_allocator (PR other/81667)
2017-08-02 12:45 PATCH for base_pool_allocator (PR other/81667) Marek Polacek
@ 2017-08-02 12:53 ` Richard Biener
0 siblings, 0 replies; 2+ messages in thread
From: Richard Biener @ 2017-08-02 12:53 UTC (permalink / raw)
To: Marek Polacek; +Cc: GCC Patches
On Wed, Aug 2, 2017 at 2:45 PM, Marek Polacek <polacek@redhat.com> wrote:
> This PR points out that m_elt_size was left uninitialized in the member
> initializer list for base_pool_allocator. I think it makes sense to initialize
> it like this.
>
> Bootstrapped/regtested on x86_64-linux, ok for trunk?
Ok.
Richard.
> 2017-08-02 Marek Polacek <polacek@redhat.com>
>
> PR other/81667
> * alloc-pool.h (base_pool_allocator): Initialize m_elt_size.
>
> diff --git gcc/alloc-pool.h gcc/alloc-pool.h
> index a5236db3dae..1d04e5d2cfe 100644
> --- gcc/alloc-pool.h
> +++ gcc/alloc-pool.h
> @@ -240,8 +240,9 @@ base_pool_allocator <TBlockAllocator>::base_pool_allocator (
> const char *name, size_t size MEM_STAT_DECL):
> m_name (name), m_id (0), m_elts_per_block (0), m_returned_free_list (NULL),
> m_virgin_free_list (NULL), m_virgin_elts_remaining (0), m_elts_allocated (0),
> - m_elts_free (0), m_blocks_allocated (0), m_block_list (NULL), m_size (size),
> - m_initialized (false), m_location (ALLOC_POOL_ORIGIN, false PASS_MEM_STAT) {}
> + m_elts_free (0), m_blocks_allocated (0), m_block_list (NULL), m_elt_size (0),
> + m_size (size), m_initialized (false),
> + m_location (ALLOC_POOL_ORIGIN, false PASS_MEM_STAT) {}
>
> /* Initialize a pool allocator. */
>
>
> Marek
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-02 12:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-02 12:45 PATCH for base_pool_allocator (PR other/81667) Marek Polacek
2017-08-02 12:53 ` Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).