From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 116426 invoked by alias); 2 Aug 2017 15:55:23 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 116408 invoked by uid 89); 2 Aug 2017 15:55:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*Ad:U*segher X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 02 Aug 2017 15:55:21 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C2D9FC0587F2; Wed, 2 Aug 2017 15:55:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C2D9FC0587F2 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jakub@redhat.com Received: from tucnak.zalov.cz (ovpn-116-40.ams2.redhat.com [10.36.116.40]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 567467F760; Wed, 2 Aug 2017 15:55:19 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id v72FtFD2014661; Wed, 2 Aug 2017 17:55:16 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id v72FtBmJ014660; Wed, 2 Aug 2017 17:55:11 +0200 Date: Wed, 02 Aug 2017 15:55:00 -0000 From: Jakub Jelinek To: Bill Schmidt , "Joseph S. Myers" Cc: GCC Patches , Segher Boessenkool , David Edelsohn Subject: Re: [PATCH, rs6000] Clean up capitalized diagnostic messages Message-ID: <20170802155511.GL2123@tucnak> Reply-To: Jakub Jelinek References: <9a2980f0-01ed-1474-c4a2-f743695d60f8@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9a2980f0-01ed-1474-c4a2-f743695d60f8@linux.vnet.ibm.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-IsSubscribed: yes X-SW-Source: 2017-08/txt/msg00191.txt.bz2 On Wed, Aug 02, 2017 at 10:29:20AM -0500, Bill Schmidt wrote: > --- gcc/config/rs6000/rs6000.c (revision 250791) > +++ gcc/config/rs6000/rs6000.c (working copy) > @@ -4132,7 +4132,7 @@ rs6000_option_override_internal (bool global_init_ > || rs6000_cpu == PROCESSOR_PPCE5500) > { > if (TARGET_ALTIVEC) > - error ("AltiVec not supported in this target"); > + error ("altivec not supported in this target"); If AltiVec is spelled that way always, then I think we want to keep it capitalized, but CCing Joseph just to be sure. Or the diagnostics could be reworded not to have AltiVec first. > @@ -4250,7 +4250,7 @@ rs6000_option_override_internal (bool global_init_ > rs6000_isa_flags |= (ISA_3_0_MASKS_SERVER & ~ignore_masks); > } > else > - error ("Power9 target option is incompatible with -mcpu= for " > + error ("power9 target option is incompatible with -mcpu= for " > " less than power9"); > } > else if ((ISA_3_0_MASKS_SERVER & rs6000_isa_flags_explicit) Similarly, not sure about this one, but isn't it about -mpower9-minmax being incompatible with -mcpu option not supporting power9 ISA? The and talking about less for strings that aren't necessarily ordered is just weird. > @@ -11226,7 +11226,7 @@ rs6000_return_in_memory (const_tree type, const_tr > static bool warned_for_return_big_vectors = false; > if (!warned_for_return_big_vectors) > { > - warning (OPT_Wpsabi, "GCC vector returned by reference: " > + warning (OPT_Wpsabi, "gcc vector returned by reference: " > "non-standard ABI extension with no compatibility guarantee"); > warned_for_return_big_vectors = true; > } > @@ -12773,7 +12773,7 @@ rs6000_pass_by_reference (cumulative_args_t cum AT > fprintf (stderr, "function_arg_pass_by_reference: synthetic vector\n"); > if (!warned_for_pass_big_vectors) > { > - warning (OPT_Wpsabi, "GCC vector passed by reference: " > + warning (OPT_Wpsabi, "gcc vector passed by reference: " > "non-standard ABI extension with no compatibility guarantee"); > warned_for_pass_big_vectors = true; > } GCC I think needs to be capitalized. Not sure if talking about GCC vector is clear, it is talking about the GNU vector extension, perhaps GNU instead? The rest of the changes look good to me, but I'll defer review to the target maintainers. Jakub