From: Trevor Saunders <tbsaunde@tbsaunde.org>
To: Martin Sebor <msebor@gmail.com>
Cc: tbsaunde+gcc@tbsaunde.org, gcc-patches@gcc.gnu.org, palves@redhat.com
Subject: Re: [PATCH 0/2] add unique_ptr class
Date: Sat, 05 Aug 2017 05:32:00 -0000 [thread overview]
Message-ID: <20170805053219.iyaxt3yyeap24cid@ball> (raw)
In-Reply-To: <11913480-7af2-60ef-4dbe-8d7115c34a8d@gmail.com>
On Fri, Aug 04, 2017 at 04:43:32PM -0600, Martin Sebor wrote:
> On 07/31/2017 05:46 PM, tbsaunde+gcc@tbsaunde.org wrote:
> > From: Trevor Saunders <tbsaunde+gcc@tbsaunde.org>
> >
> > Hi,
> >
> > I've been saying I'd do this for a long time, but I'm finally getting to
> > importing the C++98 compatable unique_ptr class Pedro wrote for gdb a while
> > back. I believe the gtl namespace also comes from Pedro, but GNU template
> > library seems as reasonable as any other name I can come up with. I'm not sure
> > at the moment what outside of gcc may want to use this, but putting it include/
> > at least allows us to use it in libcpp which may be useful. I didn't include
> > too much usage in this series, but I believe other people have wanted this too,
> > so I'm reasonably confident it will get a fair amount of usage.
> >
> > patches individually bootstrapped + regtested on ppc64-linux-gnu, ok?
>
> FWIW, I'm a big fan of RAII and I like the idea being able to
> rely on a smart pointer in GCC quite a bit. Although I haven't
> reviewed the C++ 03 implementation in any detail I like how the
> new API is just transitional until GCC switches from C++ 98 to
> C++ 11 when it will be possible to drop it, presumably with no
> changes to client code. (If there's any risk that clients might
> come to depend on the C++ 03 "features" or limitations in the
> meantime and thus jeopardize this goal I would only suggest to
> put some effort into making this harder.)
Given that stage 2 / 3 of a bootstrap is as C++14 I expect that it would
be pretty hard to put in code that works with the shim, but not real
unique_ptr, since in a bootstrap situation both would be used.
> Other than that, thank you for this nice enhancement!
your welcome
Trev
>
> Martin
>
next prev parent reply other threads:[~2017-08-05 5:32 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 23:46 tbsaunde+gcc
2017-07-31 23:46 ` [PATCH 1/2] add unique_ptr header tbsaunde+gcc
2017-08-01 14:40 ` David Malcolm
2017-08-02 3:09 ` Trevor Saunders
2017-08-04 19:55 ` Jonathan Wakely
2017-08-05 5:39 ` Trevor Saunders
2017-10-11 18:52 ` David Malcolm
2017-10-12 14:08 ` Trevor Saunders
2017-10-13 3:05 ` [PATCH] Add gnu::unique_ptr David Malcolm
2017-10-13 9:36 ` Richard Biener
2017-10-13 12:08 ` Pedro Alves
2017-10-14 0:35 ` [PATCH] Implement unique_xmalloc_ptr<T[]> and add more selftests David Malcolm
2017-10-16 10:53 ` Pedro Alves
2017-10-16 21:04 ` [committed] Add gnu::unique_ptr David Malcolm
2017-10-19 17:27 ` Gerald Pfeifer
2017-10-19 17:41 ` David Malcolm
2017-10-22 11:40 ` Gerald Pfeifer
2017-08-02 8:14 ` [PATCH 1/2] add unique_ptr header Richard Biener
2017-07-31 23:46 ` [PATCH 2/2] use unique_ptr some tbsaunde+gcc
2017-08-01 0:51 ` [PATCH 0/2] add unique_ptr class David Malcolm
2017-08-04 18:52 ` Jonathan Wakely
2017-08-05 5:36 ` Trevor Saunders
2017-08-07 13:01 ` Jonathan Wakely
2017-08-05 19:05 ` Pedro Alves
2017-08-11 21:30 ` Jonathan Wakely
2017-09-03 1:24 ` Trevor Saunders
2017-09-04 9:31 ` Richard Biener
2017-09-04 10:05 ` Pedro Alves
2017-09-05 16:52 ` Manuel López-Ibáñez
2017-09-05 17:40 ` Pedro Alves
2017-09-06 12:35 ` replace libiberty with gnulib (was: Re: [PATCH 0/2] add unique_ptr class) Manuel López-Ibáñez
2017-08-04 22:43 ` [PATCH 0/2] add unique_ptr class Martin Sebor
2017-08-05 5:32 ` Trevor Saunders [this message]
2017-08-14 8:26 Ville Voutilainen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170805053219.iyaxt3yyeap24cid@ball \
--to=tbsaunde@tbsaunde.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=msebor@gmail.com \
--cc=palves@redhat.com \
--cc=tbsaunde+gcc@tbsaunde.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).