* [PATCH, rs6000] Fix diagnostic fallout for 32-bit
@ 2017-08-07 18:26 Bill Schmidt
2017-08-07 22:07 ` Segher Boessenkool
0 siblings, 1 reply; 2+ messages in thread
From: Bill Schmidt @ 2017-08-07 18:26 UTC (permalink / raw)
To: GCC Patches; +Cc: Segher Boessenkool, David Edelsohn
Hi,
A previous patch addressed capitalization issues with diagnostics in the POWER backend.
Unfortunately I failed to test this code on 32-bit targets, and there are some additional
test cases that run only in 32-bit mode that now fail. This patch cleans those up.
Tested on powerpc64-linux-gnu (POWER7, 32- and 64-bit) and powerpc64le-linux-gnu (POWER8,
64-bit) with no further regressions. Is this ok for trunk?
Thanks,
Bill
2017-08-07 Bill Schmidt <wschmidt@linux.vnet.ibm.com>
* gcc.target/powerpc/bfp/scalar-extract-exp-2.c: Adjust diagnostic
string.
* gcc.target/powerpc/bfp/scalar-extract-exp-5.c: Likewise.
* gcc.target/powerpc/bfp/scalar-extract-sig-2.c: Likewise.
* gcc.target/powerpc/bfp/scalar-extract-sig-5.c: Likewise.
* gcc.target/powerpc/bfp/scalar-insert-exp-11.c: Likewise.
* gcc.target/powerpc/bfp/scalar-insert-exp-2.c: Likewise.
* gcc.target/powerpc/bfp/scalar-insert-exp-5.c: Likewise.
* gcc.target/powerpc/bfp/scalar-insert-exp-8.c: Likewise.
* gcc.target/powerpc/byte-in-set-2.c: Likewise.
* gcc.target/powerpc/cmpb-3.c: Likewise.
* gcc.target/powerpc/vsu/vec-xl-len-13.c: Likewise.
* gcc.target/powerpc/vsu/vec-xst-len-13.c: Likewise.
Index: gcc/testsuite/gcc.target/powerpc/bfp/scalar-extract-exp-2.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/bfp/scalar-extract-exp-2.c (revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/bfp/scalar-extract-exp-2.c (working copy)
@@ -15,7 +15,7 @@ get_exponent (double *p)
{
double source = *p;
- return scalar_extract_exp (source); /* { dg-error "Builtin function __builtin_vec_scalar_extract_exp not supported in this compiler configuration" } */
+ return scalar_extract_exp (source); /* { dg-error "builtin function __builtin_vec_scalar_extract_exp not supported in this compiler configuration" } */
}
Index: gcc/testsuite/gcc.target/powerpc/bfp/scalar-extract-exp-5.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/bfp/scalar-extract-exp-5.c (revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/bfp/scalar-extract-exp-5.c (working copy)
@@ -15,7 +15,7 @@ get_exponent (__ieee128 *p)
{
__ieee128 source = *p;
- return scalar_extract_exp (source); /* { dg-error "Builtin function __builtin_vec_scalar_extract_exp not supported in this compiler configuration" } */
+ return scalar_extract_exp (source); /* { dg-error "builtin function __builtin_vec_scalar_extract_exp not supported in this compiler configuration" } */
}
Index: gcc/testsuite/gcc.target/powerpc/bfp/scalar-extract-sig-2.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/bfp/scalar-extract-sig-2.c (revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/bfp/scalar-extract-sig-2.c (working copy)
@@ -13,5 +13,5 @@ get_significand (double *p)
{
double source = *p;
- return __builtin_vec_scalar_extract_sig (source); /* { dg-error "Builtin function __builtin_vec_scalar_extract_sig not supported in this compiler configuration" } */
+ return __builtin_vec_scalar_extract_sig (source); /* { dg-error "builtin function __builtin_vec_scalar_extract_sig not supported in this compiler configuration" } */
}
Index: gcc/testsuite/gcc.target/powerpc/bfp/scalar-extract-sig-5.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/bfp/scalar-extract-sig-5.c (revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/bfp/scalar-extract-sig-5.c (working copy)
@@ -13,5 +13,5 @@ get_significand (__ieee128 *p)
{
__ieee128 source = *p;
- return __builtin_vec_scalar_extract_sig (source); /* { dg-error "Builtin function __builtin_vec_scalar_extract_sig not supported in this compiler configuration" } */
+ return __builtin_vec_scalar_extract_sig (source); /* { dg-error "builtin function __builtin_vec_scalar_extract_sig not supported in this compiler configuration" } */
}
Index: gcc/testsuite/gcc.target/powerpc/bfp/scalar-insert-exp-11.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/bfp/scalar-insert-exp-11.c (revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/bfp/scalar-insert-exp-11.c (working copy)
@@ -17,5 +17,5 @@ insert_exponent (__ieee128 *significand_p,
__ieee128 significand = *significand_p;
unsigned long long int exponent = *exponent_p;
- return scalar_insert_exp (significand, exponent); /* { dg-error "Builtin function __builtin_vec_scalar_insert_exp not supported in this compiler configuration" } */
+ return scalar_insert_exp (significand, exponent); /* { dg-error "builtin function __builtin_vec_scalar_insert_exp not supported in this compiler configuration" } */
}
Index: gcc/testsuite/gcc.target/powerpc/bfp/scalar-insert-exp-2.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/bfp/scalar-insert-exp-2.c (revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/bfp/scalar-insert-exp-2.c (working copy)
@@ -17,5 +17,5 @@ insert_exponent (unsigned long long int *significa
unsigned long long int significand = *significand_p;
unsigned long long int exponent = *exponent_p;
- return scalar_insert_exp (significand, exponent); /* { dg-error "Builtin function __builtin_vec_scalar_insert_exp not supported in this compiler configuration" } */
+ return scalar_insert_exp (significand, exponent); /* { dg-error "builtin function __builtin_vec_scalar_insert_exp not supported in this compiler configuration" } */
}
Index: gcc/testsuite/gcc.target/powerpc/bfp/scalar-insert-exp-5.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/bfp/scalar-insert-exp-5.c (revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/bfp/scalar-insert-exp-5.c (working copy)
@@ -17,5 +17,5 @@ insert_exponent (double *significand_p,
double significand = *significand_p;
unsigned long long int exponent = *exponent_p;
- return scalar_insert_exp (significand, exponent); /* { dg-error "Builtin function __builtin_vec_scalar_insert_exp not supported in this compiler configuration" } */
+ return scalar_insert_exp (significand, exponent); /* { dg-error "builtin function __builtin_vec_scalar_insert_exp not supported in this compiler configuration" } */
}
Index: gcc/testsuite/gcc.target/powerpc/bfp/scalar-insert-exp-8.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/bfp/scalar-insert-exp-8.c (revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/bfp/scalar-insert-exp-8.c (working copy)
@@ -17,5 +17,5 @@ insert_exponent (unsigned __int128 *significand_p,
unsigned __int128 significand = *significand_p; /* { dg-error "'__int128' is not supported on this target" } */
unsigned long long int exponent = *exponent_p;
- return scalar_insert_exp (significand, exponent); /* { dg-error "Builtin function __builtin_vec_scalar_insert_exp not supported in this compiler configuration" } */
+ return scalar_insert_exp (significand, exponent); /* { dg-error "builtin function __builtin_vec_scalar_insert_exp not supported in this compiler configuration" } */
}
Index: gcc/testsuite/gcc.target/powerpc/byte-in-set-2.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/byte-in-set-2.c (revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/byte-in-set-2.c (working copy)
@@ -12,5 +12,5 @@
int
test_byte_in_set (unsigned char b, unsigned long long set_members)
{
- return __builtin_byte_in_set (b, set_members); /* { dg-error "Builtin function __builtin_byte_in_set not supported in this compiler configuration" } */
+ return __builtin_byte_in_set (b, set_members); /* { dg-error "builtin function __builtin_byte_in_set not supported in this compiler configuration" } */
}
Index: gcc/testsuite/gcc.target/powerpc/cmpb-3.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/cmpb-3.c (revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/cmpb-3.c (working copy)
@@ -9,7 +9,7 @@ void abort ();
long long int
do_compare (long long int a, long long int b)
{
- return __builtin_cmpb (a, b); /* { dg-error "Builtin function __builtin_cmpb not supported in this compiler configuration" } */
+ return __builtin_cmpb (a, b); /* { dg-error "builtin function __builtin_cmpb not supported in this compiler configuration" } */
}
void expect (long long int pattern, long long int value)
Index: gcc/testsuite/gcc.target/powerpc/vsu/vec-xl-len-13.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/vsu/vec-xl-len-13.c (revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/vsu/vec-xl-len-13.c (working copy)
@@ -14,5 +14,5 @@
__vector float
fetch_data (float *address, size_t length)
{
- return __builtin_vec_lxvl (address, length); /* { dg-error "Builtin function __builtin_vec_lxvl not supported in this compiler configuration" } */
+ return __builtin_vec_lxvl (address, length); /* { dg-error "builtin function __builtin_vec_lxvl not supported in this compiler configuration" } */
}
Index: gcc/testsuite/gcc.target/powerpc/vsu/vec-xst-len-13.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/vsu/vec-xst-len-13.c (revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/vsu/vec-xst-len-13.c (working copy)
@@ -15,5 +15,5 @@ store_data (vector double *datap, double *address,
{
vector double data = *datap;
- __builtin_vec_stxvl (data, address, length); /* { dg-error "Builtin function __builtin_altivec_stxvl requires" } */
+ __builtin_vec_stxvl (data, address, length); /* { dg-error "builtin function __builtin_altivec_stxvl requires" } */
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH, rs6000] Fix diagnostic fallout for 32-bit
2017-08-07 18:26 [PATCH, rs6000] Fix diagnostic fallout for 32-bit Bill Schmidt
@ 2017-08-07 22:07 ` Segher Boessenkool
0 siblings, 0 replies; 2+ messages in thread
From: Segher Boessenkool @ 2017-08-07 22:07 UTC (permalink / raw)
To: Bill Schmidt; +Cc: GCC Patches, David Edelsohn
On Mon, Aug 07, 2017 at 01:25:51PM -0500, Bill Schmidt wrote:
> A previous patch addressed capitalization issues with diagnostics in the POWER backend.
> Unfortunately I failed to test this code on 32-bit targets, and there are some additional
> test cases that run only in 32-bit mode that now fail. This patch cleans those up.
>
> Tested on powerpc64-linux-gnu (POWER7, 32- and 64-bit) and powerpc64le-linux-gnu (POWER8,
> 64-bit) with no further regressions. Is this ok for trunk?
Okay, thanks!
Segher
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-07 22:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-07 18:26 [PATCH, rs6000] Fix diagnostic fallout for 32-bit Bill Schmidt
2017-08-07 22:07 ` Segher Boessenkool
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).