From: Segher Boessenkool <segher@kernel.crashing.org>
To: Will Schmidt <will_schmidt@vnet.ibm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Bill Schmidt <wschmidt@linux.vnet.ibm.com>
Subject: Re: [PATCH, rs6000] fold-vec testcase fix-ups
Date: Thu, 10 Aug 2017 14:09:00 -0000 [thread overview]
Message-ID: <20170810134554.GB13471@gate.crashing.org> (raw)
In-Reply-To: <1502371637.6577.48.camel@brimstone.rchland.ibm.com>
On Thu, Aug 10, 2017 at 08:27:17AM -0500, Will Schmidt wrote:
> A testcase coverage issue and an obvious typo fix.
>
> Mostly obvious,.. OK for trunk?
Yes; one comment:
> diff --git a/gcc/testsuite/gcc.target/powerpc/fold-vec-pack-longlong.c b/gcc/testsuite/gcc.target/powerpc/fold-vec-pack-longlong.c
> index d8acc3c..73131bb 100644
> --- a/gcc/testsuite/gcc.target/powerpc/fold-vec-pack-longlong.c
> +++ b/gcc/testsuite/gcc.target/powerpc/fold-vec-pack-longlong.c
> @@ -1,9 +1,9 @@
> /* Verify that overloaded built-ins for vec_pack with long long
> inputs produce the right results. */
>
> -/* { dg-do compile } */
> +/* { dg-do compile { target { powerpc*-*-* && lp64 } } } */
> /* { dg-require-effective-target powerpc_p8vector_ok } */
> /* { dg-options "-mvsx -mpower8-vector -O2" } */
You can just say
/* { dg-do compile { target lp64 } } */
(make sure to test before you commit :-) )
Segher
prev parent reply other threads:[~2017-08-10 13:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-10 13:39 Will Schmidt
2017-08-10 14:09 ` Segher Boessenkool [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170810134554.GB13471@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=will_schmidt@vnet.ibm.com \
--cc=wschmidt@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).