From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 74834 invoked by alias); 10 Aug 2017 13:46:30 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 74539 invoked by uid 89); 10 Aug 2017 13:46:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: gate.crashing.org Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 10 Aug 2017 13:46:09 +0000 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.13.8) with ESMTP id v7ADk3gt020231; Thu, 10 Aug 2017 08:46:04 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id v7ADk1xu020228; Thu, 10 Aug 2017 08:46:01 -0500 Date: Thu, 10 Aug 2017 14:09:00 -0000 From: Segher Boessenkool To: Will Schmidt Cc: GCC Patches , Bill Schmidt Subject: Re: [PATCH, rs6000] fold-vec testcase fix-ups Message-ID: <20170810134554.GB13471@gate.crashing.org> References: <1502371637.6577.48.camel@brimstone.rchland.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1502371637.6577.48.camel@brimstone.rchland.ibm.com> User-Agent: Mutt/1.4.2.3i X-IsSubscribed: yes X-SW-Source: 2017-08/txt/msg00746.txt.bz2 On Thu, Aug 10, 2017 at 08:27:17AM -0500, Will Schmidt wrote: > A testcase coverage issue and an obvious typo fix. > > Mostly obvious,.. OK for trunk? Yes; one comment: > diff --git a/gcc/testsuite/gcc.target/powerpc/fold-vec-pack-longlong.c b/gcc/testsuite/gcc.target/powerpc/fold-vec-pack-longlong.c > index d8acc3c..73131bb 100644 > --- a/gcc/testsuite/gcc.target/powerpc/fold-vec-pack-longlong.c > +++ b/gcc/testsuite/gcc.target/powerpc/fold-vec-pack-longlong.c > @@ -1,9 +1,9 @@ > /* Verify that overloaded built-ins for vec_pack with long long > inputs produce the right results. */ > > -/* { dg-do compile } */ > +/* { dg-do compile { target { powerpc*-*-* && lp64 } } } */ > /* { dg-require-effective-target powerpc_p8vector_ok } */ > /* { dg-options "-mvsx -mpower8-vector -O2" } */ You can just say /* { dg-do compile { target lp64 } } */ (make sure to test before you commit :-) ) Segher