From: Torsten Duwe <duwe@suse.de>
To: Jim Wilson <wilson@tuliptree.org>
Cc: Andreas Schwab <schwab@suse.de>,
Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: [PATCH] skip patchable_function_entry tests on ia64
Date: Fri, 11 Aug 2017 12:42:00 -0000 [thread overview]
Message-ID: <20170811103429.5vmf4hlpox5abxnu@suse.de> (raw)
In-Reply-To: <B3ACC0F7-B23C-428B-95BF-A5AA853C1208@linaro.org>
As Andreas found out, patchable_function_entry tests generate false failures
on ia64. On a closer look, this feature needs some more thought on itanium:
I *could* imagine it is a good idea to generate N complete nop "bundles",
which would be properly aligned and allow for easy replacement with alternate
binary code.
But I'd rather leave this to the platform experts, or whoever comes up with
a good use case, to implement the proper cpu override hook. Meanwhile, as
long as the expected results remain undefined, disable the tests.
Torsten
gcc/testsuite/ChangeLog
2017-08-11 Torsten Duwe <duwe@suse.de>
* c-c++-common/patchable_function_entry-default.c: Skip test on ia64.
* c-c++-common/patchable_function_entry-decl.c: Likewise.
* c-c++-common/patchable_function_entry-definition.c: Likewise.
diff --git a/gcc/testsuite/c-c++-common/patchable_function_entry-decl.c b/gcc/testsuite/c-c++-common/patchable_function_entry-decl.c
index 5c39a354559..e35dce4f3d8 100644
--- a/gcc/testsuite/c-c++-common/patchable_function_entry-decl.c
+++ b/gcc/testsuite/c-c++-common/patchable_function_entry-decl.c
@@ -1,4 +1,5 @@
/* { dg-do compile { target { ! nvptx*-*-* } } } */
+/* { dg-skip-if "undefined padding" { "ia64*-*-*" } { "*" } { "" } } */
/* { dg-options "-O2 -fpatchable-function-entry=3,1" } */
/* { dg-final { scan-assembler-times "nop" 2 } } */
diff --git a/gcc/testsuite/c-c++-common/patchable_function_entry-default.c b/gcc/testsuite/c-c++-common/patchable_function_entry-default.c
index 48094f75f78..1b7e188d5f9 100644
--- a/gcc/testsuite/c-c++-common/patchable_function_entry-default.c
+++ b/gcc/testsuite/c-c++-common/patchable_function_entry-default.c
@@ -1,4 +1,5 @@
/* { dg-do compile { target { ! nvptx*-*-* } } } */
+/* { dg-skip-if "undefined padding" { "ia64*-*-*" } { "*" } { "" } } */
/* { dg-options "-O2 -fpatchable-function-entry=3,1" } */
/* { dg-final { scan-assembler-times "nop" 3 } } */
diff --git a/gcc/testsuite/c-c++-common/patchable_function_entry-definition.c b/gcc/testsuite/c-c++-common/patchable_function_entry-definition.c
index af8202f283b..33e37dbc49f 100644
--- a/gcc/testsuite/c-c++-common/patchable_function_entry-definition.c
+++ b/gcc/testsuite/c-c++-common/patchable_function_entry-definition.c
@@ -1,4 +1,5 @@
/* { dg-do compile { target { ! nvptx*-*-* } } } */
+/* { dg-skip-if "undefined padding" { "ia64*-*-*" } { "*" } { "" } } */
/* { dg-options "-O2 -fpatchable-function-entry=3,1" } */
/* { dg-final { scan-assembler-times "nop" 1 } } */
next prev parent reply other threads:[~2017-08-11 10:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-06 14:03 [PATCH v11] add -fpatchable-function-entry=N,M option Torsten Duwe
2017-07-07 13:58 ` Richard Earnshaw (lists)
2017-07-07 19:30 ` [PATCH v12] " Torsten Duwe
2017-07-17 12:10 ` Torsten Duwe
2017-07-20 10:58 ` Maxim Kuvyrkov
2017-07-20 12:06 ` Torsten Duwe
2017-07-20 13:12 ` Maxim Kuvyrkov
2017-07-25 7:16 ` Maxim Kuvyrkov
2017-07-25 8:07 ` Torsten Duwe
2017-07-25 13:03 ` Torsten Duwe
2017-07-26 14:16 ` Andreas Schwab
2017-07-26 14:26 ` Torsten Duwe
2017-07-26 14:33 ` Andreas Schwab
2017-07-31 11:47 ` Maxim Kuvyrkov
2017-08-01 10:43 ` Gerald Pfeifer
2017-08-01 10:53 ` Andreas Schwab
2017-08-01 13:03 ` Maxim Kuvyrkov
2017-08-01 13:36 ` Andreas Schwab
2017-08-11 12:42 ` Torsten Duwe [this message]
2017-08-14 16:50 ` [PATCH] skip patchable_function_entry tests on ia64 Jim Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170811103429.5vmf4hlpox5abxnu@suse.de \
--to=duwe@suse.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=maxim.kuvyrkov@linaro.org \
--cc=schwab@suse.de \
--cc=wilson@tuliptree.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).