From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87415 invoked by alias); 11 Aug 2017 10:34:34 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 87405 invoked by uid 89); 11 Aug 2017 10:34:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=torsten X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 11 Aug 2017 10:34:32 +0000 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 4D625AD8B; Fri, 11 Aug 2017 10:34:30 +0000 (UTC) Date: Fri, 11 Aug 2017 12:42:00 -0000 From: Torsten Duwe To: Jim Wilson Cc: Andreas Schwab , Maxim Kuvyrkov , GCC Patches Subject: [PATCH] skip patchable_function_entry tests on ia64 Message-ID: <20170811103429.5vmf4hlpox5abxnu@suse.de> References: <20170706140311.GA20710@suse.de> <20170707193028.GA17752@suse.de> <20170726142629.GG22969@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170421 (1.8.2) X-SW-Source: 2017-08/txt/msg00787.txt.bz2 As Andreas found out, patchable_function_entry tests generate false failures on ia64. On a closer look, this feature needs some more thought on itanium: I *could* imagine it is a good idea to generate N complete nop "bundles", which would be properly aligned and allow for easy replacement with alternate binary code. But I'd rather leave this to the platform experts, or whoever comes up with a good use case, to implement the proper cpu override hook. Meanwhile, as long as the expected results remain undefined, disable the tests. Torsten gcc/testsuite/ChangeLog 2017-08-11 Torsten Duwe * c-c++-common/patchable_function_entry-default.c: Skip test on ia64. * c-c++-common/patchable_function_entry-decl.c: Likewise. * c-c++-common/patchable_function_entry-definition.c: Likewise. diff --git a/gcc/testsuite/c-c++-common/patchable_function_entry-decl.c b/gcc/testsuite/c-c++-common/patchable_function_entry-decl.c index 5c39a354559..e35dce4f3d8 100644 --- a/gcc/testsuite/c-c++-common/patchable_function_entry-decl.c +++ b/gcc/testsuite/c-c++-common/patchable_function_entry-decl.c @@ -1,4 +1,5 @@ /* { dg-do compile { target { ! nvptx*-*-* } } } */ +/* { dg-skip-if "undefined padding" { "ia64*-*-*" } { "*" } { "" } } */ /* { dg-options "-O2 -fpatchable-function-entry=3,1" } */ /* { dg-final { scan-assembler-times "nop" 2 } } */ diff --git a/gcc/testsuite/c-c++-common/patchable_function_entry-default.c b/gcc/testsuite/c-c++-common/patchable_function_entry-default.c index 48094f75f78..1b7e188d5f9 100644 --- a/gcc/testsuite/c-c++-common/patchable_function_entry-default.c +++ b/gcc/testsuite/c-c++-common/patchable_function_entry-default.c @@ -1,4 +1,5 @@ /* { dg-do compile { target { ! nvptx*-*-* } } } */ +/* { dg-skip-if "undefined padding" { "ia64*-*-*" } { "*" } { "" } } */ /* { dg-options "-O2 -fpatchable-function-entry=3,1" } */ /* { dg-final { scan-assembler-times "nop" 3 } } */ diff --git a/gcc/testsuite/c-c++-common/patchable_function_entry-definition.c b/gcc/testsuite/c-c++-common/patchable_function_entry-definition.c index af8202f283b..33e37dbc49f 100644 --- a/gcc/testsuite/c-c++-common/patchable_function_entry-definition.c +++ b/gcc/testsuite/c-c++-common/patchable_function_entry-definition.c @@ -1,4 +1,5 @@ /* { dg-do compile { target { ! nvptx*-*-* } } } */ +/* { dg-skip-if "undefined padding" { "ia64*-*-*" } { "*" } { "" } } */ /* { dg-options "-O2 -fpatchable-function-entry=3,1" } */ /* { dg-final { scan-assembler-times "nop" 1 } } */