From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88016 invoked by alias); 11 Aug 2017 13:07:57 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 82530 invoked by uid 89); 11 Aug 2017 13:07:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:sk:VE1EUR0, H*r:10.152.18 X-HELO: EUR01-DB5-obe.outbound.protection.outlook.com Received: from mail-db5eur01on0067.outbound.protection.outlook.com (HELO EUR01-DB5-obe.outbound.protection.outlook.com) (104.47.2.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 11 Aug 2017 13:07:48 +0000 Received: from VI1PR08CA0169.eurprd08.prod.outlook.com (2603:10a6:800:d1::23) by AM3PR08MB0136.eurprd08.prod.outlook.com (2a01:111:e400:884b::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1341.17; Fri, 11 Aug 2017 13:07:45 +0000 Received: from VE1EUR03FT023.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e09::203) by VI1PR08CA0169.outlook.office365.com (2603:10a6:800:d1::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1341.17 via Frontend Transport; Fri, 11 Aug 2017 13:07:44 +0000 Authentication-Results: spf=pass (sender IP is 217.140.96.140) smtp.mailfrom=arm.com; gcc.gnu.org; dkim=none (message not signed) header.d=none;gcc.gnu.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 217.140.96.140 as permitted sender) receiver=protection.outlook.com; client-ip=217.140.96.140; helo=nebula.arm.com; Received: from nebula.arm.com (217.140.96.140) by VE1EUR03FT023.mail.protection.outlook.com (10.152.18.133) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.1304.16 via Frontend Transport; Fri, 11 Aug 2017 13:07:44 +0000 Received: from arm.com (10.1.2.79) by mail.arm.com (10.1.105.66) with Microsoft SMTP Server id 14.3.294.0; Fri, 11 Aug 2017 14:07:34 +0100 Date: Fri, 11 Aug 2017 14:14:00 -0000 From: James Greenhalgh To: Tamar Christina CC: , , , Subject: Re: [PATCH][GCC][AArch64] Fix pattern guard relaxations that are allowing more constants than they should. Message-ID: <20170811130734.GA13888@arm.com> References: <20170811110137.GA13171@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20170811110137.GA13171@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:217.140.96.140;IPV:CAL;SCL:-1;CTRY:GB;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(39860400002)(2980300002)(438002)(24454002)(199003)(377424004)(189002)(53754006)(50986999)(76176999)(55016002)(4001350100001)(1076002)(305945005)(23726003)(6636002)(33656002)(229853002)(106466001)(54906002)(36756003)(47776003)(6286002)(7696004)(97756001)(5660300001)(4326008)(356003)(54356999)(110136004)(77096006)(8936002)(6862004)(86362001)(246002)(83506001)(189998001)(626005)(2906002)(8676002)(50466002)(46406003)(6246003)(104016004)(478600001)(72206003)(26826003)(2950100002)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:AM3PR08MB0136;H:nebula.arm.com;FPR:;SPF:Pass;PTR:fw-tnat.cambridge.arm.com;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;VE1EUR03FT023;1:oKWccGgCCUB3tXLxeOqsya0Yfsr0gOnyjA82Yi0beEjMjikMc9ocyvANwA/Xvi0N7HDc95nXR744t3n0xfr8efaFr9MO4cbOlSGxgioh7VLcJDTEhUNDi/DUo05ZtAz1KQKzcTi2w/Gda2iUzNKE8fvc42xPBEgUAihc5MdXu1kcBdLmZcLFazCgMp1+VV0q27zUX+cXIhr/k4hbUDqcnmSeNgaKcuRDrj8zMYSBwyydscKoOvVChLnqwXnNVu6eI0LBS4qGTilqZwXZthEyCgI+UaaUKcNToz3yiESyWfToaWklgHaf4KdAAxH6QM5uFb+nujv1PKvz2VS1TLYaa5sjvZGSgZTJEnlCnkNBfsk7+AdI7Fy0h6exwtZKN8KynvDW0eNMRuObWko0dqiW228W5RyHJn1ZzYjaTOqW26uMEt3KNQb3o+wBRbSJM2NLwJbUVV/yIF+e3ujQZAROE8JDP9p2+kNge1ivzMUqE2C3EOCJ/PmVyws5L3pMZzz0dgPJnsNlKSkuU5zWJWb0nXkZx0HfsMC/KfI6LA0yx/yrRwqPbLVSYjZhIMkuS8PClmS4ilWkKLbpQpu32HDNcTDP7bbLNimfOs4C7RHK+ihAeHWKZBDii5x+7YvQpnTIjcuhHnQeX6dTNHCJ/wFaL5VAcAbRUlNHwTHkFMQLXMaPLEK0PHM/E1e/Poofp0hgRzgb1SiFi54ZTErcTddQQ4bgruY1+XBKhZ5Sq2Lca30oxoiMx8KtuiROAMqq2prR76pUv5v6TjYswzTNIdcOQvk7bXqFH15RBuZSHvt5r7v8gPvS0LRvdv3ARmcCXWbAsrQQnGEirjBZot8/gvdUs0Tndtvb00ABD7j3Zjqo8HUXJ3/VWRogcUqE1tbwogcD X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4a5c2cee-5499-4fb2-66bf-08d4e0b9f4df X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(8251501002)(300000503095)(300135400095)(2017052603031)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:AM3PR08MB0136; X-Microsoft-Exchange-Diagnostics: 1;AM3PR08MB0136;3:f6IC/JeQVeEQlj9OTMo+a/X9AMK40CfVJxQVJjQNFt74Mj7SJRwxX+lnrkMQZ/eOQCL6SSc64jA5JQBSAplEM2s2LmdTXE7Up5g15yorQo7SLjd9QieBUCFyeq3UcN3Qi/zeN+Xo0LehVjxxRh11UbcGdXbH8tm1ltf8cHEhgFQHM2yLFc7Wl0HMEXOD0qLc97f7Lv2UdoDjFrhg225RC2IBZL5jauHqGy28OOSMpEV8a/F7M0uP2jozOI6yPclESpFdAbe3gV+WhcbmTKVqWzROdSVc5gIcBifTsCX1D1Eg12Hq3JAeBKtvGxahOss5GVYh0GnyIKGVxM64fQ5Mrp2x2bk0peNvAs5bpg6fRxY=;25:8tAp447XI3MA6HM7V86pVfsKp6SZeKJRjjjxk9auHzwTS43opc6jfgVUDnSMbRl1ghTtZkP9ao+yKKiP67iIBpKXUGI2hmgtlJIvUWeMUD4R6+zHqr6YVlzqa5VshN1joG6VhmvhsHOV9+hflLI0lVi2blSet7vkKAu4l+UDx3e8Wo/BbShPv3ROVbjHVKECjkQaa5jIbQqRzGgv1BEtwhDJ4Osavdm1o7SOYqGPhZ60lWjRfLpkV7Jcbq8lGFCeupZ15sSNKHf3QBsY2G//2Jm//5Pq6BePjisiE+ZMS2NzD5ohWTqfpoY6LVs7Ou8f1ydskKyDbYpkvMfFqO94CQ== X-MS-TrafficTypeDiagnostic: AM3PR08MB0136: X-Microsoft-Exchange-Diagnostics: 1;AM3PR08MB0136;31:FZvL/yOd6NZX9fe6Zxr/nu6bpO1/sJs/L25zzs2f1ISyX4dh3YSQgVnemjO/GwQop1Pt/Gba0g8pCOsYchKRZmy5VgLDw3uo8BA7Ynji6kughJuVdfMsDiuB0VxWNOwf4PF4kU4vQk/vRkJTQXf0qDMaTgCJnmtSPrg9zKIxgGZTKbVtLjxzTAaXMulQxnpP/Lih4004uKNq1h6W/4oQL3lVFzLphZ1IHt9knBU9SH0=;20:uXtDJ8MEftK8dAuz4Oq1oGj4EbbovbW75Dfzh5LFFq9UW5YYzdLoO0yz2e+RDPMEKQZeeV0FAKUIry8F3FFCQ6Q7AS9GCKG9pm0jiEZ9NaOTl3nYMMGTsu+TZKTcE/PDoBwEeGawZd8inLnQeDJgO1vMgP12mmFUhmfwr3w1YuKgG6sZZmcIzGBWNyw+oZLYsY7vHFylMt/WdX92AYkJ3o0oqkXtzM7i0Mn8TSOzLZbp7rqUG6/Iq4E0e0QJmi/6;4:ErKe6XTG2KP7nE17UCpF552291GbE82Kfr/oO996MhLR32kIYgRKMA3/++7g09H94sIyg71QxwGFWT1hLZ+sruUp41f0q54GUJEJ9FxE9eEy4FnZ9CYsmPJmXxLbqV2gIhAJu7oiH4+sMfszcmvIOIox1RWd2BGRG7NkgnvzDZoeneje1n30y5ZrpdXE00m9rcS7Jkd2x7HlLDP8gNbSNsk6BKguZKaClUnOC5JqeQjeuMFwxba9yyf6HSQieEUv/HPAC3EkqfW8//oBTQ82lf0xHISFfmEPajP6aJZrMJE= NoDisclaimer: True X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(13021025)(5005006)(8121501046)(13013025)(93006095)(93004095)(100000703101)(100105400095)(10201501046)(3002001)(6055026)(6041248)(20161123562025)(20161123560025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:AM3PR08MB0136;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:AM3PR08MB0136; X-Forefront-PRVS: 03965EFC76 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;AM3PR08MB0136;23:PkwA3UrmLCewktKl9plVQmLoQwtw3aXqaI8nFA2sg?= =?us-ascii?Q?ozn34vNK/j32E1/ypFhip0Q8JOsyvYT8dk7Cy4WD0iC/Mwhd1cvgJVo640Ul?= =?us-ascii?Q?PDplbY04AwNZAaASvehcZKTzAQaDC8JD3aJ3iwrHo86AGhavxeWd5zOqmzIE?= =?us-ascii?Q?+nZ+S9v+G4ZfgG4g2SLHv7/UstPGOsYuF+Dvlg2f5Ie1JGFrGF4o/wVYGqjN?= =?us-ascii?Q?470TORbnHCcr/DWYB0GUZqLEC2AHvdtDvhsPlnvaMApNjKQd2I6/5ey4S1VK?= =?us-ascii?Q?od2T1XvFH/vNtNOVGwfv8Lcda8xA8SbdiLLyxSpOiXZDBwJTu2/udcJoZXbb?= =?us-ascii?Q?Jul2OvEQ2DKVmvwuBoArwcTyssw3G1LNWsqaN+WDUUIki7l0K/u7o/ajgXQJ?= =?us-ascii?Q?0wio8R0EZMWw1Au67QFZ9NNk0g1b0jUV14aI9t5ppyK94K8hIplislmUrS7x?= =?us-ascii?Q?DUkYL/xdCIhiXKJr5hKvT2qhUN0fjH4dLtCp2NQArFubkdEWNythfAZC7wFt?= =?us-ascii?Q?hBb06TH/8qcDw3Uv6wpjSlPvnzoSzXHoLZlFfbtrzBuoJ7MlOaNdAO+Iu/p1?= =?us-ascii?Q?1q07KFZ8uu7mJEm9czErFZj4jjUcOVZia6ZgXVu3A20WJ8FlwkeRlfG6H3kW?= =?us-ascii?Q?sHkRNfXvVIF5k5TMBTrzRjkhuQPtSGHHi8wYuo2X3M34Vuad5mtn6IU0mghi?= =?us-ascii?Q?8d10/fojktcnOxaYWnaMcs4fixB+5g2mqCG2/qny+OsoTfW0wt8FafwQDmvv?= =?us-ascii?Q?fpQNWY75R9WyCa2QWfmNS7timx/eUP7Uu5lAi/pcwWS3Loe+v3auyVT6lwBv?= =?us-ascii?Q?kY4FIteWVLT/N1B7hXX6lAQZqPGlY5/9QhK5wxFio4npIrCA8bNAYQ9VDQDp?= =?us-ascii?Q?jMIo6V1RvNNdf7/n1vSFBR3o5hFJwo2/CEKDMouS7X0lhXiwoyLHabXDzmSI?= =?us-ascii?Q?4APEDeWmHXW6NQ0j8UscuRR0p68iQ+tdvK4JjllotJ2XUXfc6CSGlZMg6EoX?= =?us-ascii?Q?xcW1yLrFj5eo3tmMXVU6RUeCt7tlRuvDtt4LRfwghKlZbYUjg0WaczX0w6P5?= =?us-ascii?Q?+JT/Ye57901yGaO6B64zQoRmsXDA/JRaNS0vcoTQyEcGFaZ9pGWDeu+DD5UY?= =?us-ascii?Q?KTkqtTLAUVghgyb+z+r4+uNdaOxZ+Msc3ppin9PNE3rATs/FnjX5iwMyXySH?= =?us-ascii?Q?a812GPdgzE+uQk=3D?= X-Microsoft-Exchange-Diagnostics: 1;AM3PR08MB0136;6:bgbeia4g7Z13o/iHtrXmGylfBPaIV+jO99t+y90jboyPLvLXWAHuXsF6NJ+J6znuTSrOFplwRGZX1y3rf71IDSzvqxAnSLeh5UD++fzWG0QSTpmecKQ4fdQAnGZo3Kp7nYLiNEG2h3kbJQ2oTI28j3tRSPEPsFmQp5vj1LYh9DjxPjPmwX/xZBotX94uuqh/MPXbMuyJApuUmFrQd7CYFF9o37KyBP7mT/5bDmYR1CwUjB9tP4uZjfa1m9GNBGX89TRUiW0v9Y9eJEo2r4od1Bwlu1T35c77caEaXcR2V6mBe2Bb7JU0T/V7eICCDoABJLEv/do8kiKEobbb+8HTlA==;5:cCG59C5VgBaTVWfaJ9xsbab4SbfmFbgb0fkdjxMnVIcZnIRBZOKktFSsLvLCts0UloN/5L625zgFmMnHxnUw8sAU87Chnt9hIcRRKH9GdIkfmOnYJrn01aY05sCluOhKHixzDrBcBFvibS4j1aUExw==;24:0ejs8jUjhiHpSvl5j4YCSTcxQggI4vUFAy0ma6mIVMb7M6OydYUA0OiLRbIBnNnm2OmY4PYA6L1jlEmjFv/oIYygDrWyfIk+3dvplPZN+VE=;7:Mo6Z2lroBLOrxT9wWfb0FNFqHSFstQJVCVcYdGdK7DrO7JRAv2ZBQ/Zn9jzOsofvRnjU44uR1W3i6Aq5Yv51xsbHpEUq1uCBAZR9juGI1jCnj3+U2brHO1cGXEXRb/t7c2Ty5UXQssmxVyST4fVEtdshUSU55LPP7//1lPuqXwz9bDZtIv+i1EJQIOpGuwHVITwrb2Hoy7/OVcQ+h81V4hYa0Y7czByBARkDdnI17N8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2017 13:07:44.5123 (UTC) X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[217.140.96.140];Helo=[nebula.arm.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR08MB0136 X-IsSubscribed: yes X-SW-Source: 2017-08/txt/msg00792.txt.bz2 On Fri, Aug 11, 2017 at 12:01:40PM +0100, Tamar Christina wrote: > Hi All, > > > Hi previous float immediate patches changed > > aarch64_reg_or_fp_zero into aarch64_reg_or_fp_float > for each of the movdf/sf/hf causing the RTL to contain > stores to memory it would never be able to find a matching > pattern for. Reload would then decide to store them to a > register instead. > > This didn't cause any incorrect code or failing tests but did change > scheduling does producing more inefficient code. > > The predicate is not reverted. > > Regression tested on aarch64-none-linux-gnu and no regressions. > > OK for trunk? OK. Thanks, James > > Thanks, > Tamar > > > gcc/ > 2017-08-11 Tamar Christina > * config/aarch64/aarch64.md (mov): Change. > (*movhf_aarch64, *movsf_aarch64, *movdf_aarch64): > aarch64_reg_or_fp_float into aarch64_reg_or_fp_zero. > * config/aarch64/predicates.md (aarch64_reg_or_fp_float): Removed. > > --