From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 101510 invoked by alias); 14 Aug 2017 17:38:30 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 99043 invoked by uid 89); 14 Aug 2017 17:38:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=furniture X-HELO: gate.crashing.org Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 14 Aug 2017 17:38:27 +0000 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.13.8) with ESMTP id v7EHcJWj025172; Mon, 14 Aug 2017 12:38:20 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id v7EHcIxd025171; Mon, 14 Aug 2017 12:38:18 -0500 Date: Mon, 14 Aug 2017 18:10:00 -0000 From: Segher Boessenkool To: Bill Schmidt Cc: Martin Sebor , GCC Patches , David Edelsohn Subject: Re: [PATCH, rs6000] More diagnostic cleanup, addressing PR79845 Message-ID: <20170814173817.GP13471@gate.crashing.org> References: <390c9e90-30d5-d06a-1129-219afe999be2@gmail.com> <744A38A4-F669-4787-A2BC-A3A932F4F4CC@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <744A38A4-F669-4787-A2BC-A3A932F4F4CC@linux.vnet.ibm.com> User-Agent: Mutt/1.4.2.3i X-IsSubscribed: yes X-SW-Source: 2017-08/txt/msg00886.txt.bz2 On Mon, Aug 14, 2017 at 09:21:51AM -0500, Bill Schmidt wrote: > > On Aug 13, 2017, at 3:41 PM, Martin Sebor wrote: > >> --- gcc/config/rs6000/rs6000-c.c (revision 250965) > >> +++ gcc/config/rs6000/rs6000-c.c (working copy) > >> @@ -5812,7 +5812,7 @@ altivec_resolve_overloaded_builtin (location_t loc > >> types. */ > >> if (nargs != 2) > >> { > >> - error ("vec_mul only accepts 2 arguments"); > >> + error ("builtin %qs only accepts 2 arguments", "vec_mul"); > > > > I don' meant to nit-pick too much but it has been drilled into me > > that the term is built-in, not builtin. There are a number of > > deviations from this preferred spelling in GCC messages already > > (mainly though not exclusively in the rs600 back-end) but I think > > it would be nice to converge on the preferred spelling. > > Martin, while I agree with you in principle, for now I have used up the time I > have available for messing with diagnostics, so I'm going to go ahead with > what we have for now. Spelling patches are of course welcome. :-) "built-in" as a noun is not a word (other than referring to furniture). GCC uses "builtin" in all command line options and function names already. Also see https://gcc.gnu.org/ml/gcc-patches/2001-06/msg00774.html (and there was a more recent discussion but I can't find it). Patches of course welcome; in this particular case, "builtin" can just be deleted, but that won't be true everywhere, it would be nice if error messages stay consistent. Segher