From: James Greenhalgh <james.greenhalgh@arm.com>
To: Tamar Christina <tamar.christina@arm.com>
Cc: <gcc-patches@gcc.gnu.org>, <nd@arm.com>,
<Richard.Earnshaw@arm.com>, <Marcus.Shawcroft@arm.com>
Subject: Re: [PATCH][GCC][Testsuite][ARM][AArch64] Enable Dot Product for generic tests for ARM and AArch64 [Patch (7/8)]
Date: Mon, 04 Sep 2017 11:10:00 -0000 [thread overview]
Message-ID: <20170904110944.GB38155@arm.com> (raw)
In-Reply-To: <20170901132338.GA32443@arm.com>
On Fri, Sep 01, 2017 at 02:23:39PM +0100, Tamar Christina wrote:
> Hi All,
>
> This patch enables tests for Dot Product vectorization
> in gcc for ARM and AArch64.
>
> The ARMv8.2-a Dot Product instructions only support 8-bit
> element vectorization.
>
> Dot product is available from ARMv8.2-a and onwards.
>
> Regtested and bootstrapped on aarch64-none-elf and
> arm-none-eabi and no issues.
I'm surprised that this worked!
It looks like you unconditionally add the -march=armv8.2-a+dotprod
options, which should cause you to generate instructions which will
not execute on targets which don't support this instruction. As far as I can
see, this is an execute test, so that should cause undefined instruction
exceptions on an Armv8-A target at the very least.
So, not OK in its current form.
Thanks,
James
>
> Ok for trunk?
>
> gcc/testsuite
> 2017-09-01 Tamar Christina <tamar.christina@arm.com>
>
> * gcc.dg/vect/vect-reduc-dot-s8a.c
> (dg-additional-options, dg-require-effective-target): Add +dotprod.
> * gcc.dg/vect/vect-reduc-dot-u8a.c
> (dg-additional-options, dg-require-effective-target): Add +dotprod.
>
> --
next prev parent reply other threads:[~2017-09-04 11:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 13:23 Tamar Christina
2017-09-04 11:10 ` James Greenhalgh [this message]
2017-09-04 11:35 ` Tamar Christina
2017-10-06 12:45 ` Tamar Christina
2017-10-12 13:32 ` Richard Earnshaw (lists)
2017-10-12 14:02 ` Tamar Christina
2017-10-23 9:38 ` Tamar Christina
2017-10-24 15:14 ` James Greenhalgh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170904110944.GB38155@arm.com \
--to=james.greenhalgh@arm.com \
--cc=Marcus.Shawcroft@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nd@arm.com \
--cc=tamar.christina@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).