public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Gerald Pfeifer <gerald@pfeifer.com>,
	gcc-patches@gcc.gnu.org,        richard.sandiford@linaro.org
Subject: Re: [00/77] Add wrapper classes for machine_modes
Date: Tue, 05 Sep 2017 09:53:00 -0000	[thread overview]
Message-ID: <20170905095317.GD2323@tucnak> (raw)
In-Reply-To: <877exf8rja.fsf@linaro.org>

On Sun, Sep 03, 2017 at 09:18:33PM +0100, Richard Sandiford wrote:
> Gerald Pfeifer <gerald@pfeifer.com> writes:
> > Hi Richard,
> >
> > I'm afraid your patchset has broken bootstrap on i686-unknown-freebsd10.3,
> > in fact, it appears on FreeBSD in general (amd64-unknown-freebsd11 as well):
> 
> This sounds like the same as PR82045.  Could you try the patch I posted
> here: https://gcc.gnu.org/ml/gcc-patches/2017-09/msg00062.html ?

Richard, could you please next time commit such a huge series of patches
that has not been tested separately as one commit (or test the patches also
individually)?  It is sometimes fine for patch review if the granularity is
smaller, but e.g. for bisection having long ranges of commits that don't
build/bootstrap at all is highly undesirable.  That seems to be at least on
x86_64-linux the case of r251470 to r251503 inclusive.

Thanks

	Jakub

  parent reply	other threads:[~2017-09-05  9:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-03 19:09 Gerald Pfeifer
2017-09-03 20:18 ` Richard Sandiford
2017-09-04  8:56   ` Gerald Pfeifer
2017-09-05  9:53   ` Jakub Jelinek [this message]
2017-09-05 10:17     ` Richard Sandiford
2017-09-05 10:58 ` Eric Gallager
  -- strict thread matches above, loose matches on Subject: below --
2017-07-13  8:35 Richard Sandiford
2017-07-22 21:02 ` Segher Boessenkool
2017-07-24  9:28   ` Richard Sandiford
2017-07-24 10:56     ` Segher Boessenkool
2017-07-24 12:53       ` Richard Sandiford
2017-07-24 13:42         ` Segher Boessenkool
2017-07-24 18:31           ` Richard Biener

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170905095317.GD2323@tucnak \
    --to=jakub@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gerald@pfeifer.com \
    --cc=richard.sandiford@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).