From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87381 invoked by alias); 14 Sep 2017 19:38:49 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 87371 invoked by uid 89); 14 Sep 2017 19:38:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1248 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Sep 2017 19:38:48 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3B563C0035D0; Thu, 14 Sep 2017 19:38:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 3B563C0035D0 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jakub@redhat.com Received: from tucnak.zalov.cz (ovpn-116-102.ams2.redhat.com [10.36.116.102]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BD5AC5C3FD; Thu, 14 Sep 2017 19:38:46 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id v8EJciIF031435; Thu, 14 Sep 2017 21:38:44 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id v8EJcfVX028305; Thu, 14 Sep 2017 21:38:41 +0200 Date: Thu, 14 Sep 2017 19:38:00 -0000 From: Jakub Jelinek To: "de Vries, Tom" Cc: GCC Patches , "Schwinge, Thomas" Subject: Re: [PATCH, PR81844] Fix condition folding in c_parser_omp_for_loop Message-ID: <20170914193841.GL1701@tucnak> Reply-To: Jakub Jelinek References: <8d91b179-6873-2988-529b-705e123010cf@mentor.com> <20170914105503.GH1701@tucnak> <1505417653837.14909@mentor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1505417653837.14909@mentor.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00935.txt.bz2 On Thu, Sep 14, 2017 at 07:34:14PM +0000, de Vries, Tom wrote: > --- a/libgomp/testsuite/libgomp.c++/c++.exp > +++ b/libgomp/testsuite/libgomp.c++/c++.exp > @@ -22,6 +22,11 @@ dg-init > # Turn on OpenMP. > lappend ALWAYS_CFLAGS "additional_flags=-fopenmp" > > +# Switch into C++ mode. Otherwise, the libgomp.c-c++-common/*.c > +# files would be compiled as C files. > +set SAVE_GCC_UNDER_TEST "$GCC_UNDER_TEST" > +set GCC_UNDER_TEST "$GCC_UNDER_TEST -x c++" > + > set blddir [lookfor_file [get_multilibs] libgomp] > > > @@ -47,7 +52,9 @@ if { $blddir != "" } { > > if { $lang_test_file_found } { > # Gather a list of all tests. > - set tests [lsort [find $srcdir/$subdir *.C]] > + set tests [lsort [concat \ > + [find $srcdir/$subdir *.C] \ > + [find $srcdir/$subdir/../libgomp.c-c++-common *.c]]] > > if { $blddir != "" } { > set ld_library_path "$always_ld_library_path:${blddir}/${lang_library_path}" I don't see SAVE_GCC_UNDER_TEST being used anywhere after it is set. Did you mean to set GCC_UNDER_TEST back to SAVE_GCC_UNDER_TEST at the end of c++.exp? libgomp.oacc-c++/c++.exp has: # See above. set GCC_UNDER_TEST "$SAVE_GCC_UNDER_TEST" Otherwise LGTM, thanks. Jakub