From: Jakub Jelinek <jakub@redhat.com>
To: Richard Biener <rguenther@suse.de>
Cc: Jason Merrill <jason@redhat.com>,
gcc-patches List <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH][2/2] early LTO debug, main part
Date: Tue, 19 Sep 2017 15:24:00 -0000 [thread overview]
Message-ID: <20170919152414.GR1701@tucnak> (raw)
In-Reply-To: <alpine.LSU.2.20.1708041418140.10808@zhemvz.fhfr.qr>
On Fri, Aug 04, 2017 at 02:21:29PM +0200, Richard Biener wrote:
> ! /* Initialize the various sections and labels for dwarf output. */
>
> static void
> ! init_sections_and_labels (void)
...
These changes broke DWARF-5 support. E.g. in gcc-7 and before this change
there was:
> ! if (!dwarf_split_debug_info)
> {
...
> ! debug_loc_section = get_section (dwarf_version >= 5
> ! ? DEBUG_LOCLISTS_SECTION
> ! : DEBUG_LOC_SECTION,
> ! SECTION_DEBUG, NULL);
the above which would use .debug_loclists section for debug_loc_section
instead of .debug_loc for -gdwarf-5, because that is what DWARF-5 requires
and the section content is ABI incompatible. But current trunk does
> ! debug_loc_section = get_section (DEBUG_LOC_SECTION,
> ! SECTION_DEBUG, NULL);
only, so the DWARF-5 content is emitted into .debug_loc section.
Or, there used to be:
> ! if (!dwarf_split_debug_info && !DWARF2_ASM_LINE_DEBUG_INFO)
> ! debug_line_str_section = get_section (DEBUG_LINE_STR_SECTION,
> ! DEBUG_STR_SECTION_FLAGS, NULL);
which has no replacement at all, debug_line_str_hash is NULL and
so !DWARF2_ASM_LINE_DEBUG_INFO compiler ICEs on pretty much all
-gdwarf-5, because it can't emit the strings into that section.
Do you have rough time when you wrote changes to these functions (so that
I could diff init_sections_and_labels changes in between that date and
before your LTO debug changes and find out what needs to be double checked
besides those two)?
I presume we'll need some name for a LTO .debug_loclists variant.
Also, seeing:
#ifndef DEBUG_LINE_SECTION
#define DEBUG_LINE_SECTION ".debug_line"
#endif
#ifndef DEBUG_DWO_LINE_SECTION
#define DEBUG_DWO_LINE_SECTION ".debug_line.dwo"
#endif
#ifndef DEBUG_LTO_LINE_SECTION
#define DEBUG_LTO_LINE_SECTION ".gnu.debuglto_.debug_line.dwo"
#endif
that looks like a pasto, , I'd expect the last one, since it doesn't have
DWO_ in the name, to be just .gnu.debuglto_.debug_line .
Jakub
next prev parent reply other threads:[~2017-09-19 15:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 10:44 Richard Biener
2017-06-07 8:21 ` Richard Biener
2017-06-20 11:16 ` Richard Biener
2017-07-04 11:10 ` Richard Biener
2017-07-28 12:55 ` Richard Biener
2017-08-02 4:30 ` Jason Merrill
2017-08-02 10:35 ` Richard Biener
2017-08-02 19:01 ` Jason Merrill
2017-08-03 10:51 ` Richard Biener
2017-08-03 17:04 ` Jason Merrill
2017-08-04 12:21 ` Richard Biener
2017-08-22 10:49 ` Szabolcs Nagy
2017-08-22 10:57 ` Richard Biener
2017-08-22 13:01 ` Szabolcs Nagy
2017-08-22 13:29 ` Richard Biener
2017-09-19 15:24 ` Jakub Jelinek [this message]
2017-09-19 21:22 ` Jakub Jelinek
2017-09-20 8:20 ` Richard Biener
2017-09-20 8:31 ` Jakub Jelinek
2017-09-20 18:08 ` Jeff Law
2017-09-21 14:29 ` Pierre-Marie de Rodat
2017-09-21 14:33 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170919152414.GR1701@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).