From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 36611 invoked by alias); 28 Sep 2017 08:46:21 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 35955 invoked by uid 89); 28 Sep 2017 08:46:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 28 Sep 2017 08:46:18 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B2802109A2D; Thu, 28 Sep 2017 08:46:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com B2802109A2D Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jakub@redhat.com Received: from tucnak.zalov.cz (ovpn-116-41.ams2.redhat.com [10.36.116.41]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2EACA8F88F; Thu, 28 Sep 2017 08:46:15 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id v8S8kCb2019975; Thu, 28 Sep 2017 10:46:12 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id v8S8kABR019974; Thu, 28 Sep 2017 10:46:10 +0200 Date: Thu, 28 Sep 2017 08:46:00 -0000 From: Jakub Jelinek To: Tom de Vries Cc: thomas@codesourcery.com, gcc-patches@gcc.gnu.org Subject: Re: [libgomp, testsuite] Remove superfluous -fopenmp from libgomp testcases Message-ID: <20170928084610.GZ1701@tucnak> Reply-To: Jakub Jelinek References: <878ux1jp2s.fsf@schwinge.name> <1383766943-8863-1-git-send-email-thomas@codesourcery.com> <1383766943-8863-2-git-send-email-thomas@codesourcery.com> <20131107081125.GO27813@tucnak.zalov.cz> <6ff0d858-063b-2ba0-638f-9b5fb6bbf71c@mentor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6ff0d858-063b-2ba0-638f-9b5fb6bbf71c@mentor.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg01853.txt.bz2 On Thu, Sep 28, 2017 at 09:41:15AM +0200, Tom de Vries wrote: > [ was: Re: [gomp4 2/9] libgomp: Prepare for testcases without -fopenmp. ] > > On 11/07/2013 09:11 AM, Jakub Jelinek wrote: > > On Wed, Nov 06, 2013 at 08:42:16PM +0100, thomas@codesourcery.com wrote: > > > From: Thomas Schwinge > > > > > > libgomp/ > > > * testsuite/lib/libgomp.exp (libgomp_init): Don't add -fopenmp to > > > ALWAYS_CFLAGS. > > > * testsuite/libgomp.c++/c++.exp (ALWAYS_CFLAGS): Add -fopenmp. > > > * testsuite/libgomp.c/c.exp (ALWAYS_CFLAGS): Likewise. > > > * testsuite/libgomp.fortran/fortran.exp (ALWAYS_CFLAGS): Likewise. > > > * testsuite/libgomp.graphite/graphite.exp (ALWAYS_CFLAGS): > > > Likewise. > > > > Ok for trunk/gomp-4_0-branch. > > Following up on this, how about we drop the now superfluous -fopenmp in > current test-cases? > > Tested on x86_64. Verified by analyzing libgomp.log that -fopenmp is still > passed to test-cases as required. > > OK for trunk? > > Thanks, > - Tom > Remove superfluous -fopenmp from libgomp testcases > > 2017-09-16 Tom de Vries > > * testsuite/libgomp.c++/for-12.C: Remove superfluous -fopenmp option > setting. > * testsuite/libgomp.c++/pr69393.C: Same. > * testsuite/libgomp.c++/taskloop-1.C: Same. > * testsuite/libgomp.c++/taskloop-3.C: Same. > * testsuite/libgomp.c++/taskloop-4.C: Same. > * testsuite/libgomp.c/for-4.c: Same. > * testsuite/libgomp.c/pr66199-3.c: Same. > * testsuite/libgomp.c/pr66199-4.c: Same. > * testsuite/libgomp.c/pr66199-6.c: Same. > * testsuite/libgomp.c/taskloop-1.c: Same. > * testsuite/libgomp.c/taskloop-3.c: Same. > * testsuite/libgomp.c/taskloop-4.c: Same. > * testsuite/libgomp.fortran/aligned1.f03: Same. > * testsuite/libgomp.fortran/condinc1.f: Same. > * testsuite/libgomp.fortran/condinc3.f90: Same. > * testsuite/libgomp.fortran/crayptr1.f90: Same. > * testsuite/libgomp.fortran/crayptr2.f90: Same. > * testsuite/libgomp.fortran/crayptr3.f90: Same. > * testsuite/libgomp.fortran/omp_cond1.f: Same. > * testsuite/libgomp.fortran/omp_cond3.F90: Same. > * testsuite/libgomp.fortran/pr66199-1.f90: Same. > * testsuite/libgomp.fortran/pr66199-2.f90: Same. > * testsuite/libgomp.fortran/recursion1.f90: Same. > * testsuite/libgomp.fortran/target2.f90: Same. > * testsuite/libgomp.fortran/target5.f90: Same. > * testsuite/libgomp.fortran/task3.f90: Same. Ok. Jakub