From: Jakub Jelinek <jakub@redhat.com>
To: Jonathan Wakely <jwakely@redhat.com>,
Jason Merrill <jason@redhat.com>,
Nathan Sidwell <nathan@acm.org>
Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] PR libstdc++/81469 deprecate std::uncaught_exception for C++17
Date: Thu, 28 Sep 2017 18:52:00 -0000 [thread overview]
Message-ID: <20170928185243.GH1701@tucnak> (raw)
In-Reply-To: <20170920163526.GA30715@redhat.com>
Hi!
On Wed, Sep 20, 2017 at 05:35:26PM +0100, Jonathan Wakely wrote:
> C++17 deprecates uncaught_exception in favour of uncaught_exceptions,
> so this adds the attribute.
>
> PR libstdc++/81469
> * libsupc++/exception (uncaught_exception): Deprecate for C++17.
> * testsuite/18_support/exception_ptr/62258.cc: Add -Wno-deprecated.
> * testsuite/18_support/uncaught_exception/14026.cc: Likewise.
>
> Tested powerpc64le-linux, committed to trunk.
This broke a couple of tests with make check-c++-all, the following patch
should fix that.
Regtested on x86_64-linux and i686-linux, including make check-c++-all, ok
for trunk?
2017-09-28 Jakub Jelinek <jakub@redhat.com>
* g++.dg/eh/uncaught1.C: Add -Wno-deprecated for c++17.
* g++.dg/eh/uncaught2.C: Likewise.
* g++.dg/eh/uncaught3.C: Likewise.
* g++.dg/eh/uncaught4.C: Likewise.
* g++.old-deja/g++.mike/eh48.C: Likewise.
--- gcc/testsuite/g++.dg/eh/uncaught1.C.jj 2014-01-28 14:03:44.000000000 +0100
+++ gcc/testsuite/g++.dg/eh/uncaught1.C 2017-09-28 14:33:08.758343406 +0200
@@ -1,6 +1,7 @@
// PR libstdc++/10606
// { dg-do run }
// { dg-options "-fuse-cxa-get-exception-ptr" { target powerpc*-*-darwin* } }
+// { dg-additional-options "-Wno-deprecated" { target c++17 } }
#include <exception>
#include <cstdlib>
--- gcc/testsuite/g++.dg/eh/uncaught2.C.jj 2008-09-05 12:55:05.000000000 +0200
+++ gcc/testsuite/g++.dg/eh/uncaught2.C 2017-09-28 14:33:16.761250186 +0200
@@ -1,6 +1,7 @@
// { dg-do compile }
// { dg-final { scan-assembler-not "__cxa_get_exception" } }
// { dg-options "-fno-use-cxa-get-exception-ptr" }
+// { dg-additional-options "-Wno-deprecated" { target c++17 } }
#include <exception>
#include <cstdlib>
--- gcc/testsuite/g++.dg/eh/uncaught3.C.jj 2008-09-05 12:55:05.000000000 +0200
+++ gcc/testsuite/g++.dg/eh/uncaught3.C 2017-09-28 14:33:23.180175417 +0200
@@ -1,6 +1,7 @@
// { dg-do compile { target powerpc*-*-darwin* } }
// { dg-final { scan-assembler-not "__cxa_get_exception" } }
// { dg-options "-mmacosx-version-min=10.4" }
+// { dg-additional-options "-Wno-deprecated" { target c++17 } }
#include <exception>
#include <cstdlib>
--- gcc/testsuite/g++.dg/eh/uncaught4.C.jj 2014-01-28 14:03:44.000000000 +0100
+++ gcc/testsuite/g++.dg/eh/uncaught4.C 2017-09-28 14:33:29.811098178 +0200
@@ -1,5 +1,6 @@
// PR c++/41174
// { dg-do run }
+// { dg-additional-options "-Wno-deprecated" { target c++17 } }
#include <exception>
--- gcc/testsuite/g++.old-deja/g++.mike/eh48.C.jj 2008-09-05 12:54:56.000000000 +0200
+++ gcc/testsuite/g++.old-deja/g++.mike/eh48.C 2017-09-28 14:34:09.792632463 +0200
@@ -1,5 +1,6 @@
// { dg-do run { xfail sparc64-*-elf arm-*-pe } }
// { dg-options "-fexceptions" }
+// { dg-additional-options "-Wno-deprecated" { target c++17 } }
#include <exception>
#include <stdlib.h>
Jakub
next prev parent reply other threads:[~2017-09-28 18:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-20 16:35 Jonathan Wakely
2017-09-28 18:52 ` Jakub Jelinek [this message]
2017-09-28 23:39 ` Nathan Sidwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170928185243.GH1701@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
--cc=nathan@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).