From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 70145 invoked by alias); 9 Oct 2017 23:10:15 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 69645 invoked by uid 89); 9 Oct 2017 23:10:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=Better, firm X-HELO: gate.crashing.org Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Oct 2017 23:10:14 +0000 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.13.8) with ESMTP id v99MMMso004474; Mon, 9 Oct 2017 17:22:24 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id v99MMIPX004468; Mon, 9 Oct 2017 17:22:18 -0500 Date: Tue, 10 Oct 2017 00:24:00 -0000 From: Segher Boessenkool To: Will Schmidt Cc: GCC Patches , Bill Schmidt , David Edelsohn Subject: Re: [PATCH, rs6000] fix-up int128 fold vector multiply tests Message-ID: <20171009222216.GK4406@gate.crashing.org> References: <1507584474.26707.146.camel@brimstone.rchland.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1507584474.26707.146.camel@brimstone.rchland.ibm.com> User-Agent: Mutt/1.4.2.3i X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00563.txt.bz2 Hi Will, On Mon, Oct 09, 2017 at 04:27:54PM -0500, Will Schmidt wrote: > Fix up a few issues with the tests. > - add -O2 to int128-p8 test, and firm up the -mcpu options > - update the set of expected instructions for the int128-p9 test. > - replace the float128_hw requirement with power8_vector_ok > for the int128-p9 test. > -/* { dg-final { scan-assembler-times "\[ \t\]mulld " 6 } } */ > +/* { dg-final { scan-assembler-times "\[ \t\]mulld" 6 } } */ Why this? (Better/easier would be to use \m and \M btw.) > diff --git a/gcc/testsuite/gcc.target/powerpc/fold-vec-mult-int128-p9.c b/gcc/testsuite/gcc.target/powerpc/fold-vec-mult-int128-p9.c > index e81ea5f..a226ae0 100644 > --- a/gcc/testsuite/gcc.target/powerpc/fold-vec-mult-int128-p9.c > +++ b/gcc/testsuite/gcc.target/powerpc/fold-vec-mult-int128-p9.c > @@ -1,10 +1,10 @@ > /* Verify that overloaded built-ins for vec_mul with __int128 > inputs produce the right results. */ > > /* { dg-do compile } */ > -/* { dg-require-effective-target powerpc_float128_hw_ok } */ > +/* { dg-require-effective-target powerpc_p8vector_ok } */ > /* { dg-require-effective-target int128 } */ > /* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power9" } } */ > /* { dg-options "-mcpu=power9 -O2" } */ > /* { dg-additional-options "-maix64" { target powerpc-ibm-aix* } } */ This looks curious, too. With the change it will no longer work if you built GCC with a version of binutils that doesn't support p9, I think? Not that people should do that. Segher