From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31554 invoked by alias); 25 Oct 2017 20:27:49 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 30595 invoked by uid 89); 25 Oct 2017 20:27:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy= X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 25 Oct 2017 20:27:47 +0000 Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id v9PKOojV029908 for ; Wed, 25 Oct 2017 16:27:42 -0400 Received: from e16.ny.us.ibm.com (e16.ny.us.ibm.com [129.33.205.206]) by mx0a-001b2d01.pphosted.com with ESMTP id 2du0k1tu9x-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 25 Oct 2017 16:27:42 -0400 Received: from localhost by e16.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 25 Oct 2017 16:27:41 -0400 Received: from b01cxnp23033.gho.pok.ibm.com (9.57.198.28) by e16.ny.us.ibm.com (146.89.104.203) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 25 Oct 2017 16:27:39 -0400 Received: from b01ledav006.gho.pok.ibm.com (b01ledav006.gho.pok.ibm.com [9.57.199.111]) by b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v9PKRcBD58261518; Wed, 25 Oct 2017 20:27:38 GMT Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 78EAEAC03A; Wed, 25 Oct 2017 16:28:23 -0400 (EDT) Received: from ibm-tiger.the-meissners.org (unknown [9.32.77.111]) by b01ledav006.gho.pok.ibm.com (Postfix) with ESMTP id 5E34FAC041; Wed, 25 Oct 2017 16:28:23 -0400 (EDT) Received: by ibm-tiger.the-meissners.org (Postfix, from userid 500) id A2F61484BC; Wed, 25 Oct 2017 16:27:37 -0400 (EDT) Date: Wed, 25 Oct 2017 20:31:00 -0000 From: Michael Meissner To: Joseph Myers Cc: Michael Meissner , GCC Patches , Segher Boessenkool , David Edelsohn , Bill Schmidt Subject: Re: [PATCH, version 4], Add support for _Float and _FloatX sqrt, fma, fmin, fmax built-in functions Mail-Followup-To: Michael Meissner , Joseph Myers , GCC Patches , Segher Boessenkool , David Edelsohn , Bill Schmidt References: <20170913214600.GA24598@ibm-tiger.the-meissners.org> <20171019220831.GA27658@ibm-tiger.the-meissners.org> <20171024221900.GA24351@ibm-tiger.the-meissners.org> <20171025191243.GA1434@ibm-tiger.the-meissners.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-12-10) X-TM-AS-GCONF: 00 x-cbid: 17102520-0024-0000-0000-000002E8154D X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007949; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000239; SDB=6.00936401; UDB=6.00471865; IPR=6.00716666; BA=6.00005660; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017713; XFM=3.00000015; UTC=2017-10-25 20:27:40 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17102520-0025-0000-0000-000045D70B68 Message-Id: <20171025202736.GA18058@ibm-tiger.the-meissners.org> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-10-25_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1710250269 X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg01846.txt.bz2 On Wed, Oct 25, 2017 at 08:10:45PM +0000, Joseph Myers wrote: > On Wed, 25 Oct 2017, Michael Meissner wrote: > > > +static const char *const fltfn_suffixes[] = { "F16", "F32", "F128", "F32X", > > + "F64X", "F128X", NULL }; > > I'd expect this to include F64. If there's some reason that's > inappropriate and the omission is deliberate, it needs a detailed comment > explaining the omission. Thanks for catching this. I missed F64. > I don't think that, given the availability of fmaf128 etc. built-in > functions with appropriate options, whether __FP_FAST_* are defined should > actually depend on whether the user has passed options to disable those > functions (after all, it doesn't for the existing fma / fmaf / fmal, and > individual built-in functions can be disabled with -fno-builtin- > so the logic you have wouldn't work to detect whether the built-in > function is disabled anyway). Ok, I will add a check to see if the functions are disabled. -- Michael Meissner, IBM IBM, M/S 2506R, 550 King Street, Littleton, MA 01460-6245, USA email: meissner@linux.vnet.ibm.com, phone: +1 (978) 899-4797