[PATCH] fix fdump-lang-raw ICE

[PATCH] fix fdump-lang-raw ICE

[Nathan Sidwell]

[-- Attachment #1: Type: text/plain, Size: 187 bytes --]

Thomas Koenig noticed -fdump-lang-raw gives an immediate ICE.  I broke 
it with the DECL_ASSEMBLER_NAME changes last month.  Fixed thusly, 
applied as obvious.

nathan
-- 
Nathan Sidwell

[-- Attachment #2: hdanp.dif --]
[-- Type: text/plain, Size: 679 bytes --]

2017-11-01  Nathan Sidwell  <nathan@acm.org>

	* tree-dump.c (dequeue_and_dump): Use HAS_DECL_ASSEMBLER_NAME_P.

Index: tree-dump.c
===================================================================
--- tree-dump.c	(revision 254314)
+++ tree-dump.c	(working copy)
@@ -337,7 +337,8 @@ dequeue_and_dump (dump_info_p di)
       /* All declarations have names.  */
       if (DECL_NAME (t))
 	dump_child ("name", DECL_NAME (t));
-      if (DECL_ASSEMBLER_NAME_SET_P (t)
+      if (HAS_DECL_ASSEMBLER_NAME_P (t)
+	  && DECL_ASSEMBLER_NAME_SET_P (t)
 	  && DECL_ASSEMBLER_NAME (t) != DECL_NAME (t))
 	dump_child ("mngl", DECL_ASSEMBLER_NAME (t));
       if (DECL_ABSTRACT_ORIGIN (t))

Re: [PATCH] fix fdump-lang-raw ICE

[Jakub Jelinek]

On Wed, Nov 01, 2017 at 03:24:56PM -0400, Nathan Sidwell wrote:
> Thomas Koenig noticed -fdump-lang-raw gives an immediate ICE.  I broke it
> with the DECL_ASSEMBLER_NAME changes last month.  Fixed thusly, applied as
> obvious.

Shouldn't there be a testcase with that option?

> 2017-11-01  Nathan Sidwell  <nathan@acm.org>
> 
> 	* tree-dump.c (dequeue_and_dump): Use HAS_DECL_ASSEMBLER_NAME_P.
> 
> Index: tree-dump.c
> ===================================================================
> --- tree-dump.c	(revision 254314)
> +++ tree-dump.c	(working copy)
> @@ -337,7 +337,8 @@ dequeue_and_dump (dump_info_p di)
>        /* All declarations have names.  */
>        if (DECL_NAME (t))
>  	dump_child ("name", DECL_NAME (t));
> -      if (DECL_ASSEMBLER_NAME_SET_P (t)
> +      if (HAS_DECL_ASSEMBLER_NAME_P (t)
> +	  && DECL_ASSEMBLER_NAME_SET_P (t)
>  	  && DECL_ASSEMBLER_NAME (t) != DECL_NAME (t))
>  	dump_child ("mngl", DECL_ASSEMBLER_NAME (t));
>        if (DECL_ABSTRACT_ORIGIN (t))


	Jakub

Re: [PATCH] fix fdump-lang-raw ICE

[Nathan Sidwell]

[-- Attachment #1: Type: text/plain, Size: 381 bytes --]

On 11/01/2017 03:40 PM, Jakub Jelinek wrote:
> On Wed, Nov 01, 2017 at 03:24:56PM -0400, Nathan Sidwell wrote:
>> Thomas Koenig noticed -fdump-lang-raw gives an immediate ICE.  I broke it
>> with the DECL_ASSEMBLER_NAME changes last month.  Fixed thusly, applied as
>> obvious.
> 
> Shouldn't there be a testcase with that option?

Oh, very well then :)

nathan
-- 
Nathan Sidwell

[-- Attachment #2: ldt.diff --]
[-- Type: text/x-patch, Size: 574 bytes --]

2017-11-02  Nathan Sidwell  <nathan@acm.org>

	* g++.dg/lang-dump.C: New.

Index: g++.dg/lang-dump.C
===================================================================
--- g++.dg/lang-dump.C	(revision 0)
+++ g++.dg/lang-dump.C	(working copy)
@@ -0,0 +1,21 @@
+// { dg-additional-options "-fdump-lang-all" }
+// Just check we don't explode when asking for language dumps.  Does
+// not necessarily mean any particular language dump is useful.
+
+struct X 
+{
+  int m;
+  virtual ~X ();
+};
+
+X::~X () {}
+
+struct Y : X
+{
+};
+
+int frob (int a)
+{
+  return 2 * a;
+}
+