From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48202 invoked by alias); 1 Nov 2017 19:40:51 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 47091 invoked by uid 89); 1 Nov 2017 19:40:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=month X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 01 Nov 2017 19:40:49 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E46ADB652; Wed, 1 Nov 2017 19:40:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E46ADB652 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jakub@redhat.com Received: from tucnak.zalov.cz (ovpn-116-247.ams2.redhat.com [10.36.116.247]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7B129600D2; Wed, 1 Nov 2017 19:40:47 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id vA1JeiUB031572; Wed, 1 Nov 2017 20:40:44 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id vA1JefM1031098; Wed, 1 Nov 2017 20:40:41 +0100 Date: Wed, 01 Nov 2017 19:40:00 -0000 From: Jakub Jelinek To: Nathan Sidwell Cc: GCC Patches Subject: Re: [PATCH] fix fdump-lang-raw ICE Message-ID: <20171101194041.GD14653@tucnak> Reply-To: Jakub Jelinek References: <30d63a07-d5d8-de50-eaf8-d5b6aff03a52@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <30d63a07-d5d8-de50-eaf8-d5b6aff03a52@acm.org> User-Agent: Mutt/1.7.1 (2016-10-04) X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00038.txt.bz2 On Wed, Nov 01, 2017 at 03:24:56PM -0400, Nathan Sidwell wrote: > Thomas Koenig noticed -fdump-lang-raw gives an immediate ICE. I broke it > with the DECL_ASSEMBLER_NAME changes last month. Fixed thusly, applied as > obvious. Shouldn't there be a testcase with that option? > 2017-11-01 Nathan Sidwell > > * tree-dump.c (dequeue_and_dump): Use HAS_DECL_ASSEMBLER_NAME_P. > > Index: tree-dump.c > =================================================================== > --- tree-dump.c (revision 254314) > +++ tree-dump.c (working copy) > @@ -337,7 +337,8 @@ dequeue_and_dump (dump_info_p di) > /* All declarations have names. */ > if (DECL_NAME (t)) > dump_child ("name", DECL_NAME (t)); > - if (DECL_ASSEMBLER_NAME_SET_P (t) > + if (HAS_DECL_ASSEMBLER_NAME_P (t) > + && DECL_ASSEMBLER_NAME_SET_P (t) > && DECL_ASSEMBLER_NAME (t) != DECL_NAME (t)) > dump_child ("mngl", DECL_ASSEMBLER_NAME (t)); > if (DECL_ABSTRACT_ORIGIN (t)) Jakub