From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6529 invoked by alias); 2 Nov 2017 09:59:59 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 6235 invoked by uid 89); 2 Nov 2017 09:59:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: EUR01-DB5-obe.outbound.protection.outlook.com Received: from mail-db5eur01on0068.outbound.protection.outlook.com (HELO EUR01-DB5-obe.outbound.protection.outlook.com) (104.47.2.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 02 Nov 2017 09:59:56 +0000 Received: from VI1PR08CA0109.eurprd08.prod.outlook.com (2603:10a6:800:d4::11) by DB5PR0801MB1527.eurprd08.prod.outlook.com (2603:10a6:0:3a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.197.13; Thu, 2 Nov 2017 09:59:50 +0000 Received: from AM5EUR03FT054.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e08::202) by VI1PR08CA0109.outlook.office365.com (2603:10a6:800:d4::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.178.6 via Frontend Transport; Thu, 2 Nov 2017 09:59:49 +0000 Authentication-Results: spf=pass (sender IP is 217.140.96.140) smtp.mailfrom=arm.com; linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 217.140.96.140 as permitted sender) receiver=protection.outlook.com; client-ip=217.140.96.140; helo=nebula.arm.com; Received: from nebula.arm.com (217.140.96.140) by AM5EUR03FT054.mail.protection.outlook.com (10.152.16.212) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.20.178.5 via Frontend Transport; Thu, 2 Nov 2017 09:59:49 +0000 Received: from arm.com (10.1.2.79) by mail.arm.com (10.1.105.66) with Microsoft SMTP Server id 14.3.294.0; Thu, 2 Nov 2017 09:59:29 +0000 Date: Thu, 02 Nov 2017 09:59:00 -0000 From: James Greenhalgh To: , , , CC: Subject: Re: [08/nn] [AArch64] Pass number of units to aarch64_simd_vect_par_cnst_half Message-ID: <20171102095929.GC31254@arm.com> References: <873764d8y3.fsf@linaro.org> <871slobtye.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <871slobtye.fsf@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:217.140.96.140;IPV:CAL;SCL:-1;CTRY:GB;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(376002)(346002)(39860400002)(2980300002)(438002)(24454002)(189002)(377424004)(199003)(8676002)(47776003)(55016002)(1076002)(33656002)(189998001)(6246003)(50466002)(2201001)(104016004)(23726003)(2906002)(106002)(77096006)(6286002)(97756001)(106466001)(356003)(86362001)(2950100002)(83506002)(229853002)(8936002)(15760500003)(4326008)(110136005)(5660300001)(58126008)(16586007)(246002)(46406003)(54356999)(76176999)(316002)(50986999)(305945005)(36756003)(26826003)(478600001)(72206003)(4001150100001)(7696004)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB5PR0801MB1527;H:nebula.arm.com;FPR:;SPF:Pass;PTR:fw-tnat.cambridge.arm.com;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;AM5EUR03FT054;1:6ZNJ8tqsgHWDvqi746apd2+cKFsCqj/SKC5r5qfLa+m44O7l1xTc8/2F4UaBp8glkbD/2YU7muC+5j+rrtjadvNmupvmSK889E2JftGiPZEDOR12n7YhvyJBfjS5mKV1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d3a4b6e7-6d13-4a60-a0be-08d521d874a6 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(8251501002)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603199);SRVR:DB5PR0801MB1527; X-Microsoft-Exchange-Diagnostics: 1;DB5PR0801MB1527;3:GHSW+/lfrz79FdIVh63w6hmxuc784Us8r8sTi6WC4UBqAB61pZCWBQeiVBKzgyFLpxQmr//zro1IgOobt0zbC8r982QnIFhHrQIpswSTAKftAFdQ/azsXQi2dVRCzOPsfFn6vKCw0JZsODKq2nbgU4cqIViydBbngllwhIoW2eLdCmwKQX/VNFYVWEwcRdT/MZQGjb8J3qj5dGbJ/+P6ZWLUpFfwD/71u7bWVgezgGl2seoPkxvDNVhvF9BQHNmupSgWr2Tnv0xQ5ZHV33VUi973cELf4+zeA7LMUCSOth6BSCxHR9OsFI8SMlGoYlOo/BPhiSWgZLmY+eYbh7JEhXl08b9zHPfUS57jzdhDI5s=;25:9u3T7M3FPHEvMV3N/JNG413VLd8zaoVUBSqWEUtuRuffGqGlJFQb2jI/vsOxf89O3va+TT5L3Qn7QPLDu3aHJ4R2McQIPphfXFxyqYUJWNWjY6OXkIUW7dDc/L3aJlJKXDXuOgJzsxoapYDvTOmRXd6uuiPRndFDWtbHgcHmg1OQck+xZWoMCdEpdL8S3ZR0NN2RPE3vbsP7wEnwhz+ppbZFBKa1IkFYa1Xzpq5bks8pkW+GhFVb5lTNXTwd1PyPv5v02CqKS1RJFZkH7ftePGj440UFNf25Y75bDcTsjV1Tru8jP22De4a0qwHAZUwAhql+b9VG7XJOzTmWdOGqsg== X-MS-TrafficTypeDiagnostic: DB5PR0801MB1527: X-Microsoft-Exchange-Diagnostics: 1;DB5PR0801MB1527;31:woEfhbNS5RxXUxFSczRSM4nFRj2shSxceIUlmCGJjQbGJ3zyoaV2JXZuKmUKS/d4K+H38NQVTFGYfLULq9OBGvCtrqa6xCrDfc3TWfJv5zopWPi6ZrPZrU0DdVqXp7IXumi3wMuByKEunK5QGfWRd4m6uFpY4GDs2A3LPnsqa9r3VUXFslIbcQsbiJfIpJ0PRn/QGgPkx1aaUQ6JM2Yr7bQIwwp6BQJn2AUanKYFV/U=;20:8fGsDwzXd4RQFCQvYHB/OVDN+P3TgZ+8SFyIeD6kQfVDJvgBZQWDZZgBkI6TNaM2G12gzzLGy/GQhXjHixRm4By1DcsVGA+UkSc+7ZmY33QAXfO6AzXpXBgGAejaPTrYonpdEnad5GdKByuxJ359MHbtBoujyOfIWRXtmOx3kL1uH4ICeKQ7SFxYyYbt0rM6BCeztIewX5d2vYkt7/ZBjrgCoWfGmuT7wXx6Uqv6MvLDzTKpsZPLCBviP3irGRhB;4:/FYzb9BzfkT4KAbfa79ngMduUOpapPqUVBm8vhdeYfk+9yahZynML4Lt0/UHtqJFzZMF68MeZBvLp4HVdMi0LckAbsVLrwFKDoJxLUSye0SNkCWX9vBbovqDjQIGJuBDK5dQsTMxKHDn9vOt147uKxaVTc5fgtF1wCSGG3NH0zQoKXqEKH3lQgzMufFAfbeuwyiXpgDRqp6pPmWyC2tu5k+grCA5RyeBpVs+KtE83O/fVt/+JnuJMxy7lGjGwkwXCRtMgtn2+rttcUxQAOtfAvdLthZhB1R4b2utOJukNUvARnNSMhdBvoc8oYuUgN+a NoDisclaimer: True X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(93004095)(10201501046)(3231020)(100000703101)(100105400095)(3002001)(6055026)(6041248)(20161123560025)(20161123562025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DB5PR0801MB1527;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DB5PR0801MB1527; X-Forefront-PRVS: 047999FF16 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DB5PR0801MB1527;23:S6WWUZQtBtgQ8cna4JTh2BSkLwMeuwbxIQBxV2u?= =?us-ascii?Q?2sOIahmAragZRtpxQIyrnE7kxOu3B5wDaHDhiakDrDIV5QZEPPvv7RSSFnWQ?= =?us-ascii?Q?VIvGr7h8jWW8HzqHcGWgRWak2uDcIZ7Q+uzdc1iufjuEwlWc2llgPa2zzCPC?= =?us-ascii?Q?EFnvlva5juDWXYOtHE4+lAG8KugIuf9Kems5AYC+kPuaypZfB3t/4qE2iKTl?= =?us-ascii?Q?LH/nj4Ft0OwoRQM3+ji+MpX5nm0oM59jTe9FgTUHRj/WaMAFGb2zGh/7+GF1?= =?us-ascii?Q?OhaJaQjW8IXBPbCaEKjImRIyhNoqkNFqSSzaCM8Z+MZbAoICRs6ZQ1JXEDt6?= =?us-ascii?Q?/EpofGbfd+j4Zw92ulz2doCoya1mqqHP20FAZr67X/sd9AWJah3YsEREW4a2?= =?us-ascii?Q?zT8lx5uT02E5FT4Jt4d2MDoK0awtfovCM9y1bpr9THkhNs0jieU2nUu3VXA9?= =?us-ascii?Q?C+2jz9kHDTW+2TMxzSt3k3uItMyQ+AcbUO9sQirAw7xIpQDDGZkoqbhpg8Kg?= =?us-ascii?Q?Eh6sOvIco64/CzRLKsUharYOgSqMsW7XQW+SSVj97XiHifvUxRYH/2eqdsu8?= =?us-ascii?Q?kSaYICfnj8m2GV2qo4viWi7E+onO9kHok1/S+OG2Ab4kIQGrqg/yOJ7p6Vn5?= =?us-ascii?Q?kdpNf8N45Jgwh1z8+EFiGl3XYEeNzqMv7zmjLKu1yDfxhJy4PpVehsYE5cl8?= =?us-ascii?Q?lpA9q16sDk+5U4cAd1zTyCI+kSvCJnPceaOdTP0TtejezYUedBRyA5vloEq+?= =?us-ascii?Q?S1BsqKQX/BKjkXWOgcpmDnEgxrWhx6i1hUoQ0l4yKz2XeYlWHgXJqz3VQkFL?= =?us-ascii?Q?6SW+02Soytnv4vUeUdgUmwrAiQlu16XOKGx43YNlMZIJWyH7pVEHzXrH5Zen?= =?us-ascii?Q?tK4OhHsEPGzx7sC+DT1qCKbrcXHM7qUpxyHp0tT5840OZdPIG6zeND0y8LD0?= =?us-ascii?Q?tD16bKSSgtpVgAY6p4+JiSdSENZ7lKHIDT/1SPAOwwvPY39coP5YLzbn/8Rx?= =?us-ascii?Q?/Q0PgGMUA2jjYHJLiaua503fYdMRgoTelkkJwps9Z+xhlM2Vx/bazcUWZl++?= =?us-ascii?Q?MZen9ZUr9FrpWNbiEzbKwcEx6dxS+mysua6fsjJJ5GLsSBxDhfXRGhcKfhjh?= =?us-ascii?Q?KPudNCT5ZmtKfOMARC5/lHqtawiGm92oBLZyHbg+6ImsKe+dN2C+HlgIbKpi?= =?us-ascii?Q?PzxMAC2pEvFxOzHrWcABM+tT9LEhx408B6Tu684vwjdGP3JLOXyjaVa8gcEj?= =?us-ascii?Q?mHLYXWaVTNrWTWRVOwGs=3D?= X-Microsoft-Exchange-Diagnostics: 1;DB5PR0801MB1527;6:yjfPdLwQeXZQxHiDynE6IBAtQHgwuwC7FWd/vrbwpujv+DO+/Gog3AZgTkUdqy9v/Ppm2SAPlHWVsYcHDkC36gZ+Ay/DBkyuQ6gFf3GclIq6B65r2VeAhY9j0MXPrYIbWf9DF4R+pOYzhSQFbXo48Oi3ZYTD3xMgibKl7d6D6cIHQNPl/4Weukm3tDUWliGi848vVYY2wjFULvAXfV9LNn81Y24sbtdK6p8wivME9wOhr59Ge8cAeX/+ZaNEo+0DuwlMb5r5nNr2QXtm9guADdt4veiiNOCpy56XJOJFZJQMPKC641EftUB3c1AG88CweFT3cz32MpTTeoXlg+6xlotsC0fbSZynvX/nLdfcdkY=;5:suZvnhodtJXw+BZppsilYMNXTplGAWiMSFGlXjRNf6UFsa34GW7hO5BjIXHHr6G0ou4PSrkthmnNv5akNw7jHX91RMmm0uVNHuxWLUYTbvR9sxHUuN2yRHLU5NlJ4LZnzngnLkOBlFFDo/ixs2M00lIo3iryOH0LngvcAaPe1/0=;24:PCr+h2R2Q3O5i1AVNL2jj9UIEHdHQ3a9K+E9hvTjoD/Er+O3WduieuugFmwpUoRcmG1UgQ5HxiSZ6Og0BoBM9R4mwbaADbZviT1VtprHI8c=;7:bIL67ukkvEC/zgnPhhU4o7t5tYdylAjg2Y3geModOkfr5fhxo/D0VViwheXjeCq73PFte5CU+pidBENXM9HHjADhMnCMS6uF0jpxVhD9EneoyrouUymjZwB/p7mJk4x4IZ1Igs/JwJ2YWl/YqAIXM8eLZIyQg0+ramZJBsbkbMog1N0JniXgLkUMcDA5h+v+o1Wagv0xurH9rvM/zMT+2bKd8rDG1Br6unU2nC2XNhSboReA3WKKyLlVM7GGkTX9 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2017 09:59:49.4022 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d3a4b6e7-6d13-4a60-a0be-08d521d874a6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[217.140.96.140];Helo=[nebula.arm.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR0801MB1527 X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00060.txt.bz2 On Fri, Oct 27, 2017 at 02:28:57PM +0100, Richard Sandiford wrote: > This patch passes the number of units to aarch64_simd_vect_par_cnst_half, > which avoids a to_constant () once GET_MODE_NUNITS is variable. OK. Reviewed-by: James GReenhalgh Thanks, James > 2017-10-27 Richard Sandiford > Alan Hayward > David Sherwood > > gcc/ > * config/aarch64/aarch64-protos.h (aarch64_simd_vect_par_cnst_half): > Take the number of units too. > * config/aarch64/aarch64.c (aarch64_simd_vect_par_cnst_half): Likewise. > (aarch64_simd_check_vect_par_cnst_half): Update call accordingly, > but check for a vector mode before rather than after the call. > * config/aarch64/aarch64-simd.md (aarch64_split_simd_mov) > (move_hi_quad_, vec_unpack_hi_) > (vec_unpack_lo_mult_lo_) > (vec_widen_mult_hi_, vec_unpacks_lo_) > (vec_unpacks_hi_, aarch64_saddl2, aarch64_uaddl2) > (aarch64_ssubl2, aarch64_usubl2, widen_ssum3) > (widen_usum3, aarch64_saddw2, aarch64_uaddw2) > (aarch64_ssubw2, aarch64_usubw2, aarch64_sqdmlal2) > (aarch64_sqdmlsl2, aarch64_sqdmlal2_lane) > (aarch64_sqdmlal2_laneq, aarch64_sqdmlsl2_lane) > (aarch64_sqdmlsl2_laneq, aarch64_sqdmlal2_n) > (aarch64_sqdmlsl2_n, aarch64_sqdmull2) > (aarch64_sqdmull2_lane, aarch64_sqdmull2_laneq) > (aarch64_sqdmull2_n): Update accordingly. >