From: Jakub Jelinek <jakub@redhat.com>
To: Eric Botcazou <ebotcazou@adacore.com>
Cc: "Martin Liška" <mliska@suse.cz>,
gcc-patches@gcc.gnu.org, "Jason Merrill" <jason@redhat.com>,
"Marek Polacek" <polacek@redhat.com>,
"Jonathan Wakely" <jwakely@redhat.com>
Subject: Re: [PATCH][RFC] Instrument function exit with __builtin_unreachable in C++.
Date: Mon, 06 Nov 2017 17:41:00 -0000 [thread overview]
Message-ID: <20171106173358.GU14653@tucnak> (raw)
In-Reply-To: <3785116.x86eWSSaOg@polaris>
On Mon, Nov 06, 2017 at 06:23:11PM +0100, Eric Botcazou wrote:
> > Thank you for review, done that.
>
> This has enabled -Wreturn-type for Ada, what we don't want since the warning
> is outsmarted by the language, so I have applied this.
>
>
> 2017-11-06 Eric Botcazou <ebotcazou@adacore.com>
>
> * gcc-interface/misc.c (gnat_post_options): Clear warn_return_type.
Hasn't it enabled it also for any other FEs other than C family and Fortran?
Say jit, brig, go, lto?, ...
I think better would be to remove the initialization to -1 and revert the
fortran/options.c change, and instead use in the C family:
if (!global_options_set.x_warn_return_type)
warn_return_type = c_dialect_cxx ();
Unless it for some reason doesn't work for -Wall or -W or similar.
Jakub
next prev parent reply other threads:[~2017-11-06 17:34 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 10:32 Martin Liška
2017-10-05 11:04 ` Jakub Jelinek
2017-10-05 15:08 ` Jason Merrill
2017-10-05 16:53 ` Martin Liška
2017-10-11 14:04 ` Martin Liška
2017-10-11 15:31 ` Jason Merrill
2017-10-12 8:48 ` Martin Liška
2017-10-12 9:36 ` Jakub Jelinek
2017-10-18 12:47 ` Martin Liška
2017-10-18 13:04 ` Marek Polacek
2017-10-18 13:15 ` Martin Liška
2017-10-24 14:30 ` Jason Merrill
2017-11-03 13:42 ` Martin Liška
2017-11-06 17:27 ` Eric Botcazou
2017-11-06 17:41 ` Jakub Jelinek [this message]
2017-11-06 23:07 ` Eric Botcazou
2017-11-07 10:18 ` Martin Liška
2017-11-15 7:57 ` Martin Liška
2017-11-15 8:23 ` Jakub Jelinek
2017-11-15 9:58 ` Eric Botcazou
2017-11-15 10:02 ` Martin Liška
2017-11-15 10:10 ` Eric Botcazou
2017-11-15 10:45 ` Jakub Jelinek
2017-11-15 12:46 ` Martin Liška
2017-11-06 18:41 ` Martin Sebor
2017-11-15 12:49 ` [PATCH][RFC] Add quotes for constexpr keyword Martin Liška
2017-11-15 16:38 ` Martin Sebor
2017-11-15 16:59 ` Jonathan Wakely
2017-11-15 17:06 ` Martin Sebor
2017-11-15 17:14 ` Jonathan Wakely
2017-11-21 15:27 ` Martin Liška
2017-11-21 15:48 ` Martin Sebor
2017-11-21 17:23 ` Jeff Law
2017-11-21 19:07 ` Martin Liška
2017-11-07 17:28 ` [PATCH][RFC] Instrument function exit with __builtin_unreachable in C++ Andreas Schwab
2017-11-07 19:06 ` Martin Liška
2017-11-19 17:06 ` Thomas Schwinge
2017-10-18 12:48 ` [PATCH] Fix all tests that fail with -sanitize=return Martin Liška
2017-10-24 14:39 ` Jason Merrill
2017-11-06 8:48 ` Martin Liška
2017-10-18 12:53 ` [PATCH] Fix test-suite fallout of default -Wreturn-type Martin Liška
2017-10-24 14:40 ` Jason Merrill
2017-10-26 12:17 ` Martin Liška
2017-11-03 15:29 ` Jason Merrill
2017-11-06 8:48 ` Martin Liška
2017-11-06 9:58 ` Paolo Carlini
2017-11-06 10:03 ` Martin Liška
2017-11-06 10:09 ` Paolo Carlini
2017-11-06 10:41 ` Martin Liška
2017-11-06 11:40 ` Paolo Carlini
2017-11-06 12:20 ` Paolo Carlini
2017-11-06 13:38 ` Martin Liška
2017-11-06 13:58 ` Paolo Carlini
2017-11-06 14:12 ` Martin Liška
2017-11-06 21:17 ` [PATCH] Further -Wreturn-type testsuite fallout Jakub Jelinek
2017-11-15 13:33 ` [PATCH] Fix test-suite fallout of default -Wreturn-type Jonathan Wakely
2017-11-07 17:33 ` Andreas Schwab
2017-11-07 17:38 ` Jakub Jelinek
2017-11-08 8:02 ` Andreas Schwab
2017-11-19 13:26 ` Thomas Schwinge
2017-11-20 13:58 ` Martin Liška
2017-11-20 14:14 ` Jason Merrill
2018-03-02 16:37 ` Thomas Schwinge
2017-10-12 12:57 ` [PATCH][RFC] Instrument function exit with __builtin_unreachable in C++ Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171106173358.GU14653@tucnak \
--to=jakub@redhat.com \
--cc=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=jwakely@redhat.com \
--cc=mliska@suse.cz \
--cc=polacek@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).