From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6346 invoked by alias); 6 Nov 2017 17:34:12 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 6321 invoked by uid 89); 6 Nov 2017 17:34:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=fes, family X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 06 Nov 2017 17:34:09 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2F555C0546CF; Mon, 6 Nov 2017 17:34:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 2F555C0546CF Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jakub@redhat.com Received: from tucnak.zalov.cz (ovpn-116-247.ams2.redhat.com [10.36.116.247]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D25615C552; Mon, 6 Nov 2017 17:34:03 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id vA6HY03b004308; Mon, 6 Nov 2017 18:34:01 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id vA6HXwNr032330; Mon, 6 Nov 2017 18:33:58 +0100 Date: Mon, 06 Nov 2017 17:41:00 -0000 From: Jakub Jelinek To: Eric Botcazou Cc: Martin =?utf-8?B?TGnFoWth?= , gcc-patches@gcc.gnu.org, Jason Merrill , Marek Polacek , Jonathan Wakely Subject: Re: [PATCH][RFC] Instrument function exit with __builtin_unreachable in C++. Message-ID: <20171106173358.GU14653@tucnak> Reply-To: Jakub Jelinek References: <31ddd79e-1152-9dd9-663b-acd8d1bcd4ab@suse.cz> <99de094c-0e98-f2f2-39a9-a7394e0604ad@redhat.com> <0d484e7b-782b-7c4c-cdda-723efffe15a5@suse.cz> <3785116.x86eWSSaOg@polaris> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3785116.x86eWSSaOg@polaris> User-Agent: Mutt/1.7.1 (2016-10-04) X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00394.txt.bz2 On Mon, Nov 06, 2017 at 06:23:11PM +0100, Eric Botcazou wrote: > > Thank you for review, done that. > > This has enabled -Wreturn-type for Ada, what we don't want since the warning > is outsmarted by the language, so I have applied this. > > > 2017-11-06 Eric Botcazou > > * gcc-interface/misc.c (gnat_post_options): Clear warn_return_type. Hasn't it enabled it also for any other FEs other than C family and Fortran? Say jit, brig, go, lto?, ... I think better would be to remove the initialization to -1 and revert the fortran/options.c change, and instead use in the C family: if (!global_options_set.x_warn_return_type) warn_return_type = c_dialect_cxx (); Unless it for some reason doesn't work for -Wall or -W or similar. Jakub