Re: [PATCH, AArch64] Adjust tuning parameters for Falkor

[James Greenhalgh <james.greenhalgh@arm.com>]

On Wed, Nov 15, 2017 at 03:00:53AM +0000, Luis Machado wrote:
> > I think the best thing is to leave this tuning structure in place and
> > just change default_opt_level   to -1 to disable it at -O3.
> > 
> > Thanks,
> > Andrew
> > 
> 
> Indeed that seems to be more appropriate if re-enabling prefetches in the
> future is a possibility.
> 
> How about the following?

This is OK.

Thanks,
James

> 2017-11-15  Luis Machado  <luis.machado@linaro.org>
> 
> 	gcc/
> 	* config/aarch64/aarch64.c
> 	(qdf24xx_prefetch_tune) <default_opt_level>: Set to -1.
> 	(qdf24xx_tunings) <autoprefetcher_model>: Set to
> 	tune_params::AUTOPREFETCHER_WEAK.
> ---
>  gcc/ChangeLog                | 7 +++++++
>  gcc/config/aarch64/aarch64.c | 4 ++--
>  2 files changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/gcc/ChangeLog b/gcc/ChangeLog
> index b80a421..0e05f9e 100644
> --- a/gcc/ChangeLog
> +++ b/gcc/ChangeLog
> @@ -1,3 +1,10 @@
> +2017-11-15  Luis Machado  <luis.machado@linaro.org>
> +
> +	* config/aarch64/aarch64.c
> +	(qdf24xx_prefetch_tune) <default_opt_level>: Set to -1.
> +	(qdf24xx_tunings) <autoprefetcher_model>: Set to
> +	tune_params::AUTOPREFETCHER_WEAK.
> +
>  2017-11-14  Carl Love  <cel@us.ibm.com>
>  
>  	* config/rs6000/rs6000.c (swap_endian_selector_for_mode): Remove
> diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c
> index 0c67e2b..8779cad 100644
> --- a/gcc/config/aarch64/aarch64.c
> +++ b/gcc/config/aarch64/aarch64.c
> @@ -508,7 +508,7 @@ static const cpu_prefetch_tune qdf24xx_prefetch_tune =
>    32,			/* l1_cache_size  */
>    64,			/* l1_cache_line_size  */
>    1024,			/* l2_cache_size  */
> -  3			/* default_opt_level  */
> +  -1			/* default_opt_level  */
>  };
>  
>  static const cpu_prefetch_tune thunderxt88_prefetch_tune =
> @@ -817,7 +817,7 @@ static const struct tune_params qdf24xx_tunings =
>    2,	/* min_div_recip_mul_sf.  */
>    2,	/* min_div_recip_mul_df.  */
>    0,	/* max_case_values.  */
> -  tune_params::AUTOPREFETCHER_STRONG,	/* autoprefetcher_model.  */
> +  tune_params::AUTOPREFETCHER_WEAK,	/* autoprefetcher_model.  */
>    (AARCH64_EXTRA_TUNE_NONE),		/* tune_flags.  */
>    &qdf24xx_prefetch_tune
>  };
> -- 
> 2.7.4
>