From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24669 invoked by alias); 20 Nov 2017 21:07:52 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 24578 invoked by uid 89); 20 Nov 2017 21:07:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.7 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KB_WAM_FROM_NAME_SINGLEWORD,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=check_value_neg.cc, check_value_negcc X-Spam-User: qpsmtpd, 3 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 20 Nov 2017 21:07:50 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E8B4AFC7D3; Mon, 20 Nov 2017 21:07:48 +0000 (UTC) Received: from localhost (unknown [10.33.36.9]) by smtp.corp.redhat.com (Postfix) with ESMTP id 950456A04B; Mon, 20 Nov 2017 21:07:48 +0000 (UTC) Date: Mon, 20 Nov 2017 21:10:00 -0000 From: Jonathan Wakely To: Christophe Lyon Cc: David Edelsohn , Ed Smith-Rowland <3dw4rd@verizon.net>, "libstdc++@gcc.gnu.org" , gcc-patches , Jonathan Wakely , redi@gcc.gnu.org Subject: Re: [PATCH libstdc++/66689] comp_ellint_3 and ellint_3 return garbage values Message-ID: <20171120210747.GI31922@redhat.com> References: <20171120210154.GH31922@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20171120210154.GH31922@redhat.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.1 (2017-09-22) X-SW-Source: 2017-11/txt/msg01822.txt.bz2 On 20/11/17 21:01 +0000, Jonathan Wakely wrote: >On 20/11/17 21:43 +0100, Christophe Lyon wrote: >>On 20 November 2017 at 17:02, David Edelsohn wrote: >>>This patch has introduced new regressions on at least PowerPC and AArch64. >>> >>>FAIL: ext/special_functions/hyperg/check_value.cc execution test >>>FAIL: tr1/5_numerical_facilities/special_functions/17_hyperg/check_value.cc >>>execution test >>> >>>Thanks, David >> >>On AArch64 and ARM, I have also noticed >>FAIL: special_functions/18_riemann_zeta/check_value.cc (test for excess errors) >>UNRESOLVED: special_functions/18_riemann_zeta/check_value.cc >>compilation failed to produce executable >>because: >>/libstdc++-v3/testsuite/special_functions/18_riemann_zeta/check_value.cc: >>In function 'void test(const testcase_riemann_zeta (&)[Num], >>Ret)': >>/libstdc++-v3/testsuite/special_functions/18_riemann_zeta/check_value.cc:292: >>error: 'riemann_zeta' is not a member of 'std' >>/libstdc++-v3/testsuite/special_functions/18_riemann_zeta/check_value.cc:292: >>note: suggested alternative: 'remainder' >>compiler exited with status 1 > >The problem is that { dg-addition-options } was changed to dg-options, >and so the first dg-options that enables the special functions is not >used: > >--- a/libstdc++-v3/testsuite/special_functions/18_riemann_zeta/check_value.cc >+++ b/libstdc++-v3/testsuite/special_functions/18_riemann_zeta/check_value.cc >@@ -21,7 +21,7 @@ >// riemann_zeta > >// This can take long on simulators, timing out the test. >-// { dg-additional-options "-DMAX_ITERATIONS=5" { target simulator } } >+// { dg-options "-DMAX_ITERATIONS=5" { target simulator } } > I have a script to check dejagnu directives, and it says: testsuite/tr1/5_numerical_facilities/special_functions/20_riemann_zeta/check_value_neg.cc has multiple dg-options directives testsuite/ext/special_functions/airy_ai/check_nan.cc has dg-options after dg-add-options testsuite/ext/special_functions/hyperg/check_nan.cc has dg-options after dg-add-options testsuite/ext/special_functions/conf_hyperg/check_nan.cc has dg-options after dg-add-options testsuite/ext/special_functions/airy_bi/check_nan.cc has dg-options after dg-add-options testsuite/special_functions/02_assoc_legendre/check_nan.cc has dg-options after dg-add-options testsuite/special_functions/14_expint/check_nan.cc has dg-options after dg-add-options testsuite/special_functions/12_ellint_2/check_nan.cc has dg-options after dg-add-options testsuite/special_functions/09_cyl_bessel_k/check_nan.cc has dg-options after dg-add-options testsuite/special_functions/21_sph_neumann/check_nan.cc has dg-options after dg-add-options testsuite/special_functions/15_hermite/check_nan.cc has dg-options after dg-add-options testsuite/special_functions/19_sph_bessel/check_nan.cc has dg-options after dg-add-options testsuite/special_functions/05_comp_ellint_2/check_nan.cc has dg-options after dg-add-options testsuite/special_functions/11_ellint_1/check_nan.cc has dg-options after dg-add-options testsuite/special_functions/17_legendre/check_nan.cc has dg-options after dg-add-options testsuite/special_functions/10_cyl_neumann/check_nan.cc has dg-options after dg-add-options testsuite/special_functions/06_comp_ellint_3/check_nan.cc has dg-options after dg-add-options testsuite/special_functions/06_comp_ellint_3/pr66689.cc has dg-options after dg-add-options testsuite/special_functions/01_assoc_laguerre/check_nan.cc has dg-options after dg-add-options testsuite/special_functions/16_laguerre/check_nan.cc has dg-options after dg-add-options testsuite/special_functions/13_ellint_3/check_nan.cc has dg-options after dg-add-options testsuite/special_functions/13_ellint_3/pr66689.cc has dg-options after dg-add-options testsuite/special_functions/07_cyl_bessel_i/check_nan.cc has dg-options after dg-add-options testsuite/special_functions/18_riemann_zeta/check_nan.cc has dg-options after dg-add-options testsuite/special_functions/18_riemann_zeta/check_value.cc has multiple dg-options directives testsuite/special_functions/08_cyl_bessel_j/check_nan.cc has dg-options after dg-add-options testsuite/special_functions/04_comp_ellint_1/check_nan.cc has dg-options after dg-add-options testsuite/special_functions/03_beta/check_nan.cc has dg-options after dg-add-options testsuite/special_functions/20_sph_legendre/check_nan.cc has dg-options after dg-add-options For now I'll just fix the multiple dg-options one causing the FAILs.