From: Marek Polacek <polacek@redhat.com>
To: David Malcolm <dmalcolm@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] C: don't suggest names that came from earlier failures (PR c/83056)
Date: Tue, 21 Nov 2017 15:56:00 -0000 [thread overview]
Message-ID: <20171121154834.GI8930@redhat.com> (raw)
In-Reply-To: <1511279156-23452-1-git-send-email-dmalcolm@redhat.com>
On Tue, Nov 21, 2017 at 10:45:56AM -0500, David Malcolm wrote:
> PR c/83056 reports an issue affecting trunk and gcc-7 in which
> the C frontend's implementation of lookup_name_fuzzy uses undeclared
> identifiers as suggestions when encountering subsequent undeclared
> identifiers.
>
> The fix is to filter out the names bound to error_mark_node
> in lookup_name_fuzzy.
>
> The C++ frontend is unaffected, as it already does this.
>
> Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu.
>
> OK for trunk and for gcc-7-branch?
Ok, thanks.
Marek
prev parent reply other threads:[~2017-11-21 15:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-21 15:51 David Malcolm
2017-11-21 15:56 ` Marek Polacek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171121154834.GI8930@redhat.com \
--to=polacek@redhat.com \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).