From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 74083 invoked by alias); 21 Nov 2017 15:48:41 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 74074 invoked by uid 89); 21 Nov 2017 15:48:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.7 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,KB_WAM_FROM_NAME_SINGLEWORD,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=Hx-languages-length:640 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 21 Nov 2017 15:48:40 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0D203624A8 for ; Tue, 21 Nov 2017 15:48:39 +0000 (UTC) Received: from redhat.com (ovpn-204-53.brq.redhat.com [10.40.204.53]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 405D460010; Tue, 21 Nov 2017 15:48:38 +0000 (UTC) Date: Tue, 21 Nov 2017 15:56:00 -0000 From: Marek Polacek To: David Malcolm Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] C: don't suggest names that came from earlier failures (PR c/83056) Message-ID: <20171121154834.GI8930@redhat.com> References: <1511279156-23452-1-git-send-email-dmalcolm@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1511279156-23452-1-git-send-email-dmalcolm@redhat.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-SW-Source: 2017-11/txt/msg01910.txt.bz2 On Tue, Nov 21, 2017 at 10:45:56AM -0500, David Malcolm wrote: > PR c/83056 reports an issue affecting trunk and gcc-7 in which > the C frontend's implementation of lookup_name_fuzzy uses undeclared > identifiers as suggestions when encountering subsequent undeclared > identifiers. > > The fix is to filter out the names bound to error_mark_node > in lookup_name_fuzzy. > > The C++ frontend is unaffected, as it already does this. > > Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. > > OK for trunk and for gcc-7-branch? Ok, thanks. Marek