From: Jonathan Wakely <jwakely@redhat.com>
To: Stephan Bergmann <sbergman@redhat.com>
Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fix typo in unordered_map deduction guide, missing "typename ="
Date: Mon, 27 Nov 2017 17:03:00 -0000 [thread overview]
Message-ID: <20171127164449.GY31922@redhat.com> (raw)
In-Reply-To: <a9122ba4-8348-1b44-fac1-3dd799ed101f@redhat.com>
On 24/11/17 18:03 +0100, Stephan Bergmann wrote:
>Otherwise, at least recent Clang trunk with -std=gnu++17 complains
>
>>In file included from lib/gcc/x86_64-pc-linux-gnu/8.0.0/../../../../include/c++/8.0.0/functional:60:
>>In file included from lib/gcc/x86_64-pc-linux-gnu/8.0.0/../../../../include/c++/8.0.0/unordered_map:47:
>>lib/gcc/x86_64-pc-linux-gnu/8.0.0/../../../../include/c++/8.0.0/bits/unordered_map.h:1197:5: error: deduction guide template contains a template parameter that cannot be deduced
>> unordered_map(initializer_list<pair<_Key, _Tp>>, _Allocator)
>> ^
>>lib/gcc/x86_64-pc-linux-gnu/8.0.0/../../../../include/c++/8.0.0/bits/unordered_map.h:1196:34: note: non-deducible template parameter (anonymous)
>> _RequireAllocator<_Allocator>>
>> ^
>>1 error generated.
>
Committed to trunk, backport to gcc-7-branch will follow.
I created https://gcc.gnu.org/PR83181 for the accepts-invalid bug. All
our tests pass with or without the fix, and even with that deduction
guide completely deleted, so I don't understand what it's supposed to
be for. This is hardly the only thing I don't understand about
deduction guides.
prev parent reply other threads:[~2017-11-27 16:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-24 17:21 Stephan Bergmann
2017-11-27 17:03 ` Jonathan Wakely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171127164449.GY31922@redhat.com \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=sbergman@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).