From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12866 invoked by alias); 27 Nov 2017 16:44:53 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 12847 invoked by uid 89); 27 Nov 2017 16:44:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.7 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,KAM_SHORT,KB_WAM_FROM_NAME_SINGLEWORD,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=Hx-languages-length:1214, our X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 27 Nov 2017 16:44:52 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 024844E90B; Mon, 27 Nov 2017 16:44:51 +0000 (UTC) Received: from localhost (unknown [10.33.36.16]) by smtp.corp.redhat.com (Postfix) with ESMTP id 98C92600C2; Mon, 27 Nov 2017 16:44:50 +0000 (UTC) Date: Mon, 27 Nov 2017 17:03:00 -0000 From: Jonathan Wakely To: Stephan Bergmann Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Fix typo in unordered_map deduction guide, missing "typename =" Message-ID: <20171127164449.GY31922@redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.1 (2017-09-22) X-SW-Source: 2017-11/txt/msg02312.txt.bz2 On 24/11/17 18:03 +0100, Stephan Bergmann wrote: >Otherwise, at least recent Clang trunk with -std=gnu++17 complains > >>In file included from lib/gcc/x86_64-pc-linux-gnu/8.0.0/../../../../include/c++/8.0.0/functional:60: >>In file included from lib/gcc/x86_64-pc-linux-gnu/8.0.0/../../../../include/c++/8.0.0/unordered_map:47: >>lib/gcc/x86_64-pc-linux-gnu/8.0.0/../../../../include/c++/8.0.0/bits/unordered_map.h:1197:5: error: deduction guide template contains a template parameter that cannot be deduced >> unordered_map(initializer_list>, _Allocator) >> ^ >>lib/gcc/x86_64-pc-linux-gnu/8.0.0/../../../../include/c++/8.0.0/bits/unordered_map.h:1196:34: note: non-deducible template parameter (anonymous) >> _RequireAllocator<_Allocator>> >> ^ >>1 error generated. > Committed to trunk, backport to gcc-7-branch will follow. I created https://gcc.gnu.org/PR83181 for the accepts-invalid bug. All our tests pass with or without the fix, and even with that deduction guide completely deleted, so I don't understand what it's supposed to be for. This is hardly the only thing I don't understand about deduction guides.