* [PATCH] Missing noexcept in string_view::find_first_of declaration
@ 2017-11-24 17:32 Stephan Bergmann
2017-11-24 19:03 ` Jonathan Wakely
0 siblings, 1 reply; 3+ messages in thread
From: Stephan Bergmann @ 2017-11-24 17:32 UTC (permalink / raw)
To: libstdc++, gcc-patches
[-- Attachment #1: Type: text/plain, Size: 0 bytes --]
[-- Attachment #2: 0001-Missing-noexcept-in-string_view-find_first_of-declar.patch --]
[-- Type: text/x-patch, Size: 1133 bytes --]
From 0a75fbb0c16e216892d16f1ba3448471e33f61bb Mon Sep 17 00:00:00 2001
From: Stephan Bergmann <sbergman@redhat.com>
Date: Fri, 24 Nov 2017 18:04:30 +0100
Subject: [PATCH] Missing noexcept in string_view::find_first_of declaration
cf. definition in libstdc++-v3/include/bits/string_view.tcc that does have the
noexcept (like all the other overloads defined inline in
libstdc++-v3/include/std/string_view do).
---
libstdc++-v3/include/std/string_view | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libstdc++-v3/include/std/string_view b/libstdc++-v3/include/std/string_view
index fa834002726..68b4b08f8f4 100644
--- a/libstdc++-v3/include/std/string_view
+++ b/libstdc++-v3/include/std/string_view
@@ -323,7 +323,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
{ return this->find(__c, __pos); }
constexpr size_type
- find_first_of(const _CharT* __str, size_type __pos, size_type __n) const;
+ find_first_of(const _CharT* __str, size_type __pos, size_type __n) const noexcept;
constexpr size_type
find_first_of(const _CharT* __str, size_type __pos = 0) const noexcept
--
2.13.6
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Missing noexcept in string_view::find_first_of declaration
2017-11-24 17:32 [PATCH] Missing noexcept in string_view::find_first_of declaration Stephan Bergmann
@ 2017-11-24 19:03 ` Jonathan Wakely
2017-11-27 21:30 ` Jonathan Wakely
0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Wakely @ 2017-11-24 19:03 UTC (permalink / raw)
To: Stephan Bergmann; +Cc: libstdc++, gcc-patches
On 24/11/17 18:09 +0100, Stephan Bergmann wrote:
>cf. definition in libstdc++-v3/include/bits/string_view.tcc that does have the
>noexcept (like all the other overloads defined inline in
>libstdc++-v3/include/std/string_view do).
I thought Jason already fixed this in
https://gcc.gnu.org/ml/gcc-patches/2017-11/msg01106.html but it
doesn't seem to have been committed yet.
I'll take care of it. Thanks for the patch.
>---
> libstdc++-v3/include/std/string_view | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/libstdc++-v3/include/std/string_view b/libstdc++-v3/include/std/string_view
>index fa834002726..68b4b08f8f4 100644
>--- a/libstdc++-v3/include/std/string_view
>+++ b/libstdc++-v3/include/std/string_view
>@@ -323,7 +323,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
> { return this->find(__c, __pos); }
>
> constexpr size_type
>- find_first_of(const _CharT* __str, size_type __pos, size_type __n) const;
>+ find_first_of(const _CharT* __str, size_type __pos, size_type __n) const noexcept;
>
> constexpr size_type
> find_first_of(const _CharT* __str, size_type __pos = 0) const noexcept
>--
>2.13.6
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Missing noexcept in string_view::find_first_of declaration
2017-11-24 19:03 ` Jonathan Wakely
@ 2017-11-27 21:30 ` Jonathan Wakely
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Wakely @ 2017-11-27 21:30 UTC (permalink / raw)
To: Stephan Bergmann; +Cc: libstdc++, gcc-patches
On 24/11/17 17:32 +0000, Jonathan Wakely wrote:
>On 24/11/17 18:09 +0100, Stephan Bergmann wrote:
>>cf. definition in libstdc++-v3/include/bits/string_view.tcc that does have the
>>noexcept (like all the other overloads defined inline in
>>libstdc++-v3/include/std/string_view do).
>
>I thought Jason already fixed this in
>https://gcc.gnu.org/ml/gcc-patches/2017-11/msg01106.html but it
>doesn't seem to have been committed yet.
>
>I'll take care of it. Thanks for the patch.
Committed to trunk. Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-27 19:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-24 17:32 [PATCH] Missing noexcept in string_view::find_first_of declaration Stephan Bergmann
2017-11-24 19:03 ` Jonathan Wakely
2017-11-27 21:30 ` Jonathan Wakely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).