From: Segher Boessenkool <segher@kernel.crashing.org>
To: Michael Meissner <meissner@linux.vnet.ibm.com>,
Martin Sebor <msebor@gmail.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
David Edelsohn <dje.gcc@gmail.com>,
Bill Schmidt <wschmidt@linux.vnet.ibm.com>
Subject: Re: [PATCH] PR libgcc/83112, Fix warnings on libgcc float128-ifunc.c
Date: Thu, 30 Nov 2017 05:08:00 -0000 [thread overview]
Message-ID: <20171130024250.GX10515@gate.crashing.org> (raw)
In-Reply-To: <20171127234009.GA28990@ibm-tiger.the-meissners.org>
Hi,
On Mon, Nov 27, 2017 at 06:40:09PM -0500, Michael Meissner wrote:
> @@ -33,3 +35,13 @@ $(fp128_hw_obj) : $(srcdir)/config/rs6
>
> $(fp128_ifunc_obj) : INTERNAL_CFLAGS += $(FP128_CFLAGS_SW)
> $(fp128_ifunc_obj) : $(srcdir)/config/rs6000/t-float128-hw
> +
> +_mulkc3-hw.c: $(srcdir)/config/rs6000/_mulkc3.c
> + rm -rf _mulkc3.c
> + (echo "#define __mulkc3 __mulkc3_hw"; \
> + cat $(srcdir)/config/rs6000/_mulkc3.c) > _mulkc3-hw.c
Please don't -rf. -rf is a dangerous habit.
This also won't work if anything tries to build _mulkc3-hw.c a second
time; you have deleted its prerequisite.
Maybe some other scheme is better?
> --- libgcc/config/rs6000/t-float128 (revision 255177)
> +++ libgcc/config/rs6000/t-float128 (working copy)
> @@ -86,7 +86,7 @@ test:
> for x in $(fp128_obj); do echo " $$x"; done;
>
> clean-float128:
> - rm -rf $(fp128_softfp_src)
> + rm -rf $(fp128_softfp_src) $(fp128_hardfp_src)
> @$(MULTICLEAN) multi-clean DO=clean-float128
-rm to avoid warnings from rm if you clean without the files being there.
Otherwise looks good. Thanks!
Segher
next prev parent reply other threads:[~2017-11-30 2:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 19:57 Michael Meissner
2017-11-27 22:55 ` Martin Sebor
2017-11-28 0:55 ` Michael Meissner
2017-11-30 5:08 ` Segher Boessenkool [this message]
2017-11-30 21:52 ` Michael Meissner
2017-12-01 5:40 ` Michael Meissner
2017-12-01 23:54 ` Segher Boessenkool
2017-12-11 20:58 ` Michael Meissner
2017-12-12 17:05 ` Segher Boessenkool
2017-12-12 17:18 ` Andreas Schwab
2017-12-12 21:56 ` Michael Meissner
2017-12-13 20:57 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171130024250.GX10515@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=meissner@linux.vnet.ibm.com \
--cc=msebor@gmail.com \
--cc=wschmidt@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).