From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109314 invoked by alias); 30 Nov 2017 02:42:58 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 108479 invoked by uid 89); 30 Nov 2017 02:42:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-10.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KB_WAM_FROM_NAME_SINGLEWORD,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=x X-HELO: gate.crashing.org Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 30 Nov 2017 02:42:55 +0000 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id vAU2gp0k012688; Wed, 29 Nov 2017 20:42:52 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id vAU2gpAT012687; Wed, 29 Nov 2017 20:42:51 -0600 Date: Thu, 30 Nov 2017 05:08:00 -0000 From: Segher Boessenkool To: Michael Meissner , Martin Sebor , GCC Patches , David Edelsohn , Bill Schmidt Subject: Re: [PATCH] PR libgcc/83112, Fix warnings on libgcc float128-ifunc.c Message-ID: <20171130024250.GX10515@gate.crashing.org> References: <20171127192131.GA15914@ibm-tiger.the-meissners.org> <20171127234009.GA28990@ibm-tiger.the-meissners.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171127234009.GA28990@ibm-tiger.the-meissners.org> User-Agent: Mutt/1.4.2.3i X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg02535.txt.bz2 Hi, On Mon, Nov 27, 2017 at 06:40:09PM -0500, Michael Meissner wrote: > @@ -33,3 +35,13 @@ $(fp128_hw_obj) : $(srcdir)/config/rs6 > > $(fp128_ifunc_obj) : INTERNAL_CFLAGS += $(FP128_CFLAGS_SW) > $(fp128_ifunc_obj) : $(srcdir)/config/rs6000/t-float128-hw > + > +_mulkc3-hw.c: $(srcdir)/config/rs6000/_mulkc3.c > + rm -rf _mulkc3.c > + (echo "#define __mulkc3 __mulkc3_hw"; \ > + cat $(srcdir)/config/rs6000/_mulkc3.c) > _mulkc3-hw.c Please don't -rf. -rf is a dangerous habit. This also won't work if anything tries to build _mulkc3-hw.c a second time; you have deleted its prerequisite. Maybe some other scheme is better? > --- libgcc/config/rs6000/t-float128 (revision 255177) > +++ libgcc/config/rs6000/t-float128 (working copy) > @@ -86,7 +86,7 @@ test: > for x in $(fp128_obj); do echo " $$x"; done; > > clean-float128: > - rm -rf $(fp128_softfp_src) > + rm -rf $(fp128_softfp_src) $(fp128_hardfp_src) > @$(MULTICLEAN) multi-clean DO=clean-float128 -rm to avoid warnings from rm if you clean without the files being there. Otherwise looks good. Thanks! Segher