From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69616 invoked by alias); 30 Nov 2017 11:16:50 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 69198 invoked by uid 89); 30 Nov 2017 11:16:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=awful, suffers, 41PM, 41pm X-HELO: gate.crashing.org Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 30 Nov 2017 11:16:47 +0000 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id vAUBGibf009388; Thu, 30 Nov 2017 05:16:45 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id vAUBGiol009387; Thu, 30 Nov 2017 05:16:44 -0600 Date: Thu, 30 Nov 2017 11:54:00 -0000 From: Segher Boessenkool To: Martin Sebor Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] final: Improve output for -dp and -fverbose-asm Message-ID: <20171130111644.GY10515@gate.crashing.org> References: <95ff7e21-ca49-b714-cd17-632a30fffb61@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <95ff7e21-ca49-b714-cd17-632a30fffb61@gmail.com> User-Agent: Mutt/1.4.2.3i X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg02550.txt.bz2 On Wed, Nov 29, 2017 at 08:46:41PM -0700, Martin Sebor wrote: > On 11/29/2017 04:13 PM, Segher Boessenkool wrote: > >This improves the assembler output (for -dp and -fverbose-asm) in > >several ways. It always prints the insn_cost. It does not print > >"[length = NN]" but "[c=NN l=NN]", to save space. It does not add one > >to the instruction alternative number (everything else starts counting > >those at 0, too). And finally, it tries to keep things lined up in > >columns a bit better. > > > >Tested on powerpc64-linux {-m32,-m64}; is this okay for trunk? > > [c=NN l=NN] will be meaningless to those without some deeper > insight into/experience with what's actually being printed. > It might as well say [NN NN]. But such extreme terseness would Length isn't printed on all targets, fwiw. > seem to run counter to the documented purpose of -fverbose-asm > to "Put extra commentary information in the generated assembly > code to make it more readable." The point is that [length = 12] takes up an awful lot of space. The output of -fverbose-asm alread suffers from information overload. > Looking further in the manual I don't see the [length=NN] bit > mentioned (nor does your patch add a mention of it) so while > the meaning of [length=NN] isn't exactly obvious, using [l=NN] > instead certainly won't make it easier to read. Does the manual > need updating? Should -fverbose-asm print length (and cost) at all? They should be printed for -dp (which is for debugging the *compiler*), but are they very useful for -fverbose-asm (which is primarily for debugging the *user program*)? Segher