From: Segher Boessenkool <segher@kernel.crashing.org>
To: Martin Sebor <msebor@gmail.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] final: Improve output for -dp and -fverbose-asm
Date: Thu, 30 Nov 2017 17:15:00 -0000 [thread overview]
Message-ID: <20171130170724.GC10515@gate.crashing.org> (raw)
In-Reply-To: <dbbf5199-96cf-9d25-6711-eaedccf27c18@gmail.com>
On Thu, Nov 30, 2017 at 09:54:26AM -0700, Martin Sebor wrote:
> >It is neither line length nor amt of info that makes the second one
> >way better readable.
>
> The justification certainly makes it easier to read. But
> the abbreviations make it harder to interpret. [c=4 l=4]
> makes no sense to anyone not already familiar with what
> it means.
>
> There's nothing wrong with using mnemonics as long as they're
> well established and commonly understood. Absent that, they
> should be explained in some accessible document.
>
> Not everyone who reads the verbose assembly is familiar with
> GCC internals. Users read it to help debug problems in their
> code. They shouldn't have to also study GCC source code to
> understand what the contents mean.
This is the -dp output, I hardly ever use -fverbose-asm, it has been
unreadable for ten years or so.
-fverbose-asm looks like this:
===
.L.yk:
# 81288.c:4: unsigned int *un = (f3 != 0) ? &t4 : 0;
cmpdi 0,4,0 # tmp130, f3
beq 0,.L2 #
# 81288.c:6: *un ^= t4;
srdi 9,3,32 #, tmp131, t4
xor 9,9,3 #, tmp132, tmp131, t4
# 81288.c:7: if (*un == t4)
rldicl 9,9,0,32 # tmp133, tmp132
# 81288.c:7: if (*un == t4)
cmpd 7,9,3 # t4, tmp134, tmp133
beq 7,.L7 #
.L5:
# 81288.c:11: }
mr 3,4 #, <retval>
blr
.L2:
# 81288.c:6: *un ^= t4;
lwz 9,0(4) # MEM[(unsigned int *)0B], _13
trap
.L7:
# 81288.c:8: f3 = !!t4;
addic 4,9,-1 # tmp139, tmp133
subfe 4,4,9 # <retval>, tmp139, tmp133
b .L5 #
===
If we're okay with outputting that kind of stuff to *users*, then how
bad is [c=8 l=4] for GCC developers? Heh.
Segher
next prev parent reply other threads:[~2017-11-30 17:07 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-29 23:37 Segher Boessenkool
2017-11-30 7:52 ` Martin Sebor
2017-11-30 11:54 ` Segher Boessenkool
2017-11-30 16:06 ` Michael Matz
2017-11-30 16:36 ` Martin Sebor
2017-11-30 16:50 ` Segher Boessenkool
2017-11-30 17:02 ` Martin Sebor
2017-11-30 17:14 ` Michael Matz
2017-11-30 17:55 ` David Malcolm
2017-12-04 15:49 ` Michael Matz
2017-11-30 17:55 ` Martin Sebor
2017-12-01 0:32 ` Jeff Law
2017-12-01 22:52 ` Segher Boessenkool
2017-12-04 12:39 ` Michael Matz
2017-11-30 17:15 ` Segher Boessenkool [this message]
2017-11-30 22:59 ` Martin Sebor
2017-12-01 0:26 ` Jeff Law
2017-12-01 0:49 ` Jeff Law
2017-12-01 23:45 ` Segher Boessenkool
2017-11-30 16:44 ` Kyrill Tkachov
2017-11-30 16:54 ` Michael Matz
2017-11-30 16:55 ` Kyrill Tkachov
2017-11-30 17:07 ` Michael Matz
2017-12-01 0:22 ` Jeff Law
2017-12-01 0:25 ` Jeff Law
2017-12-01 1:17 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171130170724.GC10515@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=msebor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).