From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10374 invoked by alias); 30 Nov 2017 17:25:37 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 10364 invoked by uid 89); 30 Nov 2017 17:25:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.7 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,KB_WAM_FROM_NAME_SINGLEWORD,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=sk:omp-sim, sk:ompsim, UD:omp-simd-clone.c, cilk.c X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 30 Nov 2017 17:25:36 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B5C2380099; Thu, 30 Nov 2017 17:25:34 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-116-77.ams2.redhat.com [10.36.116.77]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 26A2E5D9C8; Thu, 30 Nov 2017 17:25:29 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id vAUHPQN8019122; Thu, 30 Nov 2017 18:25:27 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id vAUHPOmk019121; Thu, 30 Nov 2017 18:25:24 +0100 Date: Thu, 30 Nov 2017 17:29:00 -0000 From: Jakub Jelinek To: Jeff Law Cc: Marek Polacek , "Koval, Julia" , Joseph Myers , GCC Patches Subject: Re: [patch] remove cilk-plus Message-ID: <20171130172524.GK2353@tucnak> Reply-To: Jakub Jelinek References: <20171116154924.GV14653@tucnak> <4E89A029A0F8D443B436A5167BA3C53F42AD142B@IRSMSX101.ger.corp.intel.com> <535c9af4-af2d-e825-19fe-92a982a5d72f@redhat.com> <4E89A029A0F8D443B436A5167BA3C53F42AD4304@IRSMSX101.ger.corp.intel.com> <4E89A029A0F8D443B436A5167BA3C53F42AD4D90@IRSMSX101.ger.corp.intel.com> <07db22a2-5c92-7eff-f0c0-e5952ce23c8c@redhat.com> <4E89A029A0F8D443B436A5167BA3C53F42AD8BC5@IRSMSX101.ger.corp.intel.com> <20171130163240.GX5131@redhat.com> <708a5420-8ceb-7590-ce24-cbaa7d42790f@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <708a5420-8ceb-7590-ce24-cbaa7d42790f@redhat.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg02597.txt.bz2 On Thu, Nov 30, 2017 at 10:15:20AM -0700, Jeff Law wrote: > On 11/30/2017 09:32 AM, Marek Polacek wrote: > > On Thu, Nov 30, 2017 at 11:54:11AM +0000, Koval, Julia wrote: > >> Hi, here is the followup patch. Ok for trunk? > >> > >> gcc/c-family/ > >> * c-common.h (inv_list): Remove. > > > > In function.h I still see > > > > /* In a Cilk function, the VAR_DECL for the frame descriptor. */ > > tree cilk_frame_decl; > > > > isn't that redundant now, too? > Yes. I actually saw that today when looking at the issue Florian and > Carlos raised internally. :-) > > Assuming a grep doesn't find any references, removal is pre-approved. grep finds actually tons of further stuff: grep -i cilk * c*/* 2>/dev/null | grep -v ChangeLog cgraph.h: /* True if this is a Cilk Plus variant. */ cgraph.h: unsigned int cilk_elemental : 1; function.h: /* In a Cilk function, the VAR_DECL for the frame descriptor. */ function.h: tree cilk_frame_decl; function.h: /* This will indicate whether a function is a cilk function */ function.h: unsigned int is_cilk_function : 1; function.h: /* Nonzero if this is a Cilk function that spawns. */ function.h: unsigned int calls_cilk_spawn : 1; omp-simd-clone.c: clone_info->cilk_elemental = false; target.def:/* Functions relating to OpenMP and Cilk Plus SIMD clones. */ tree-inline.h: /* Cilk keywords currently need to replace some variables that tree-inline.h: bool remap_var_for_cilk; c-family/c-attribs.c: { "cilk simd function", 0, -1, true, false, false, c-family/c-attribs.c: if (lookup_attribute ("cilk simd function", c-family/c-attribs.c: "function marked as a Cilk Plus SIMD-enabled function"); c-family/c.opt:fcilkplus Undocumented c-family/c.opt:C ObjC C++ ObjC++ LTO Report Var(flag_cilkplus) Init(0) cp/cp-tree.h:/* In c-family/cilk.c */ cp/cp-tree.h:extern bool cilk_valid_spawn (tree); cp/parser.c: parser->cilk_simd_fn_info = NULL; cp/parser.c: clauses, Cilk Plus SIMD-enabled functions' vector attributes, and cp/parser.c: a Cilk Plus for loop. cp/parser.h:/* Helper data structure for parsing #pragma omp declare simd, and Cilk Plus cp/parser.h: /* When parsing Cilk Plus SIMD-enabled functions' vector attributes, cp/parser.h: cp_omp_declare_simd_data * GTY((skip)) cilk_simd_fn_info; Of course, when it is Cilk+ + something else, it should be carefully adjusted. Jakub