From: Michael Meissner <meissner@linux.vnet.ibm.com>
To: Michael Meissner <meissner@linux.vnet.ibm.com>,
Segher Boessenkool <segher@kernel.crashing.org>,
Martin Sebor <msebor@gmail.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
David Edelsohn <dje.gcc@gmail.com>,
Bill Schmidt <wschmidt@linux.vnet.ibm.com>
Subject: Re: [PATCH] PR libgcc/83112, Fix warnings on libgcc float128-ifunc.c
Date: Fri, 01 Dec 2017 05:40:00 -0000 [thread overview]
Message-ID: <20171201054022.GA5348@ibm-tiger.the-meissners.org> (raw)
In-Reply-To: <20171130205425.GA11524@ibm-tiger.the-meissners.org>
After committing the previous patch, I noticed that it was now generating
warnings for __{mul,div}kc3_{sw,hw} not having a prototype that I hadn't
noticed during development of the patch. This is due to the fact that before I
added the ifunc support, it was only compiling __{mul,div}kc3, and those have
built-in declarations. I installed this patch as being obvious:
2017-11-30 Michael Meissner <meissner@linux.vnet.ibm.com>
* config/rs6000/_mulkc3.c (__mulkc3): Add forward declaration.
* config/rs6000/_divkc3.c (__divkc3): Likewise.
Index: libgcc/config/rs6000/_divkc3.c
===================================================================
--- libgcc/config/rs6000/_divkc3.c (revision 255288)
+++ libgcc/config/rs6000/_divkc3.c (working copy)
@@ -37,6 +37,8 @@ typedef __complex float KCtype __attribu
#define __divkc3 __divkc3_sw
#endif
+extern KCtype __divkc3 (KFtype, KFtype, KFtype, KFtype);
+
KCtype
__divkc3 (KFtype a, KFtype b, KFtype c, KFtype d)
{
Index: libgcc/config/rs6000/_mulkc3.c
===================================================================
--- libgcc/config/rs6000/_mulkc3.c (revision 255288)
+++ libgcc/config/rs6000/_mulkc3.c (working copy)
@@ -35,6 +35,8 @@ typedef __complex float KCtype __attribu
#define __mulkc3 __mulkc3_sw
#endif
+extern KCtype __mulkc3 (KFtype, KFtype, KFtype, KFtype);
+
KCtype
__mulkc3 (KFtype a, KFtype b, KFtype c, KFtype d)
{
--
Michael Meissner, IBM
IBM, M/S 2506R, 550 King Street, Littleton, MA 01460-6245, USA
email: meissner@linux.vnet.ibm.com, phone: +1 (978) 899-4797
next prev parent reply other threads:[~2017-12-01 5:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 19:57 Michael Meissner
2017-11-27 22:55 ` Martin Sebor
2017-11-28 0:55 ` Michael Meissner
2017-11-30 5:08 ` Segher Boessenkool
2017-11-30 21:52 ` Michael Meissner
2017-12-01 5:40 ` Michael Meissner [this message]
2017-12-01 23:54 ` Segher Boessenkool
2017-12-11 20:58 ` Michael Meissner
2017-12-12 17:05 ` Segher Boessenkool
2017-12-12 17:18 ` Andreas Schwab
2017-12-12 21:56 ` Michael Meissner
2017-12-13 20:57 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171201054022.GA5348@ibm-tiger.the-meissners.org \
--to=meissner@linux.vnet.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=msebor@gmail.com \
--cc=segher@kernel.crashing.org \
--cc=wschmidt@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).