From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 41693 invoked by alias); 1 Dec 2017 05:40:33 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 41130 invoked by uid 89); 1 Dec 2017 05:40:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-9.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KAM_ASCII_DIVIDERS,KAM_LAZY_DOMAIN_SECURITY,KAM_MANYTO,KB_WAM_FROM_NAME_SINGLEWORD,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=255288 X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 01 Dec 2017 05:40:31 +0000 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id vB15dC3W049168 for ; Fri, 1 Dec 2017 00:40:28 -0500 Received: from e11.ny.us.ibm.com (e11.ny.us.ibm.com [129.33.205.201]) by mx0b-001b2d01.pphosted.com with ESMTP id 2ejyxfbqcx-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Fri, 01 Dec 2017 00:40:28 -0500 Received: from localhost by e11.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 1 Dec 2017 00:40:25 -0500 Received: from b01cxnp22033.gho.pok.ibm.com (9.57.198.23) by e11.ny.us.ibm.com (146.89.104.198) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 1 Dec 2017 00:40:23 -0500 Received: from b01ledav005.gho.pok.ibm.com (b01ledav005.gho.pok.ibm.com [9.57.199.110]) by b01cxnp22033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id vB15eNMC40894622; Fri, 1 Dec 2017 05:40:23 GMT Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9A78BAE03B; Fri, 1 Dec 2017 00:41:19 -0500 (EST) Received: from ibm-tiger.the-meissners.org (unknown [9.32.77.111]) by b01ledav005.gho.pok.ibm.com (Postfix) with ESMTP id 7D0AAAE043; Fri, 1 Dec 2017 00:41:19 -0500 (EST) Received: by ibm-tiger.the-meissners.org (Postfix, from userid 500) id 816B747FD1; Fri, 1 Dec 2017 00:40:22 -0500 (EST) Date: Fri, 01 Dec 2017 05:40:00 -0000 From: Michael Meissner To: Michael Meissner , Segher Boessenkool , Martin Sebor , GCC Patches , David Edelsohn , Bill Schmidt Subject: Re: [PATCH] PR libgcc/83112, Fix warnings on libgcc float128-ifunc.c Mail-Followup-To: Michael Meissner , Segher Boessenkool , Martin Sebor , GCC Patches , David Edelsohn , Bill Schmidt References: <20171127192131.GA15914@ibm-tiger.the-meissners.org> <20171127234009.GA28990@ibm-tiger.the-meissners.org> <20171130024250.GX10515@gate.crashing.org> <20171130205425.GA11524@ibm-tiger.the-meissners.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171130205425.GA11524@ibm-tiger.the-meissners.org> User-Agent: Mutt/1.5.20 (2009-12-10) X-TM-AS-GCONF: 00 x-cbid: 17120105-2213-0000-0000-00000243FEB3 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00008132; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000242; SDB=6.00953716; UDB=6.00481914; IPR=6.00733791; BA=6.00005724; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00018284; XFM=3.00000015; UTC=2017-12-01 05:40:25 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17120105-2214-0000-0000-00005850CE74 Message-Id: <20171201054022.GA5348@ibm-tiger.the-meissners.org> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-12-01_01:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1712010067 X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00013.txt.bz2 After committing the previous patch, I noticed that it was now generating warnings for __{mul,div}kc3_{sw,hw} not having a prototype that I hadn't noticed during development of the patch. This is due to the fact that before I added the ifunc support, it was only compiling __{mul,div}kc3, and those have built-in declarations. I installed this patch as being obvious: 2017-11-30 Michael Meissner * config/rs6000/_mulkc3.c (__mulkc3): Add forward declaration. * config/rs6000/_divkc3.c (__divkc3): Likewise. Index: libgcc/config/rs6000/_divkc3.c =================================================================== --- libgcc/config/rs6000/_divkc3.c (revision 255288) +++ libgcc/config/rs6000/_divkc3.c (working copy) @@ -37,6 +37,8 @@ typedef __complex float KCtype __attribu #define __divkc3 __divkc3_sw #endif +extern KCtype __divkc3 (KFtype, KFtype, KFtype, KFtype); + KCtype __divkc3 (KFtype a, KFtype b, KFtype c, KFtype d) { Index: libgcc/config/rs6000/_mulkc3.c =================================================================== --- libgcc/config/rs6000/_mulkc3.c (revision 255288) +++ libgcc/config/rs6000/_mulkc3.c (working copy) @@ -35,6 +35,8 @@ typedef __complex float KCtype __attribu #define __mulkc3 __mulkc3_sw #endif +extern KCtype __mulkc3 (KFtype, KFtype, KFtype, KFtype); + KCtype __mulkc3 (KFtype a, KFtype b, KFtype c, KFtype d) { -- Michael Meissner, IBM IBM, M/S 2506R, 550 King Street, Littleton, MA 01460-6245, USA email: meissner@linux.vnet.ibm.com, phone: +1 (978) 899-4797