public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Michael Meissner <meissner@linux.vnet.ibm.com>,
	gcc-patches@gcc.gnu.org,        dje.gcc@gmail.com,
	meissner@gcc.gnu.org
Subject: Re: [PATCH] rs6000: Improve fusion assembler output
Date: Fri, 01 Dec 2017 22:53:00 -0000	[thread overview]
Message-ID: <20171201225327.GH10515@gate.crashing.org> (raw)
In-Reply-To: <20171130175452.GA13683@ibm-tiger.the-meissners.org>

On Thu, Nov 30, 2017 at 12:54:53PM -0500, Michael Meissner wrote:
> On Thu, Nov 30, 2017 at 11:59:37AM +0000, Segher Boessenkool wrote:
> > This improves the output for load and store fusion a little.  In most
> > cases it removes the comment output, because that makes the generated
> > assembler code hard to read, and equivalent info is available with -dp
> > anyway.  For the vector loads it puts the comment on the second insn,
> > where it doesn't interfere with other debug comments.
> > 
> > Mike, does this look good?  Or is there something I'm missing :-)
> > 
> > Tested on powerpc64-linux {-m32,-m64}.
> 
> The comment was used by my perl script (analyze-ppc-asm) that looks at .s files
> and prints out statistics.  I can adjust the tool so it no longer looks for the
> comment, but actually looks at the adjacent instructions (which I do in a few
> other cases).

Ah okay, thanks!  I'll commit the patch then.


Segher

      reply	other threads:[~2017-12-01 22:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-30 12:04 Segher Boessenkool
2017-11-30 18:05 ` Michael Meissner
2017-12-01 22:53   ` Segher Boessenkool [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171201225327.GH10515@gate.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=dje.gcc@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=meissner@gcc.gnu.org \
    --cc=meissner@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).