From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25145 invoked by alias); 1 Dec 2017 22:53:32 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 25130 invoked by uid 89); 1 Dec 2017 22:53:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy= X-Spam-User: qpsmtpd, 2 recipients X-HELO: gate.crashing.org Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 01 Dec 2017 22:53:31 +0000 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id vB1MrSFt001690; Fri, 1 Dec 2017 16:53:28 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id vB1MrRQl001689; Fri, 1 Dec 2017 16:53:27 -0600 Date: Fri, 01 Dec 2017 22:53:00 -0000 From: Segher Boessenkool To: Michael Meissner , gcc-patches@gcc.gnu.org, dje.gcc@gmail.com, meissner@gcc.gnu.org Subject: Re: [PATCH] rs6000: Improve fusion assembler output Message-ID: <20171201225327.GH10515@gate.crashing.org> References: <15d8c743179eaeb9382ea63f183a19a56d4d807b.1512041813.git.segher@kernel.crashing.org> <20171130175452.GA13683@ibm-tiger.the-meissners.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171130175452.GA13683@ibm-tiger.the-meissners.org> User-Agent: Mutt/1.4.2.3i X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00072.txt.bz2 On Thu, Nov 30, 2017 at 12:54:53PM -0500, Michael Meissner wrote: > On Thu, Nov 30, 2017 at 11:59:37AM +0000, Segher Boessenkool wrote: > > This improves the output for load and store fusion a little. In most > > cases it removes the comment output, because that makes the generated > > assembler code hard to read, and equivalent info is available with -dp > > anyway. For the vector loads it puts the comment on the second insn, > > where it doesn't interfere with other debug comments. > > > > Mike, does this look good? Or is there something I'm missing :-) > > > > Tested on powerpc64-linux {-m32,-m64}. > > The comment was used by my perl script (analyze-ppc-asm) that looks at .s files > and prints out statistics. I can adjust the tool so it no longer looks for the > comment, but actually looks at the adjacent instructions (which I do in a few > other cases). Ah okay, thanks! I'll commit the patch then. Segher