From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21833 invoked by alias); 1 Dec 2017 23:33:45 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 21824 invoked by uid 89); 1 Dec 2017 23:33:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-10.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KAM_NUMSUBJECT,KB_WAM_FROM_NAME_SINGLEWORD,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: gate.crashing.org Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 01 Dec 2017 23:33:44 +0000 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id vB1NXeft003784; Fri, 1 Dec 2017 17:33:40 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id vB1NXdZc003783; Fri, 1 Dec 2017 17:33:39 -0600 Date: Fri, 01 Dec 2017 23:33:00 -0000 From: Segher Boessenkool To: Michael Meissner , GCC Patches , David Edelsohn , Bill Schmidt Subject: Re: [PATCH #2], PR target/81959, Fix ++int to _Float128 conversion on power9 Message-ID: <20171201233339.GI10515@gate.crashing.org> References: <20171130215244.GA21037@ibm-tiger.the-meissners.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171130215244.GA21037@ibm-tiger.the-meissners.org> User-Agent: Mutt/1.4.2.3i X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00076.txt.bz2 Hi! On Thu, Nov 30, 2017 at 04:52:44PM -0500, Michael Meissner wrote: > No, then it tends to generate worse code if it is done before the first split > pass (because it no longer keeps the address together). I've been thinking > that in general, we should replace these calls with a new predicate that before > register allocation allows normal memory addresses, but during/after RA, it > becomes more strict. In my experience, with RELOAD that wasn't feasible, but > LRA can handle it (and RELOAD is no longer an issue). Can't you use the "strict" arg to legitimate_address_p and friends? > > --- gcc/testsuite/gcc.target/powerpc/pr81959.c (revision 0) > > +++ gcc/testsuite/gcc.target/powerpc/pr81959.c (revision 0) > > @@ -0,0 +1,25 @@ > > +/* { dg-do compile { target { powerpc64*-*-* && lp64 } } } */ > > +/* { dg-require-effective-target powerpc_p9vector_ok } */ > > +/* { dg-options "-mpower9-vector -O2 -mfloat128" } */ > > powerpc*-*-*, or does that not work? > > It needs 64-bit because various machine independent parts of the compiler want > to use TImode if there is arithmetic support for KFmode to copy things, and > TImode isn't supported in 32-bit. That's what lp64 is for. > The __float128 support is not built if the compiler is a 32-bit compiler (the > enabler for _float128 is in linux64.h) So we need some bugzilla predicate for that really? Okay for trunk. Further improvements welcome ;-) Thanks! Segher