From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 46786 invoked by alias); 1 Dec 2017 23:46:17 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 46777 invoked by uid 89); 1 Dec 2017 23:46:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-10.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,KAM_NUMSUBJECT,KB_WAM_FROM_NAME_SINGLEWORD,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy= X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 01 Dec 2017 23:46:16 +0000 Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id vB1NiU2q131729 for ; Fri, 1 Dec 2017 18:46:14 -0500 Received: from e32.co.us.ibm.com (e32.co.us.ibm.com [32.97.110.150]) by mx0b-001b2d01.pphosted.com with ESMTP id 2ekd6ngmex-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Fri, 01 Dec 2017 18:46:14 -0500 Received: from localhost by e32.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 1 Dec 2017 16:46:13 -0700 Received: from b03cxnp08027.gho.boulder.ibm.com (9.17.130.19) by e32.co.us.ibm.com (192.168.1.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 1 Dec 2017 16:46:11 -0700 Received: from b03ledav006.gho.boulder.ibm.com (b03ledav006.gho.boulder.ibm.com [9.17.130.237]) by b03cxnp08027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id vB1NkATq63438968; Fri, 1 Dec 2017 16:46:10 -0700 Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C782DC6043; Fri, 1 Dec 2017 16:46:10 -0700 (MST) Received: from ibm-tiger.the-meissners.org (unknown [9.32.77.111]) by b03ledav006.gho.boulder.ibm.com (Postfix) with ESMTP id AD888C6037; Fri, 1 Dec 2017 16:46:10 -0700 (MST) Received: by ibm-tiger.the-meissners.org (Postfix, from userid 500) id 1D93748381; Fri, 1 Dec 2017 18:46:09 -0500 (EST) Date: Fri, 01 Dec 2017 23:46:00 -0000 From: Michael Meissner To: Segher Boessenkool Cc: Michael Meissner , GCC Patches , David Edelsohn , Bill Schmidt Subject: Re: [PATCH #2], PR target/81959, Fix ++int to _Float128 conversion on power9 Mail-Followup-To: Michael Meissner , Segher Boessenkool , GCC Patches , David Edelsohn , Bill Schmidt References: <20171130215244.GA21037@ibm-tiger.the-meissners.org> <20171201233339.GI10515@gate.crashing.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171201233339.GI10515@gate.crashing.org> User-Agent: Mutt/1.5.20 (2009-12-10) X-TM-AS-GCONF: 00 x-cbid: 17120123-0004-0000-0000-000013505AC1 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00008138; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000243; SDB=6.00954077; UDB=6.00482132; IPR=6.00734153; BA=6.00005726; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00018297; XFM=3.00000015; UTC=2017-12-01 23:46:12 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17120123-0005-0000-0000-0000851A6C60 Message-Id: <20171201234609.GA4042@ibm-tiger.the-meissners.org> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-12-01_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1712010285 X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00078.txt.bz2 On Fri, Dec 01, 2017 at 05:33:39PM -0600, Segher Boessenkool wrote: > Hi! > > On Thu, Nov 30, 2017 at 04:52:44PM -0500, Michael Meissner wrote: > > No, then it tends to generate worse code if it is done before the first split > > pass (because it no longer keeps the address together). I've been thinking > > that in general, we should replace these calls with a new predicate that before > > register allocation allows normal memory addresses, but during/after RA, it > > becomes more strict. In my experience, with RELOAD that wasn't feasible, but > > LRA can handle it (and RELOAD is no longer an issue). > > Can't you use the "strict" arg to legitimate_address_p and friends? Well legitimate_address_p allows various D-form address, pre-inc/pre-dec, etc. It has no context on what the address is being used for. Secondary reload does have the context, but I've seen post reload passes redo stuff (and typically then it has to add more code to match the constraints once again). > > > --- gcc/testsuite/gcc.target/powerpc/pr81959.c (revision 0) > > > +++ gcc/testsuite/gcc.target/powerpc/pr81959.c (revision 0) > > > @@ -0,0 +1,25 @@ > > > +/* { dg-do compile { target { powerpc64*-*-* && lp64 } } } */ > > > +/* { dg-require-effective-target powerpc_p9vector_ok } */ > > > +/* { dg-options "-mpower9-vector -O2 -mfloat128" } */ > > > > powerpc*-*-*, or does that not work? > > > > It needs 64-bit because various machine independent parts of the compiler want > > to use TImode if there is arithmetic support for KFmode to copy things, and > > TImode isn't supported in 32-bit. > > That's what lp64 is for. > > > The __float128 support is not built if the compiler is a 32-bit compiler (the > > enabler for _float128 is in linux64.h) > > So we need some bugzilla predicate for that really? Or possibly implement the support in 32-bit compilers (and not break embedded targets). > Okay for trunk. Further improvements welcome ;-) Thanks! -- Michael Meissner, IBM IBM, M/S 2506R, 550 King Street, Littleton, MA 01460-6245, USA email: meissner@linux.vnet.ibm.com, phone: +1 (978) 899-4797