From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 55405 invoked by alias); 1 Dec 2017 23:54:01 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 55396 invoked by uid 89); 1 Dec 2017 23:54:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-10.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KB_WAM_FROM_NAME_SINGLEWORD,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: gate.crashing.org Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 01 Dec 2017 23:53:59 +0000 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id vB1Nru7m004831; Fri, 1 Dec 2017 17:53:57 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id vB1NruFH004830; Fri, 1 Dec 2017 17:53:56 -0600 Date: Fri, 01 Dec 2017 23:54:00 -0000 From: Segher Boessenkool To: Michael Meissner , Martin Sebor , GCC Patches , David Edelsohn , Bill Schmidt Subject: Re: [PATCH] PR libgcc/83112, Fix warnings on libgcc float128-ifunc.c Message-ID: <20171201235355.GL10515@gate.crashing.org> References: <20171127192131.GA15914@ibm-tiger.the-meissners.org> <20171127234009.GA28990@ibm-tiger.the-meissners.org> <20171130024250.GX10515@gate.crashing.org> <20171130205425.GA11524@ibm-tiger.the-meissners.org> <20171201054022.GA5348@ibm-tiger.the-meissners.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171201054022.GA5348@ibm-tiger.the-meissners.org> User-Agent: Mutt/1.4.2.3i X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00079.txt.bz2 On Fri, Dec 01, 2017 at 12:40:22AM -0500, Michael Meissner wrote: > After committing the previous patch, I noticed that it was now generating > warnings for __{mul,div}kc3_{sw,hw} not having a prototype that I hadn't > noticed during development of the patch. This is due to the fact that before I > added the ifunc support, it was only compiling __{mul,div}kc3, and those have > built-in declarations. I installed this patch as being obvious: > > 2017-11-30 Michael Meissner > > * config/rs6000/_mulkc3.c (__mulkc3): Add forward declaration. > * config/rs6000/_divkc3.c (__divkc3): Likewise. > > Index: libgcc/config/rs6000/_divkc3.c > =================================================================== > --- libgcc/config/rs6000/_divkc3.c (revision 255288) > +++ libgcc/config/rs6000/_divkc3.c (working copy) > @@ -37,6 +37,8 @@ typedef __complex float KCtype __attribu > #define __divkc3 __divkc3_sw > #endif > > +extern KCtype __divkc3 (KFtype, KFtype, KFtype, KFtype); > + > KCtype > __divkc3 (KFtype a, KFtype b, KFtype c, KFtype d) > { How does this warn? -Wmissing-declarations? Should this declaration be in a header then? A code comment explaining why you do a declaration for exactly the same thing as there is two lines later would help; otherwise people will try to delete it again :-) Segher