From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58946 invoked by alias); 5 Dec 2017 14:38:06 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 58917 invoked by uid 89); 5 Dec 2017 14:38:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=mistake!, Hx-languages-length:1144, H*RU:sk:AM5EUR0, H*r:sk:AM5EUR0 X-HELO: EUR01-HE1-obe.outbound.protection.outlook.com Received: from mail-he1eur01on0080.outbound.protection.outlook.com (HELO EUR01-HE1-obe.outbound.protection.outlook.com) (104.47.0.80) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 05 Dec 2017 14:38:02 +0000 Received: from DB6PR0802CA0042.eurprd08.prod.outlook.com (2603:10a6:4:a3::28) by AM2PR08MB0131.eurprd08.prod.outlook.com (2a01:111:e400:841e::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.282.5; Tue, 5 Dec 2017 14:37:59 +0000 Received: from AM5EUR03FT004.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e08::206) by DB6PR0802CA0042.outlook.office365.com (2603:10a6:4:a3::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.282.5 via Frontend Transport; Tue, 5 Dec 2017 14:37:59 +0000 Authentication-Results: spf=pass (sender IP is 217.140.96.140) smtp.mailfrom=arm.com; linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 217.140.96.140 as permitted sender) receiver=protection.outlook.com; client-ip=217.140.96.140; helo=nebula.arm.com; Received: from nebula.arm.com (217.140.96.140) by AM5EUR03FT004.mail.protection.outlook.com (10.152.16.163) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.20.282.5 via Frontend Transport; Tue, 5 Dec 2017 14:37:58 +0000 Received: from arm.com (10.1.2.79) by mail.arm.com (10.1.106.66) with Microsoft SMTP Server id 14.3.294.0; Tue, 5 Dec 2017 14:37:40 +0000 Date: Tue, 05 Dec 2017 14:38:00 -0000 From: James Greenhalgh To: , , , CC: Subject: Re: [AArch64] Fix some define_insn_and_split conditions Message-ID: <20171205143740.GA5600@arm.com> References: <87wp21b653.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <87wp21b653.fsf@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:217.140.96.140;IPV:CAL;SCL:-1;CTRY:GB;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(39860400002)(346002)(376002)(2980300002)(438002)(377424004)(189002)(24454002)(199003)(106466001)(8676002)(246002)(104016004)(1076002)(305945005)(23726003)(356003)(5660300001)(189998001)(47776003)(2950100002)(6246003)(26826003)(478600001)(2201001)(72206003)(83506002)(58126008)(4326008)(8936002)(316002)(86362001)(110136005)(50466002)(77096006)(16586007)(229853002)(106002)(55016002)(54356011)(7696005)(36756003)(97756001)(33656002)(76176011)(6286002)(2906002)(46406003)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:AM2PR08MB0131;H:nebula.arm.com;FPR:;SPF:Pass;PTR:fw-tnat.cambridge.arm.com;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;AM5EUR03FT004;1:qLT0FajNqYF0C7+gVt9maJuTUatYtspRT3ESuH6c8tajiKXffoNj/h/kqs6niK6TNCQztKRtYp+1K4Gu02xUUrz3ghLTOfxDLdmqfKGZrpDKjoeElQJ/AIPQSaF3juPs X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 14b15ec9-4e36-4f56-f1ba-08d53bedc7d8 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(4608076)(2017052603286);SRVR:AM2PR08MB0131; X-Microsoft-Exchange-Diagnostics: 1;AM2PR08MB0131;3:zl+fOD3hxDMzmTnzVDJBxGF+MlM3Ug3HDF9+eKLkgzcRNcnN0yRtiAX/QEalJ6q2dkpMxTe3lk0j7s5OOFpcADGFKZJDQKmXplk4ep7lxp3oJtAVOrBfNYSr3oFoyiL68xFWVmYUcsRwvo8MMou27QcB90hSy3wL04H42a26ahr/Fhxb1aWtCsjiWMqIUrtd73ecTMg1B5SFkD4Gw8/5qzI+82HCcsBMDTGf6GRdcuQb3GebLl3ZaYEmNSr5HpL8EcD8PPBFoOdsoY0/hXyxV7jXa7k/eAns3b6EJLVNSbnSdtail8er7eNA0WzInT/0BXXX7R/NYGjolJK0SNmY3ziCrtQ5NrZ14fyyy67Sn2A=;25:QR5yMubl7fP/Wdrw2xwMrddr51rYIw/iP3j/RMzw9yjjSOQyJ4ElweifNKBkQABHvPMW7Ll0ZidXF903wYNlyu6LuGaJQywvgna1SmPIxOdAOv/dmQ68sIOlyFI3kSrM+HWxNZ44AOlqWa2WGG3wRZeje+UY4F7OM9Wu+TJJT/exD3nhwDacnXfPoMzoEO07Z31p8Sh03dGAqz4NpNTG17Hh22kX91687DAITL04MwlIfads3VLGrbrnc76VE/AVjF+JllaHrSvA1Vu/zaGeaMzToahXWqOpndFb0v+LOEDa51iz5UuJhrF/mVYzUhtE6i2RNti0juPvMPq6YSPIzg== X-MS-TrafficTypeDiagnostic: AM2PR08MB0131: X-Microsoft-Exchange-Diagnostics: 1;AM2PR08MB0131;31:F8Ga/auHUt7CoJhhpYxcLNA9xvCG4O9OzNXHIVZ0JfuI0Ou3j/Lf7mMAbf8E735lfNBXashPXAvH8LaSjncp0FUuUw8p0XuJOKN0+hopJYICYMVghvPU0INUbs/JGefcOFACTaVA9NllTRHwq2suin9LjZUlpZGw/lqwi12pZVCmQ3gfUajkQNETkQB0eqK/JtOBs6MqaPB/Vo3Pj+HIHv1EVJOOq7qAPqfwyzFkqWY=;20:wNHCVKmgFfsjfjXqScA55taFUTO+N2Y56pVtWeeQGgI4mtZOuk1aXXr40dr24JMJ5cEObk8x3dehrsvXlsmj9wbZy6X+hhPU3vb5qSZOoTSr8qvmDxwF27NxLmpVU1PDunk/0UcKaaeJIvWiGjrUiXqOSgngZBrL6B4yXKFPbcm1omkjOgFRvdeC2XTdspzEx+MDMSX7HhBjctgkdLZLVPCqCnhHkofSjvHCTQCn7XWC/Y3G5w3RJ38peUo+69Rw;4:I6g54/InEiAKOBcCzJIQHfbX84blM3Olifh1sZxaXhSnoZ84Sdw+hrB6pqLW3eoVoD4CVj4ZU0W+7uHiThw03+h+yX38cf1S0F4I8GuR+zZzhRd6IK+N9ff6y6DkmmzK/jTjexr1hKrpaTtDY0mK9C/Bj0VQAygPTCZDqiIDYs4IRCYOqsYO/NgswWGOw1MY70HjUA/ii2O8efsnoLLn8Jw7oQkABNMX6Kth49Nawxi7OFY0diK73vOtLlrn8yBAI20NqfSCPiUIFITAkHJDlw== NoDisclaimer: True X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(5005006)(8121501046)(93006095)(93004095)(10201501046)(3002001)(3231022)(6055026)(6041248)(20161123562025)(20161123560025)(20161123555025)(20161123564025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011);SRVR:AM2PR08MB0131;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:AM2PR08MB0131; X-Forefront-PRVS: 0512CC5201 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;AM2PR08MB0131;23:CnDZ1oUJjGoGPG3LqypiIoszeoQPJDPOBmWFgjZ0j?= =?us-ascii?Q?d3RI6Lgbdwoei2grYMX5YATohMV4R6bppseDXtMhpBZ11Bq3Baa7+RGP+Gvd?= =?us-ascii?Q?jcMczTgmMit0daEP+WqxZ3x7ZCB5ntTeNwjjILQSfFEYJo6SSkVAywdU5rWa?= =?us-ascii?Q?gHWEEera63qRSZSogUh/CYiTBmlyEqL/toL8Ks/JYV1/C9M411OsBowQYICk?= =?us-ascii?Q?bvDWF5v+u5GWag8jyiCyjp4SoanRkXtwJDSBxpj/iZes1ADiYBHncjRpxx0z?= =?us-ascii?Q?aKz/ijGH9cxZ1xyFACEFt8QwXvrdBBst9GqjtSvjFPmI9NvrGzx52XuTKbvg?= =?us-ascii?Q?b56+Bibm9yPfWp4MGEyGTc6dia1lveE5a0XMYlTPQXo+WG9+f8E8LzCmkEDl?= =?us-ascii?Q?a7Yq0DnIY8NzZkr3l44X0GqDL3eXf5QHeKB4awXe9k7NdXYxGMxcL8Ni1YOG?= =?us-ascii?Q?HWKIiiNnk42ylvbTpzPJa/Mvup9UDU9AWQ6MKt4yZB6u+rsYltQSolrVNzJW?= =?us-ascii?Q?kaelSXNhNyuGbw48vSvEqRr6iFDD/+FyJ9OxoPkdKf/F8+oNBTC+CMBaMNoZ?= =?us-ascii?Q?ZVbPKmYqAz1L+5tbzYUud8egk3yqXJ37eEUZFWvJnQSiCWZOOqpbAHUZNm4x?= =?us-ascii?Q?zkA0AUMSi5y3jvm0GzAMY6hEG04CszXGHoyhODvMXoboKpfaP2PEb0viBh0d?= =?us-ascii?Q?/lpjPCZ2r9f7nDsZKb92eFZdcaOtNd9XXsOBHCPpYW2byk9WYzJAMCdZesyb?= =?us-ascii?Q?Ejv3XD20X5XuxdFKvijEEsy/apM8JwxkRXqCaSDnRPH0lj2KVVElaN0sOFJC?= =?us-ascii?Q?rgQqa1oNlcA7Iue9Ft4nhticJMmI5VJKOVKO+vFvS1HXW2Z6/AUba9U6CwkM?= =?us-ascii?Q?AzO6dNIfLrrkB6HprOBVYJjzFmoFDlYJB4opq8NzrQ51Cl7uIHYcXDt/I6Cc?= =?us-ascii?Q?bJe6d6gE3xGq8Xlj/DgJ2iZha44t9EWUFxlE8ztYiOXWUSxoWnOwLHmY1nTT?= =?us-ascii?Q?wdxNgyaRdqyvwRdV8otBoPcIqd2Ip/TUfSfuMZRyh3qatr/VBrPBhviumkzN?= =?us-ascii?Q?cnbLg83aTa/iJeHPASwaHi4BmUagMxwOd4DR83WaUx66MVM9suqZm0YQCrjj?= =?us-ascii?Q?pOopmbP6pPGs7reKKlUJ6lKDJ5M+Oj/E01Y4uk7Bj6ODBqMQW9pag=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;AM2PR08MB0131;6:Gr3xFt4bV+AZYZgvRfQvjpu9zubSliYzDW803eIF6eFYlhH3qhwVCKtL31+LF+UzUtZ3Fze3lpEOQB+FX4z9//KMk6BwZN8qWgommWMtXPWhxfVvcfMhCyolaUwb2c6LFMqt5GPOThGk/iZ5PNIQXFzbS5OeD7DCibWu78qUJoD64+ZxOejnnXy7xh9zpRuDdnFzyqzO3ZvePxRSnPvJWB5St8KopsAkSbFztzKksRkEDddLmBi/g7tOLhx5X0Q1nnu7W57Z1mWphWrG9kbtfs7gSdTnHlqT4jhB5c26Od1mJ4DNVoTY+w+x8OocllfeR+/Bzxr2Z45gC4B4njkcy6TJsiJX+UEgNGbmzBEWiIM=;5:kIyyRobz6KEhppcx4sT79lZdeHyDK1xrfVYa6EhudCOY/VFHpWfwQx9ML/021wffhuKzWUpqKyns3+QZVxZG5ClNSY29WY2mEXkxzP7KWVr+7UCIEU0sejnn13QC4I409ofXF3HADjpCvLh+UQkMhSF5fmCQ8JNzVcm8eAUmJ20=;24:M1omueR+0fTOKaydD7YlP8eYvg/3UdpxFD8XJ8Rel/KFf/+VcX/J4U+3pJhc4PDKSmT6pgZ9QvoxmvxystqmSmqPl8M4nqnjCVCQJ0+OKCE=;7:s0QaxWBrPtFCGXExSoFkqtd0Dl7dpXsU437djXTiSalFTwKH3A7KWRR5Ma8VI+QqN2BYZXqWo5jz0Dj7KtywQylqP3eh9/u88l99jIhkzdh6b3YntkITN7pyppK3vTySonqvr3XxAXVpgSytnEog47bA3xt4RXasIBd7211PThZdpwqs5HWsmgsW0R8rxrEnfj1pu/h1cbnmNyw6Me/5aeDZHhEx4jt2kYQd8urzt78xguKhZn2BuyApaXVGtFgJ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2017 14:37:58.6620 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 14b15ec9-4e36-4f56-f1ba-08d53bedc7d8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[217.140.96.140];Helo=[nebula.arm.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR08MB0131 X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00228.txt.bz2 On Tue, Dec 05, 2017 at 02:28:56PM +0000, Richard Sandiford wrote: > The split conditions for aarch64_simd_bsldi_internal and > aarch64_simd_bsldi_alt were: > > "&& GP_REGNUM_P (REGNO (operands[0]))" > > But since they (deliberately) can be split before reload, the operand > matched by register_operand can be a SUBREG rather than a REG. This > triggered a boostrap failure building libgcc with rtl checking enabled. > > While checking other define_insn_and_splits for the same thing, > I noticed a couple of SIMD ones were missing the leading "&&", > meaning that they would trigger even without TARGET_SIMD. That > shouldn't matter in practice, since combine should never end up > generating matching rtl, but... > > Tested on aarch64-linux-gnu. OK to install? OK. Thanks for fixing my mistake! James > 2017-12-05 Richard Sandiford > > gcc/ > * config/aarch64/aarch64-simd.md (aarch64_simd_bsldi_internal) > (aarch64_simd_bsldi_alt): Check REG_P before GP_REGNUM_P. > (aarch64_cmdi, aarch64_cmtstdi): Add leading "&&" to > split condition. >