From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34464 invoked by alias); 5 Dec 2017 14:39:46 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 33385 invoked by uid 89); 5 Dec 2017 14:39:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1448 X-HELO: EUR01-VE1-obe.outbound.protection.outlook.com Received: from mail-ve1eur01on0071.outbound.protection.outlook.com (HELO EUR01-VE1-obe.outbound.protection.outlook.com) (104.47.1.71) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 05 Dec 2017 14:39:44 +0000 Received: from HE1PR08CA0078.eurprd08.prod.outlook.com (2603:10a6:7:2a::49) by HE1PR0801MB1530.eurprd08.prod.outlook.com (2603:10a6:3:13::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.282.5; Tue, 5 Dec 2017 14:39:40 +0000 Received: from AM5EUR03FT018.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e08::207) by HE1PR08CA0078.outlook.office365.com (2603:10a6:7:2a::49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.282.5 via Frontend Transport; Tue, 5 Dec 2017 14:39:40 +0000 Authentication-Results: spf=pass (sender IP is 217.140.96.140) smtp.mailfrom=arm.com; gcc.gnu.org; dkim=none (message not signed) header.d=none;gcc.gnu.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 217.140.96.140 as permitted sender) receiver=protection.outlook.com; client-ip=217.140.96.140; helo=nebula.arm.com; Received: from nebula.arm.com (217.140.96.140) by AM5EUR03FT018.mail.protection.outlook.com (10.152.16.114) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.20.282.5 via Frontend Transport; Tue, 5 Dec 2017 14:39:39 +0000 Received: from arm.com (10.1.2.79) by mail.arm.com (10.1.106.66) with Microsoft SMTP Server id 14.3.294.0; Tue, 5 Dec 2017 14:39:07 +0000 Date: Tue, 05 Dec 2017 14:39:00 -0000 From: James Greenhalgh To: Steve Ellcey CC: Kyrill Tkachov , gcc-patches , Richard Earnshaw , Marcus Shawcroft , Subject: Re: [Patch][aarch64] Add missing thunderx2-t99 instruction scheduling pipeline descriptions. Message-ID: <20171205143906.GB5600@arm.com> References: <1512153744.14842.3.camel@cavium.com> <5A258369.4090109@foss.arm.com> <1512408817.14842.15.camel@cavium.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1512408817.14842.15.camel@cavium.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:217.140.96.140;IPV:CAL;SCL:-1;CTRY:GB;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(39860400002)(346002)(376002)(2980300002)(438002)(199003)(377424004)(189002)(24454002)(58126008)(316002)(36756003)(6246003)(2950100002)(5660300001)(54906003)(106002)(55016002)(6916009)(6286002)(106466001)(104016004)(4326008)(8676002)(23756003)(229853002)(305945005)(356003)(86362001)(575784001)(8936002)(246002)(77096006)(189998001)(47776003)(2870700001)(76176011)(478600001)(2906002)(1076002)(54356011)(26826003)(83506002)(50466002)(72206003)(33656002)(7696005)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR0801MB1530;H:nebula.arm.com;FPR:;SPF:Pass;PTR:fw-tnat.cambridge.arm.com;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;AM5EUR03FT018;1:FZVLzJ2gNddAQ7D01eKdZ1UeHuepbqpWFSsCjGC92kg6R98uwDV33E4sbbFP42nHz553LuJXHLAAB46/7mCXkUXCfKfEpv7hamBaiXYkoBipwAMDYc9X2hF4ALljVDdC X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e8cb090d-c769-405e-ef8e-08d53bee0415 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(4608076)(2017052603286);SRVR:HE1PR0801MB1530; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1530;3:UWIZ/Oaspv2VSVGSP3wKHKqmxoA5FgUgpbxVFgWNUgvT4G1JD4YDIiFSpy5x9Xvzn5HLcYvdG5afy6gvArmAHgvDfv8U4kwbmMnYVkE9Ckz530CEOsGCmYG/vq5vRStS7vFE9ouKwIm7/fNYVYo8gmJDbR0elVEQUAiPOqVXvcVtbvi/tCpafyOp4ZegBTiEj3gAmUGpvvaBYcTr2RnekOK5rJx7K1OmrITmA6vpnZixttKU174ZMh8VrGzUBh54bcMErDhhjNUToTqqoPV4xeR4oqj24Pd0/itKYhgeCLrB0wPrJy9iFA9BpEyfaie34RWy4cTcJW6EPRVsFTPM/kP9oXrzujmtNuPStFvLtMI=;25:hqlN+nLY5bLp1lfBjdLqoOJl1IfJMCwA9ZaK3dkvIdFNLNy9iq33kyuEdI0lmBk2bXzhuTs9Xxq99ZPtNExq65XQ41hZyaicAXJf1jNU3ZxpyOpCIRjWfnkD6i4Mq2JthUa+7CabQiRGV0IGvxzX07UTsrFdzOQVfCnz5WBSat6zNV2oDug/qPN6og6V4yU1cLgt1PVlpV9SgFsMWVqz2evcRQMgZNyrGLJ6IvR4ubK9fbgCF6FVrsVfpTWweMIygjnWGpQT96o91Mt7ACazOYFkYm0YhSK22EOXiwxPLDkexvFaDWDXVKrGJ4vGQyYdPxY1WEW0Ywj3jaXg8q25dg== X-MS-TrafficTypeDiagnostic: HE1PR0801MB1530: X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1530;31:2t/PJYXTFR9cxiofuEVzHIYKNz2lM7MPrJOIVApJs657riFRRAOlq1o3HFXg3MWaDt/o50kDyvHiEiA0Uy/SdYYkQl3h+hkTE9LT6FGMjWin0uNFVXMDa2eYqlzge71FBUH95vl9SVHWj+4mFbG3lhHCq9KbaTA7PfsmYMsc6bwj886vK58CviwJCTZYlpyq/Z5Zd1nSI0jduR8Fz5NG22zYn2q1YT5gR8AYjJEax6E=;20:xkGFJLCavysAiGaqMYb16CK2IiyrrsgR74PqHZoem2pYRIHkxMZKw1zNuwFP3sd4vm0tuJVTCh26JJF7wV2En2e4IN+wo8QmAwwLoH7lsQUG9XvvY8pcAHuj/xyK9MHp2t3e1HmBMVWHU15Ex4SCBBEIqIikgMNwIKYZboFUcZ/l1azRLmoFYOhp8OtBmq1VyjDDVUmFJN0KhTGgXy6fNE5Ia8+n6dA2/9CrirTUNeF67HRTh6GzCe6X/NlPeuZa;4:kdgUMApJ0bAE22h46a7gLrFcpzKxYAoxjzrRNTUZqU+XDB+WRImw7DpXaAZqft2PpL9zOIc5WmcCut5NsxtRjS4V1W7wisggBUDz+KKsfva0DDqclnq58+bPEA6AqfRw9pJuSs2ISBpcZJc05lIYJo0Kl3O2v9d186XGewjTQhn+tOVvAZK4c2EY+JgnJwlJ08RshOc4hrN7LK0sVpNunFQLuk8FPLvjpEIxRPIhqo7RNGyu2bf04NhOlhu9n7TTDELJZXejcQJ9RhDnlZbzpQ== NoDisclaimer: True X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(8121501046)(5005006)(3002001)(93006095)(93004095)(10201501046)(3231022)(6055026)(6041248)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123564025)(20161123555025)(20161123562025)(6072148)(201708071742011);SRVR:HE1PR0801MB1530;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:HE1PR0801MB1530; X-Forefront-PRVS: 0512CC5201 X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;HE1PR0801MB1530;23:vw0xhJjoo+RhE+EQReEI+jcFG6KLcNpcVCJQb?= =?iso-8859-1?Q?PduKSd1UndW2Q+kAr12lgurVI6krI4gF17C3D0UCOTbHLYNxDDkgnlbbCP?= =?iso-8859-1?Q?wqTy755isQLapCNsnj6rwhBiAiQ7XKYO2YuyO79LaXiIXZK50v5ftjIDUr?= =?iso-8859-1?Q?t2bf+40GqzPgYUOV13H7GgzpKOOEvbwqMkVREUys1ZkxbNCc2meA6UJaVr?= =?iso-8859-1?Q?zDl8zB022VY5lJJZK+3x+epnfjhmHZ7UYKPqzXgGDmHuu/1HPD5+GX1owc?= =?iso-8859-1?Q?WBosl7v0yo8y/l8khha0LzZNFrbyh6vncyJFQx8I8nTwpT1+D+76ITp5YT?= =?iso-8859-1?Q?2yutQCO7+PYnGKgtHKBd6cuvu8Yd9BpXC4WsOMOLk8zIxMPPSq+LqP1OyI?= =?iso-8859-1?Q?B9UEO7P0TwYuzRcW7PifkX3gySCMNy9gJN4/AHT+Pj91DHx3+7UhPaXoa6?= =?iso-8859-1?Q?p0YGAEVHRJ3s6zW3Fsm52x8E1ym8tKk37w+ZkEwB0xDV3TZDhOoXSNodSz?= =?iso-8859-1?Q?NqQOjZLx4BiX3MA/NiL1Okx1B/Qv9amoGhW6cnbCOR6cVazEOFrUmp26r+?= =?iso-8859-1?Q?W3DEsterMp9clwY/IZAZ9k/k/4h9LD8bhCVc3S86nuAG75l1Vm1bCD7Vb1?= =?iso-8859-1?Q?FoFKJgnnyb5Ait9EvVSW71w9nupSuVFqdM2GfFDlcyEq4gKV5OaAYy4wL7?= =?iso-8859-1?Q?QKVbie35roFNg3gSLXlICP9rw+/rsta4Mfb0vTOPzzDa7mEPDd3L0fAbXS?= =?iso-8859-1?Q?4XMZ2sH0I+0MsoL20seZK8inFzv/Nobhuj8oziDeYrdV5p4mpfeXIv2N3e?= =?iso-8859-1?Q?/anZI8catrKuu0CsUflZs4iVNGlsmtn9qK0oRzB8/7bgTm44YdW7sHL3Vq?= =?iso-8859-1?Q?9FKa6v/N/WFWW8dxfg2I72/qAtz0yZMbs9pitpIPaDFCrvViHyPGEiCCUt?= =?iso-8859-1?Q?qpY/qbsH5mOciIKSDnNhaYnXthSl1qXZvalVrN5nrjljdzFZB3qyAx7Js6?= =?iso-8859-1?Q?m1x+d54QbX8bTi95g289R+meASIQO9X6Bl8ptuIs+5D+5pNc+ZayNzN8Gz?= =?iso-8859-1?Q?l/nHqK5dtLKsbgHrbeFmCbldtHsnceFiZxiIrnNc5ArIf1kPiJCBhP/V8v?= =?iso-8859-1?Q?dRGMX0Dc8+uXK4f49wecoa/tRkkIYbDifQv9knSFxhhy/G0+B/nmvE9+Vv?= =?iso-8859-1?Q?dPfJa3CF39aT/?= X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1530;6:CuYyJjOBDDLXA9QQHkn6MrCiSTgDVd2GP2HIhbT5qn4gGQTZfZlf+V7RIQUl2vTdwNn3gnOCymkLEOV/AFo7AjDXsDiA/Z3cMldNdn+msqgcglTgLlgs7FroPn8TKM0PfvMjSqJ8J47HOLAGQLcYnDjMoqltrVLSjrIQUrERXTdECGiabS/X/HsCELiz1Ao6subsSacliSep+blw59tk6uDkvjP9Y46bqnNQ2iG60e57uZDDGDTCswZijvZFWyd9hurXHdFTbiNzm4E0wPaHiu5O3wK+BIcrwVMxeo+aALPnVC05j57wgHkWscyFC3UsO/YjfBDalCpzG30L+ZorESLHjxiCKtmGhmm38s1TsLc=;5:TFWBxmPaKtIxIqHInqcns7HZSdtwFXpWtJ+D1zZhrATNlLLSfhrKNps7vobASaNFu8fhZDzllc1k1l61Esqvsb2wpK3Br8c3hh5fR0w5MwfaO+1LVUwzIvcM1ad8ZfysRYVQnBtjNpWfKFQFqthjeT+3nOoNEpLMi4/jjtUtfjo=;24:1tuMHSYjxPsCW84cZAoyTPEX4uG00hq5p98uCJH+KL/zb4WtBH4khTcoEg+cmtlZDCsYWnG8dwCuWznpR/5DjyxLx9LQ6SSwI4X6HXSVNck=;7:RshS9BntZoxJ965CjjigcEjLjV/XpNk50lVzBWzbTQ/pecLODD6ytgt5ck1sJ9zt6B/5azi1sQfif+JTmbZaMRbMekZOcIpNKO3WRRVfkZxUNGvUFXMTU1VNc4r+FnuZ1CQGlIN88BtYWF0KUY6nuOUa4YoK3IzD/mw0SRbu8FXklJRyS14XJbAX8kSpMB1f6gNkpi6i6iovIGKjAx0+eNmoESJlGStJEUoNIkWRI7uZq+LvwVxjBsJf/MpGfmAq SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2017 14:39:39.6782 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e8cb090d-c769-405e-ef8e-08d53bee0415 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[217.140.96.140];Helo=[nebula.arm.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1530 X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00229.txt.bz2 On Mon, Dec 04, 2017 at 05:33:37PM +0000, Steve Ellcey wrote: > On Mon, 2017-12-04 at 17:18 +0000, Kyrill Tkachov wrote: > > > > +(define_insn_reservation "thunderx2t99_multiple" 1 > > > +  (and (eq_attr "tune" "thunderx2t99") > > > +       (eq_attr "type" "multiple")) > > > +  "thunderx2t99_i0+thunderx2t99_i1+thunderx2t99_i2+thunderx2t99_ls > > > 0+thunderx2t99_ls1+thunderx2t99_sd+thunderx2t99_i1m1+thunderx2t99_i > > > 1m2+thunderx2t99_i1m3+thunderx2t99_ls0d1+thunderx2t99_ls0d2+thunder > > > x2t99_ls0d3+thunderx2t99_ls1d1+thunderx2t99_ls1d2+thunderx2t99_ls1d > > > 3+thunderx2t99_f0+thunderx2t99_f1") > > > + > > We try to adhere to the 80 columns per line rule in the scheduling  > > description files as well, > > so can you please use "\" to break this into multiple lines. > > Yes, I wasn't sure if whatever program parses this file would honor > backslashes so I didn't break it up.  The falkor_extra definition in > falkor.md that I looked at is more than 80 characters and that is one > of the reasons I wasn't sure backslashes would be honored.  But I see > other places (power8.md) where the backslashes are used so I will make > that change if and when the patch is approved. As long as it bootstraps I'm happy to take it - I'm sure you're better placed to spot and understand regressions in thunderx2t99 performance than I am. OK Thanks, James